From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754561AbcLAAEP (ORCPT ); Wed, 30 Nov 2016 19:04:15 -0500 Received: from mail-ua0-f194.google.com ([209.85.217.194]:33176 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbcLAAEN (ORCPT ); Wed, 30 Nov 2016 19:04:13 -0500 MIME-Version: 1.0 X-Originating-IP: [96.230.190.88] In-Reply-To: <1479215774-29810-1-git-send-email-fw@strlen.de> References: <1479215774-29810-1-git-send-email-fw@strlen.de> From: Paul Moore Date: Wed, 30 Nov 2016 19:04:11 -0500 Message-ID: Subject: Re: [PATCH] audit: remove the audit freelist To: Florian Westphal Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com, Eric Paris Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > allows better debugging as freeing audit buffers now always honors slub > debug hooks (e.g. object poisoning) and leak checker can detect the > free operation. > > Removal also results in a small speedup (using > single rule 'iptables -A INPUT -i lo -j AUDIT --type drop'): > > super_netperf 4 -H 127.0.0.1 -l 360 -t UDP_RR -- -R 1 -m 64 > Before: > 294953 > After: > 298013 > > (alloc/free no longer serializes on spinlock, allocator can use percpu > pool). > > Signed-off-by: Florian Westphal > --- > kernel/audit.c | 53 ++++++++--------------------------------------------- > 1 file changed, 8 insertions(+), 45 deletions(-) Sorry for the delay, I was hoping to have some time to play around with this and offer a more meaningful comment ... I've often wondered about converting audit_buffer, and audit_context for that matter, over to their own kmem_cache; have you considered that? Or was this proposed due to simplicity? -- paul moore www.paul-moore.com