From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f45.google.com ([209.85.213.45]:33852 "EHLO mail-vk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933313AbdDFLvu (ORCPT ); Thu, 6 Apr 2017 07:51:50 -0400 Received: by mail-vk0-f45.google.com with SMTP id z204so37360273vkd.1 for ; Thu, 06 Apr 2017 04:51:49 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170405073848.GB8899@quack2.suse.cz> References: <20170403153424.24945-1-jack@suse.cz> <20170403153424.24945-6-jack@suse.cz> <20170405073848.GB8899@quack2.suse.cz> From: Paul Moore Date: Thu, 6 Apr 2017 07:51:48 -0400 Message-ID: Subject: Re: [PATCH 05/35] audit_tree: Use mark flags to check whether mark is alive To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, Miklos Szeredi , Amir Goldstein Content-Type: text/plain; charset=UTF-8 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Apr 5, 2017 at 3:38 AM, Jan Kara wrote: > On Tue 04-04-17 16:47:11, Paul Moore wrote: >> On Mon, Apr 3, 2017 at 11:33 AM, Jan Kara wrote: >> > Currently audit code uses checking of mark->inode to verify whether mark >> > is still alive. Switch that to checking mark flags as that is more >> > logical and current way will become unreliable in future. >> > >> > Reviewed-by: Miklos Szeredi >> > Signed-off-by: Jan Kara >> > --- >> > kernel/audit_tree.c | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Should audit_tree.c:insert_hash() also be updated in a similar manner? > > Do you mean the part which has become chunk_to_key()? ... No, I was talking about the if conditional near the top of the function that checks to see if the fsnotify_mark's inode is non-NULL; it seems like you would also want to convert that to a FSNOTIFY_MARK_FLAG_ATTACHED, yes?