From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C66C6FD19 for ; Wed, 8 Mar 2023 22:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbjCHWQn (ORCPT ); Wed, 8 Mar 2023 17:16:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbjCHWQk (ORCPT ); Wed, 8 Mar 2023 17:16:40 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81AEB87348 for ; Wed, 8 Mar 2023 14:16:38 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id u5so19096120plq.7 for ; Wed, 08 Mar 2023 14:16:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1678313798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tkhViH9kdWNjYXwKnPEs08Xl3095dV6IZ6LM3uHmPgg=; b=bPXrjsfNIA8aCilQN80V8tZJJRnYiUaUiYYE6WDP0poZXHmgRnngHO4Lb96J8qrY8s 0UFv5K7lMRJloKD0tWGMmVKDB1rB7L2PYgY245lC/cGDS2TdHabWAHsD74tYHk7XWX+9 ctSErcrpU4ra1h7MNt4j2JB1T46qH5KSu8XZMjjoIq7fVYdLws67bRDNtSSAyq5ddIEU URzRfvXhHoHE7mhDjTIo/KgBW+4k4yBsfFL5q4a+jwiG/cTxuGsLWCziz32JVyllZ+pC DZbdjHIIJFo9Zy6iaSLyCS5thVAOwak49iMLSnuOr6HQ+YCMlQc6/QjcnOmMkEQALnF5 7qLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678313798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tkhViH9kdWNjYXwKnPEs08Xl3095dV6IZ6LM3uHmPgg=; b=gPfyRtoRFkqK1EUTOmylj8pS59cn0mJ19yrmZD+IJ6Afjq4+Y6FqD8K3HtRTmVuIPj pNw2Q46ao/MgeUDCvr9ZXBoVHUIrV/Sszfd1WZy7v8NuHQnH1wuk4Ee1weY0Kj88Tj6m g+v6Qiwl5FWCx7aFBVqjlr5Ve1ot3lCVerYqPHO4Pg0uZV0hymiGISdBvLYGoQyz8IWV rktAMc9ipc/u+0NdV9Fn/1djIdFahxLwlmwqewP5mTc/9fP/4HqsZILCz5ksdSdnOyRE qtpm8YoeNYRn9zsiX9QACmw6kLKPU10IGSe8mWg2fAWGWvMjI69IVBp4SpMSL+eOzU6y taKA== X-Gm-Message-State: AO0yUKXqzZIeMnd7OE26455dl8z7B0JdRY01WHDxAL3IOUAM3wB+Xc5g eLGO4/vSZWxsTfXUNYButeqISqX7ZgYoFV3m24nC X-Google-Smtp-Source: AK7set++0GvPRL/fArYHKN0SqlsLssuQ2AVagfsEuJmq+L5qFprSO0qSDic4f0ylWLwNIoHyQ3gpdgkwfLpUMJ7FI+Y= X-Received: by 2002:a17:903:2587:b0:19a:9f86:adab with SMTP id jb7-20020a170903258700b0019a9f86adabmr7646529plb.7.1678313797868; Wed, 08 Mar 2023 14:16:37 -0800 (PST) MIME-Version: 1.0 References: <20221201104125.919483-1-roberto.sassu@huaweicloud.com> In-Reply-To: <20221201104125.919483-1-roberto.sassu@huaweicloud.com> From: Paul Moore Date: Wed, 8 Mar 2023 17:16:26 -0500 Message-ID: Subject: Re: [PATCH v7 0/6] evm: Do HMAC of multiple per LSM xattrs for new inodes To: Roberto Sassu Cc: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, casey@schaufler-ca.com, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, keescook@chromium.org, nicolas.bouchinet@clip-os.org, Roberto Sassu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 1, 2022 at 5:42=E2=80=AFAM Roberto Sassu wrote: > > From: Roberto Sassu > > One of the major goals of LSM stacking is to run multiple LSMs side by si= de > without interfering with each other. The ultimate decision will depend on > individual LSM decision. > > Several changes need to be made to the LSM infrastructure to be able to > support that. This patch set tackles one of them: gives to each LSM the > ability to specify one or multiple xattrs to be set at inode creation > time and, at the same time, gives to EVM the ability to access all those > xattrs and calculate the HMAC on them. Hi Roberto, The v7 draft of this patchset had some good discussion, and based on a quick read of the comments it looks like everyone was eventually satisfied that the v7 draft was good and no further changes were necessary, is that correct or do you have an updated draft of this patchset? --=20 paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aib29ajc254.phx1.oracleemaildelivery.com (aib29ajc254.phx1.oracleemaildelivery.com [192.29.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12DAAC64EC4 for ; Wed, 8 Mar 2023 22:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oss-phx-1109; d=oss.oracle.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=TWHleSnOkYY7wljxADwH2nlnfNlAyRzzrYYFW3EnvHU=; b=K2VkXGR8XFRMFtENco3b8MuqyMcpuxNfdZG+zrXJ8v0xbliilMMOveyoUsJ8DZ8VKvEKV1VaiOEq paEVrl3pdlpF6zOc1gl4qUyDNpg2qCWqdooAotSqc0AbDs3/10sSLL3rJAhRGhsdR8np9iS5f3A0 pL7fyjB2gJ3E2DtDnCDZLU0+HVkgoCZEALncxUaa3UEiD7nHXjxfpg2+LLjoHmEHlLo/R+P/2Tzw z6VF91lA315t8V7AncgypQW5vUki7DSOYyYk9Q4dA3wBE6GARZ0TCns8kYp19qFdweM6jDQfbQ7J fC3UuTzp08BEuSBekfp+2xyLSQRIetvySLjtvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-phx-20191217; d=phx1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=TWHleSnOkYY7wljxADwH2nlnfNlAyRzzrYYFW3EnvHU=; b=BtwesyvN7FhiNxHrOckqQFIpABC41llOnWhKNpTbncRVXFYBOpBnulzeOAKxMGsrgTOE+shCVgku xpEmA5dufyruNO+JSVW4DWJ5kGvapy7QKAPeUuxB+tnW3uRsXMYh8Mc2gYyysDtC4efINtfnntuQ fGAkxYC0D5J6XcixumEjd1oldmZ5khHx6p9mBp3en9oRCBhsdkDgAT1UxCRKNekTqCCYK7/6DMDD JGudBxECv6VhyX6zR1kAjE31lmhkGhYJ3wgfm3lb5f99PId3UDJ8djHEa713wNM7EtiNEstLDomo v3e7I/SuMcyHHscwDyEurgXS3UKM4RkWAnbhIA== Received: by omta-ad3-fd3-301-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20230214 64bit (built Feb 14 2023)) with ESMTPS id <0RR800D50386PM60@omta-ad3-fd3-301-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com> for ocfs2-devel@archiver.kernel.org; Wed, 08 Mar 2023 22:16:54 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1678313798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tkhViH9kdWNjYXwKnPEs08Xl3095dV6IZ6LM3uHmPgg=; b=bPXrjsfNIA8aCilQN80V8tZJJRnYiUaUiYYE6WDP0poZXHmgRnngHO4Lb96J8qrY8s 0UFv5K7lMRJloKD0tWGMmVKDB1rB7L2PYgY245lC/cGDS2TdHabWAHsD74tYHk7XWX+9 ctSErcrpU4ra1h7MNt4j2JB1T46qH5KSu8XZMjjoIq7fVYdLws67bRDNtSSAyq5ddIEU URzRfvXhHoHE7mhDjTIo/KgBW+4k4yBsfFL5q4a+jwiG/cTxuGsLWCziz32JVyllZ+pC DZbdjHIIJFo9Zy6iaSLyCS5thVAOwak49iMLSnuOr6HQ+YCMlQc6/QjcnOmMkEQALnF5 7qLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678313798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tkhViH9kdWNjYXwKnPEs08Xl3095dV6IZ6LM3uHmPgg=; b=U5cul07iRRI16Jalv/TWWcbX6Uq5ehXr//rnopowsDVczi3DLHXXcseoSNcLuRZIlb uTlHHBYazh6huriRJH3+GOKIdu0kU4wGxH52kLNhy4IBcwqWAjSPlrpoWDff8XHlUygq MRC0C2WrfP6ci5U8tPCCtnYfLesQVCKnkbKvc3qY7/R/kKQCglt9eFJwWbMjyxHbSHwr sAD89WZjP6cTXQsz+vrdQb6MLUrd56g0kCfRAemLeL96nGjPJROoSVFqNHhGDGgJhiZ7 wrMe24p30DIMK1cZIwmmcpsKxkur5AqAsGCQuqoUgZFT7nHzdlI5ZtoI2iEUKtG1nXRs rkew== X-Gm-Message-State: AO0yUKXxB9t+6KvRw9jz3o2zKhqe1XEabR6YCkSz7nBtzJZvkG/tKUA9 KqQA8NLueKNkHHI78/ols9Ryh8Qb1rf2lZ/wb3Gh X-Received: by 2002:a17:903:2587:b0:19a:9f86:adab with SMTP id jb7-20020a170903258700b0019a9f86adabmr7646529plb.7.1678313797868; Wed, 08 Mar 2023 14:16:37 -0800 (PST) MIME-version: 1.0 References: <20221201104125.919483-1-roberto.sassu@huaweicloud.com> In-reply-to: <20221201104125.919483-1-roberto.sassu@huaweicloud.com> Date: Wed, 8 Mar 2023 17:16:26 -0500 Message-id: To: Roberto Sassu X-Source-IP: 209.85.216.51 X-Proofpoint-Virus-Version: vendor=nai engine=6500 definitions=10643 signatures=596816 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 impostorscore=0 mlxscore=0 suspectscore=0 bulkscore=0 priorityscore=60 malwarescore=0 mlxlogscore=464 adultscore=0 clxscore=163 phishscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303080188 Cc: nicolas.bouchinet@clip-os.org, linux-kernel@vger.kernel.org, keescook@chromium.org, selinux@vger.kernel.org, dmitry.kasatkin@gmail.com, Roberto Sassu , jmorris@namei.org, zohar@linux.ibm.com, reiserfs-devel@vger.kernel.org, linux-security-module@vger.kernel.org, casey@schaufler-ca.com, eparis@parisplace.org, linux-integrity@vger.kernel.org, stephen.smalley.work@gmail.com, ocfs2-devel@oss.oracle.com, serge@hallyn.com Subject: Re: [Ocfs2-devel] [PATCH v7 0/6] evm: Do HMAC of multiple per LSM xattrs for new inodes X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Paul Moore via Ocfs2-devel Reply-to: Paul Moore Content-type: text/plain; charset="utf-8" Content-transfer-encoding: base64 Errors-to: ocfs2-devel-bounces@oss.oracle.com X-Google-Smtp-Source: AK7set++0GvPRL/fArYHKN0SqlsLssuQ2AVagfsEuJmq+L5qFprSO0qSDic4f0ylWLwNIoHyQ3gpdgkwfLpUMJ7FI+Y= X-ServerName: mail-pj1-f51.google.com X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 include:_spf.google.com ~all X-Spam: Clean X-Proofpoint-GUID: 4B1OizrMxUBSvD_-gNPJTkZjHBInNQVy X-Proofpoint-ORIG-GUID: 4B1OizrMxUBSvD_-gNPJTkZjHBInNQVy Reporting-Meta: AAGgaocKzds9l9bXpY6Q1t3ZjNHxINYgCY1KXjeEThBX0bdIdnXW2Hx2tPt10Fxa wFeCeFToLMDZKCbv8hgRSMtsw2I3ExD1j0w1BCgyW9FrSU6oE5jsxAZBsR5md7yG mAYue898WiGpDrIXpdkHEbJZe8IItj1F01BrNGKwmDjJk2ZeE43Ou46Ew/Hx52Fx ncuYQSNkmhoa3mlmogn2QDrv3AOBJ9drFLyQiRO4IbIm1s/uFcwlzKasf9Cx70DI G72LBDqFT2iNSM/4htf6RBzNmUWHYwsx38qFnIHd6oWcMuFCTgTNsZuyyh9FYJpR SmkeJNvU8CJs0tDiwWooHa7ubvEZA0j4ZEc+KUYK21tOjKOuCxPwSVQfSZDM8A0a 3tBL07RJF61n8gGwZwupOBEKKNavD8qtNIK/vvPuVyieSnNU32WTPD7HfKx5kcWJ SqfwpqJcguhC4tziYwqSMV15QjIl6VSUz1Q23TCPxONPWky5xmx9qphFjYHmp+JK IzTCOXhMhnpS/mL23cKrA046HAmB4Hp4g/lHVFsodu0= T24gVGh1LCBEZWMgMSwgMjAyMiBhdCA1OjQy4oCvQU0gUm9iZXJ0byBTYXNzdQo8cm9iZXJ0by5z YXNzdUBodWF3ZWljbG91ZC5jb20+IHdyb3RlOgo+Cj4gRnJvbTogUm9iZXJ0byBTYXNzdSA8cm9i ZXJ0by5zYXNzdUBodWF3ZWkuY29tPgo+Cj4gT25lIG9mIHRoZSBtYWpvciBnb2FscyBvZiBMU00g c3RhY2tpbmcgaXMgdG8gcnVuIG11bHRpcGxlIExTTXMgc2lkZSBieSBzaWRlCj4gd2l0aG91dCBp bnRlcmZlcmluZyB3aXRoIGVhY2ggb3RoZXIuIFRoZSB1bHRpbWF0ZSBkZWNpc2lvbiB3aWxsIGRl cGVuZCBvbgo+IGluZGl2aWR1YWwgTFNNIGRlY2lzaW9uLgo+Cj4gU2V2ZXJhbCBjaGFuZ2VzIG5l ZWQgdG8gYmUgbWFkZSB0byB0aGUgTFNNIGluZnJhc3RydWN0dXJlIHRvIGJlIGFibGUgdG8KPiBz dXBwb3J0IHRoYXQuIFRoaXMgcGF0Y2ggc2V0IHRhY2tsZXMgb25lIG9mIHRoZW06IGdpdmVzIHRv IGVhY2ggTFNNIHRoZQo+IGFiaWxpdHkgdG8gc3BlY2lmeSBvbmUgb3IgbXVsdGlwbGUgeGF0dHJz IHRvIGJlIHNldCBhdCBpbm9kZSBjcmVhdGlvbgo+IHRpbWUgYW5kLCBhdCB0aGUgc2FtZSB0aW1l LCBnaXZlcyB0byBFVk0gdGhlIGFiaWxpdHkgdG8gYWNjZXNzIGFsbCB0aG9zZQo+IHhhdHRycyBh bmQgY2FsY3VsYXRlIHRoZSBITUFDIG9uIHRoZW0uCgpIaSBSb2JlcnRvLAoKVGhlIHY3IGRyYWZ0 IG9mIHRoaXMgcGF0Y2hzZXQgaGFkIHNvbWUgZ29vZCBkaXNjdXNzaW9uLCBhbmQgYmFzZWQgb24g YQpxdWljayByZWFkIG9mIHRoZSBjb21tZW50cyBpdCBsb29rcyBsaWtlIGV2ZXJ5b25lIHdhcyBl dmVudHVhbGx5CnNhdGlzZmllZCB0aGF0IHRoZSB2NyBkcmFmdCB3YXMgZ29vZCBhbmQgbm8gZnVy dGhlciBjaGFuZ2VzIHdlcmUKbmVjZXNzYXJ5LCBpcyB0aGF0IGNvcnJlY3Qgb3IgZG8geW91IGhh dmUgYW4gdXBkYXRlZCBkcmFmdCBvZiB0aGlzCnBhdGNoc2V0PwoKLS0gCnBhdWwtbW9vcmUuY29t CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpPY2ZzMi1k ZXZlbCBtYWlsaW5nIGxpc3QKT2NmczItZGV2ZWxAb3NzLm9yYWNsZS5jb20KaHR0cHM6Ly9vc3Mu b3JhY2xlLmNvbS9tYWlsbWFuL2xpc3RpbmZvL29jZnMyLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH v7 0/6] evm: Do HMAC of multiple per LSM xattrs for new inodes Date: Wed, 8 Mar 2023 17:16:26 -0500 Message-ID: References: <20221201104125.919483-1-roberto.sassu@huaweicloud.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1678313798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tkhViH9kdWNjYXwKnPEs08Xl3095dV6IZ6LM3uHmPgg=; b=bPXrjsfNIA8aCilQN80V8tZJJRnYiUaUiYYE6WDP0poZXHmgRnngHO4Lb96J8qrY8s 0UFv5K7lMRJloKD0tWGMmVKDB1rB7L2PYgY245lC/cGDS2TdHabWAHsD74tYHk7XWX+9 ctSErcrpU4ra1h7MNt4j2JB1T46qH5KSu8XZMjjoIq7fVYdLws67bRDNtSSAyq5ddIEU URzRfvXhHoHE7mhDjTIo/KgBW+4k4yBsfFL5q4a+jwiG/cTxuGsLWCziz32JVyllZ+pC DZbdjHIIJFo9Zy6iaSLyCS5thVAOwak49iMLSnuOr6HQ+YCMlQc6/QjcnOmMkEQALnF5 7qLg== In-Reply-To: <20221201104125.919483-1-roberto.sassu@huaweicloud.com> List-ID: Content-Type: text/plain; charset="windows-1252" To: Roberto Sassu Cc: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, casey@schaufler-ca.com, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, keescook@chromium.org, nicolas.bouchinet@clip-os.org, Roberto Sassu On Thu, Dec 1, 2022 at 5:42=E2=80=AFAM Roberto Sassu wrote: > > From: Roberto Sassu > > One of the major goals of LSM stacking is to run multiple LSMs side by si= de > without interfering with each other. The ultimate decision will depend on > individual LSM decision. > > Several changes need to be made to the LSM infrastructure to be able to > support that. This patch set tackles one of them: gives to each LSM the > ability to specify one or multiple xattrs to be set at inode creation > time and, at the same time, gives to EVM the ability to access all those > xattrs and calculate the HMAC on them. Hi Roberto, The v7 draft of this patchset had some good discussion, and based on a quick read of the comments it looks like everyone was eventually satisfied that the v7 draft was good and no further changes were necessary, is that correct or do you have an updated draft of this patchset? --=20 paul-moore.com