All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org,
	James Morris <james.l.morris@oracle.com>
Subject: Re: [PATCH v1 1/1] selinux: use absolute path to include directory
Date: Tue, 19 Jan 2016 11:32:34 -0500	[thread overview]
Message-ID: <CAHC9VhTba5kaFusm4sR9uuDr=qK9QMmQYUZYp9=hcwLkk+TynQ@mail.gmail.com> (raw)
In-Reply-To: <1453219908.2521.118.camel@linux.intel.com>

On Tue, Jan 19, 2016 at 11:11 AM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Tue, 2016-01-19 at 10:53 -0500, Paul Moore wrote:
>> On Fri, Dec 4, 2015 at 3:07 PM, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>> > Compiler warns us a lot that it can't find include folder because
>> > it's provided
>> > in relative form.
>> >
>> >   CC      security/selinux/netlabel.o
>> > cc1: warning: security/selinux/include: No such file or directory
>> > [-Wmissing-include-dirs]
>> > cc1: warning: security/selinux/include: No such file or directory
>> > [-Wmissing-include-dirs]
>> > cc1: warning: security/selinux/include: No such file or directory
>> > [-Wmissing-include-dirs]
>> > cc1: warning: security/selinux/include: No such file or directory
>> > [-Wmissing-include-dirs]
>> >
>> > Add $(srctree) prefix to the path.
>> >
>> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> > ---
>> >  security/selinux/Makefile | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/security/selinux/Makefile b/security/selinux/Makefile
>> > index ad5cd76..90d1adb 100644
>> > --- a/security/selinux/Makefile
>> > +++ b/security/selinux/Makefile
>> > @@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
>> >
>> >  selinux-$(CONFIG_NETLABEL) += netlabel.o
>> >
>> > -ccflags-y := -Isecurity/selinux -Isecurity/selinux/include
>> > +ccflags-y := -Isecurity/selinux
>> > -I$(srctree)/security/selinux/include
>>
>> Why not add the $(srctree) prefix to both paths?
>
> I don't care as long as it fixes the annoying messages. Though, I can
> re-do the patch if it looks better that way.

Please do.

-- 
paul moore
www.paul-moore.com

      reply	other threads:[~2016-01-19 16:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1449259655-84458-1-git-send-email-andriy.shevchenko@linux.intel.com>
2016-01-19 15:53 ` [PATCH v1 1/1] selinux: use absolute path to include directory Paul Moore
2016-01-19 16:11   ` Andy Shevchenko
2016-01-19 16:32     ` Paul Moore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHC9VhTba5kaFusm4sR9uuDr=qK9QMmQYUZYp9=hcwLkk+TynQ@mail.gmail.com' \
    --to=paul@paul-moore.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=james.l.morris@oracle.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.