From: Paul Moore <paul@paul-moore.com>
To: "Christian Göttsche" <cgzones@googlemail.com>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH] selinux: enable genfscon labeling for securityfs
Date: Wed, 15 Sep 2021 14:27:55 -0400 [thread overview]
Message-ID: <CAHC9VhTcyz5i7jRiz1iAg7U_Ru1cJi6APv0GyMw408d+2aJmqw@mail.gmail.com> (raw)
In-Reply-To: <20210915162326.392808-1-cgzones@googlemail.com>
On Wed, Sep 15, 2021 at 12:24 PM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> Add support for genfscon per-file labeling of securityfs files. This allows
> for separate labels and therby permissions for different files, e.g.
> /sys/kernel/security/integrity/ima/policy.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
> security/selinux/hooks.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Hi Christian,
It would be nice if you could add some additional notes on how this
was tested to the description above.
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 6517f221d52c..a18626424731 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -760,7 +760,8 @@ static int selinux_set_mnt_opts(struct super_block *sb,
> !strcmp(sb->s_type->name, "tracefs") ||
> !strcmp(sb->s_type->name, "binder") ||
> !strcmp(sb->s_type->name, "bpf") ||
> - !strcmp(sb->s_type->name, "pstore"))
> + !strcmp(sb->s_type->name, "pstore") ||
> + !strcmp(sb->s_type->name, "securityfs"))
> sbsec->flags |= SE_SBGENFS;
>
> if (!strcmp(sb->s_type->name, "sysfs") ||
> --
> 2.33.0
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2021-09-15 18:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 16:23 [PATCH] selinux: enable genfscon labeling for securityfs Christian Göttsche
2021-09-15 18:27 ` Paul Moore [this message]
2021-09-16 17:41 ` Christian Göttsche
2021-09-17 2:07 ` Paul Moore
2021-09-17 8:00 ` Christian Göttsche
2021-09-17 13:27 ` Stephen Smalley
2021-09-27 21:56 ` Paul Moore
2021-09-28 15:39 ` [PATCH v2] " Christian Göttsche
2021-09-28 22:50 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhTcyz5i7jRiz1iAg7U_Ru1cJi6APv0GyMw408d+2aJmqw@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.