From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755081AbdCWWJh (ORCPT ); Thu, 23 Mar 2017 18:09:37 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:35942 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbdCWWJe (ORCPT ); Thu, 23 Mar 2017 18:09:34 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <71120ef7-6463-6497-f915-fcaf9e54239d@users.sourceforge.net> References: <71120ef7-6463-6497-f915-fcaf9e54239d@users.sourceforge.net> From: Paul Moore Date: Thu, 23 Mar 2017 18:09:32 -0400 Message-ID: Subject: Re: [PATCH 17/46] selinux: Delete an unnecessary variable assignment in filename_trans_read() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 10:17 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 19:02:42 +0100 > > The local variable "ft" was set to a null pointer despite of an > immediate reassignment. > Thus remove this statement from the beginning of a loop. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 1 - > 1 file changed, 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 106a1da1d68a..2be5b18eb149 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -1927,7 +1927,6 @@ static int filename_trans_read(struct policydb *p, void *fp) > nel = le32_to_cpu(buf[0]); > > for (i = 0; i < nel; i++) { > - ft = NULL; > otype = NULL; > name = NULL; > ft = kzalloc(sizeof(*ft), GFP_KERNEL); > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Date: Thu, 23 Mar 2017 22:09:32 +0000 Subject: Re: [PATCH 17/46] selinux: Delete an unnecessary variable assignment in filename_trans_read() Message-Id: List-Id: References: <71120ef7-6463-6497-f915-fcaf9e54239d@users.sourceforge.net> In-Reply-To: <71120ef7-6463-6497-f915-fcaf9e54239d@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org On Sun, Jan 15, 2017 at 10:17 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 19:02:42 +0100 > > The local variable "ft" was set to a null pointer despite of an > immediate reassignment. > Thus remove this statement from the beginning of a loop. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 1 - > 1 file changed, 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 106a1da1d68a..2be5b18eb149 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -1927,7 +1927,6 @@ static int filename_trans_read(struct policydb *p, void *fp) > nel = le32_to_cpu(buf[0]); > > for (i = 0; i < nel; i++) { > - ft = NULL; > otype = NULL; > name = NULL; > ft = kzalloc(sizeof(*ft), GFP_KERNEL); > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Thu, 23 Mar 2017 18:09:32 -0400 Subject: [PATCH 17/46] selinux: Delete an unnecessary variable assignment in filename_trans_read() In-Reply-To: <71120ef7-6463-6497-f915-fcaf9e54239d@users.sourceforge.net> References: <71120ef7-6463-6497-f915-fcaf9e54239d@users.sourceforge.net> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Sun, Jan 15, 2017 at 10:17 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 19:02:42 +0100 > > The local variable "ft" was set to a null pointer despite of an > immediate reassignment. > Thus remove this statement from the beginning of a loop. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 1 - > 1 file changed, 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 106a1da1d68a..2be5b18eb149 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -1927,7 +1927,6 @@ static int filename_trans_read(struct policydb *p, void *fp) > nel = le32_to_cpu(buf[0]); > > for (i = 0; i < nel; i++) { > - ft = NULL; > otype = NULL; > name = NULL; > ft = kzalloc(sizeof(*ft), GFP_KERNEL); > -- > 2.11.0 > -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html