From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH v2] audit: add feature audit_lost reset Date: Fri, 16 Dec 2016 17:47:07 -0500 Message-ID: References: <75c9c4dcd0a57ba6afec676ec55155e70ccb6a28.1481370732.git.rgb@redhat.com> <1803050.hqkP3u55ii@x2> <14416625.8shW6piCVY@x2> <20161216033942.GI1707@madcap2.tricolour.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uBGMlAi3017500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 16 Dec 2016 17:47:10 -0500 Received: from mail-ua0-f195.google.com (mail-ua0-f195.google.com [209.85.217.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4FD39624C6 for ; Fri, 16 Dec 2016 22:47:09 +0000 (UTC) Received: by mail-ua0-f195.google.com with SMTP id y13so532164uay.1 for ; Fri, 16 Dec 2016 14:47:09 -0800 (PST) In-Reply-To: <20161216033942.GI1707@madcap2.tricolour.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Steve Grubb , Richard Guy Briggs Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Thu, Dec 15, 2016 at 10:39 PM, Richard Guy Briggs wrote: > On 2016-12-15 22:12, Steve Grubb wrote: >> On Thursday, December 15, 2016 7:50:48 PM EST Paul Moore wrote: >> > On Thu, Dec 15, 2016 at 7:22 PM, Steve Grubb wrote: >> > > I'm planning to replace all the config change logging with the >> > > audit_log_task_simple function I sent so that we have everything. Can we >> > > go ahead and pull that in so that we can start using it? >> > >> > There needs to be more than one user of the function to make it >> > worthwhile; so far that function has only been proposed with a single >> > user. Propose it with multiple users and we can look at it seriously. >> >> That's because I have several unrelated patches that use it. Do you want me to >> send all of them at once? There's going to be at least 5 users of the >> function. Possibly more. I want it to be the default for all future events >> added because it concisely gives the necessary information for well-formed >> events. > > I'd send the audit_log_task_simple() patch alone, then send each feature > that uses it in a separate patch set. Failing that, send it as a > separate patch in the first patch set to make it available for all, then > follow it with more separate patchsets for other events. > > There is a chicken and egg problem here. The extremely safe way to do this would be to submit the unrelated patches first, each written to *not* make use of your new consolidation function, then submit a single patch which adds the function and integrates it with the others. This approach also has the advantage that you are able to submit fixes as you run across then and not have to wait for everything. I know you already have at least one patch ready to, you just need to remove the references to audit_log_task_simple. -- paul moore www.paul-moore.com