From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA000C4332B for ; Wed, 18 Mar 2020 21:08:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A13720409 for ; Wed, 18 Mar 2020 21:08:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="KblwfDmt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728004AbgCRVIq (ORCPT ); Wed, 18 Mar 2020 17:08:46 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:34002 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbgCRVIo (ORCPT ); Wed, 18 Mar 2020 17:08:44 -0400 Received: by mail-ed1-f65.google.com with SMTP id i24so28837338eds.1 for ; Wed, 18 Mar 2020 14:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WatAKLuqZtZlRLQCbRzYpTXRz9maWKDE4hUEG0f7NDw=; b=KblwfDmtszqt/poiiBnkGj80+eqtrRyKNLWAFKJyI2lM8X5PpTIHIUIc65zJhoEnEF WjcKc+bfilJdpRhIjI1m71RTPdnfUYwaMNgrlZfogSYuI3TKBJzAzVhAyAtHoPrdVKGp DLDa+hQ2FiF/ZRAW6YOkmNlRuau5tixJsAn5jRDu0LNFpGvf4mGlYW9x2j+4ybOULNy7 eW1S/z/G2JKD/YF0c0IywP5jL7tjCmAMSfYHwjw2Mgd+8lo0HY2apy//ZlP3q1BuFweg kxv1DBMAmhdBV9qGqhU7t4qHJxKuYe+4PrnuMPBj6LktzBpmvLYwxL6iqDAV7QAmJ5iL I9pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WatAKLuqZtZlRLQCbRzYpTXRz9maWKDE4hUEG0f7NDw=; b=X67DQeySnDVxmjjncuXMapKprOOfVh21JXDqRcbM3zEu3mJ3i/tXc0o1WzYDw1tqZK 4Xz+nftrOqDDMy6RhlD3d0MGLWqcYpGfTKBdivUVghAtBiXvaKYb0NGQDJmq7IWttEeG 4rwXsM15WvZ4cSdfF4bvZnJu4g8X2L4RfJJbGTzXp12wWu6VSUp2joBqF0q12k8XvxmF IOBZv9rMjRO5lx+uuGk/8KPeDG+SzOiJHtCzdI+jMvzlEbDL4s+dbLEYd36CaTg1S5TH yfaVc+AJXhUf1NQZo9CubRWKr6oNwR3OTnZ+01CeTHMJCDORFs2zPBSTL4RnFifTUqbG PIgw== X-Gm-Message-State: ANhLgQ1SzhBw5UEM9emXsyn/CGBlq9iUAvxEfgLRTUOVdldnmtZspRUA yNPc8Av2e29mhsJnsbmMZYFHICoI4N2U1xcue/fl X-Google-Smtp-Source: ADFU+vvbYGHqEIZHFDpAJYIn0BKyhX1aU7rGbDTvr2tbcPYmEgbd2Lwck7tUApGNIqLuzMQYQdyQBqa6eqOf1oPvVLM= X-Received: by 2002:aa7:d051:: with SMTP id n17mr5727973edo.196.1584565722903; Wed, 18 Mar 2020 14:08:42 -0700 (PDT) MIME-Version: 1.0 References: <6452955c1e038227a5cd169f689f3fd3db27513f.1577736799.git.rgb@redhat.com> <20200130192753.n7jjrshbhrczjzoe@madcap2.tricolour.ca> <20200205235056.e5365xtgz7rbese2@madcap2.tricolour.ca> <20200312205147.plxs4czjeuu4davj@madcap2.tricolour.ca> <20200314224203.ncyx3rgwwe6zet4e@madcap2.tricolour.ca> In-Reply-To: <20200314224203.ncyx3rgwwe6zet4e@madcap2.tricolour.ca> From: Paul Moore Date: Wed, 18 Mar 2020 17:08:31 -0400 Message-ID: Subject: Re: [PATCH ghak90 V8 13/16] audit: track container nesting To: Richard Guy Briggs Cc: nhorman@tuxdriver.com, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, LKML , dhowells@redhat.com, Linux-Audit Mailing List , netfilter-devel@vger.kernel.org, ebiederm@xmission.com, simo@redhat.com, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, Eric Paris , mpatel@redhat.com, Serge Hallyn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 14, 2020 at 6:42 PM Richard Guy Briggs wrote: > On 2020-03-13 12:47, Paul Moore wrote: ... > > It has been a while since I last looked at the patchset, but my > > concern over the prefered use of the ACID number vs the ACID object is > > that the number offers no reuse protection where the object does. I > > really would like us to use the object everywhere it is possible. > > Ok, so I take it from this that I go ahead with the dual format since > the wrapper funciton to convert from object to ID strips away object > information negating any benefit of favouring the object pointer. I'll > look at the remaining calls that use a contid (rather than contobj) and > convert all that I can over to storing an object using the dual counters > that track process exits versus signal2 and trace references. Well, as I said in the other thread, I'm not sure we need a full two counters; I think one counter and a simple flag should suffice. Otherwise that sounds good for the next iteration. -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 964DEC4332B for ; Wed, 18 Mar 2020 21:10:39 +0000 (UTC) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B91020777 for ; Wed, 18 Mar 2020 21:10:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OuTglCjr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B91020777 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584565838; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TlS8KUUh/nY2/sJoNgU1X7GCi/5GGGeiB2I12J3tGVA=; b=OuTglCjrzgI90dAWvm48BHOZQoUUzDIlVJPptrlOvZOzCl3e6ic+utLms88KcoEPf4HUSz t77kpYemroMoeUc1BG26gh6RiOylFdx9VVt5DiYtFU2A6ygOYCEbQVvBLszVcKEbr1D1M2 NJwCa69+aE6FEhEGM8BMgEfdAuaWJSI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-rDUL5roPOMWaYnMEloBgxA-1; Wed, 18 Mar 2020 17:10:36 -0400 X-MC-Unique: rDUL5roPOMWaYnMEloBgxA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 68C8B108838D; Wed, 18 Mar 2020 21:10:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F74D5C1D8; Wed, 18 Mar 2020 21:10:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8944F18089CD; Wed, 18 Mar 2020 21:10:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02IL8mLR006346 for ; Wed, 18 Mar 2020 17:08:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id D821E2063FE6; Wed, 18 Mar 2020 21:08:48 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D33E52063FE5 for ; Wed, 18 Mar 2020 21:08:46 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C21F80028B for ; Wed, 18 Mar 2020 21:08:46 +0000 (UTC) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-fo6YMeO2PpKdKWNVB6j-bw-1; Wed, 18 Mar 2020 17:08:44 -0400 X-MC-Unique: fo6YMeO2PpKdKWNVB6j-bw-1 Received: by mail-ed1-f68.google.com with SMTP id z65so32719265ede.0 for ; Wed, 18 Mar 2020 14:08:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WatAKLuqZtZlRLQCbRzYpTXRz9maWKDE4hUEG0f7NDw=; b=hQ1xjafSug+U1Mc7JCQCiY8vEg56CEjAU6RErLjVkGOz8uSsyd5kQZ77HPJL/Ie6eg 9LBG5HGeppvYAoH3hD4DchcI1CGNvVFizqdTzkc3JO4h7MqX7Ml+NuWBCBLZDTGqhXdO tgj6sTEMiKtuuQkfI9hrzGD4XYODhUBz0F0oMF4QGXjT1POCd3dJXPchqW32HkLVGQ4Q DwBOGDvLY4joRHCyksWlejHuz8Ph/Dj4MkQmI9RvY5mmY8C19ZeK/1oeRTufPdcBS28f fEph2KKPMkY8tOA4/dV5mveaXZPNgkyO8enw/OeAzIHTMOmh1zftn0rM0fo2Nb/fVeR8 0XZA== X-Gm-Message-State: ANhLgQ2XMYMxYua8dkuz1Ollfzwpg44mFxQU5V5FoZZY90QlZxm03QAp 2mofYvZQKKgtT1h1tVybv0WW1P0jMjEDc/jSQBab X-Google-Smtp-Source: ADFU+vvbYGHqEIZHFDpAJYIn0BKyhX1aU7rGbDTvr2tbcPYmEgbd2Lwck7tUApGNIqLuzMQYQdyQBqa6eqOf1oPvVLM= X-Received: by 2002:aa7:d051:: with SMTP id n17mr5727973edo.196.1584565722903; Wed, 18 Mar 2020 14:08:42 -0700 (PDT) MIME-Version: 1.0 References: <6452955c1e038227a5cd169f689f3fd3db27513f.1577736799.git.rgb@redhat.com> <20200130192753.n7jjrshbhrczjzoe@madcap2.tricolour.ca> <20200205235056.e5365xtgz7rbese2@madcap2.tricolour.ca> <20200312205147.plxs4czjeuu4davj@madcap2.tricolour.ca> <20200314224203.ncyx3rgwwe6zet4e@madcap2.tricolour.ca> In-Reply-To: <20200314224203.ncyx3rgwwe6zet4e@madcap2.tricolour.ca> From: Paul Moore Date: Wed, 18 Mar 2020 17:08:31 -0400 Message-ID: Subject: Re: [PATCH ghak90 V8 13/16] audit: track container nesting To: Richard Guy Briggs X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02IL8mLR006346 X-loop: linux-audit@redhat.com Cc: nhorman@tuxdriver.com, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, LKML , dhowells@redhat.com, Linux-Audit Mailing List , netfilter-devel@vger.kernel.org, ebiederm@xmission.com, simo@redhat.com, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, Eric Paris , mpatel@redhat.com, Serge Hallyn X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Mar 14, 2020 at 6:42 PM Richard Guy Briggs wrote: > On 2020-03-13 12:47, Paul Moore wrote: ... > > It has been a while since I last looked at the patchset, but my > > concern over the prefered use of the ACID number vs the ACID object is > > that the number offers no reuse protection where the object does. I > > really would like us to use the object everywhere it is possible. > > Ok, so I take it from this that I go ahead with the dual format since > the wrapper funciton to convert from object to ID strips away object > information negating any benefit of favouring the object pointer. I'll > look at the remaining calls that use a contid (rather than contobj) and > convert all that I can over to storing an object using the dual counters > that track process exits versus signal2 and trace references. Well, as I said in the other thread, I'm not sure we need a full two counters; I think one counter and a simple flag should suffice. Otherwise that sounds good for the next iteration. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit