From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264A3C48BE6 for ; Wed, 16 Jun 2021 11:52:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E15461245 for ; Wed, 16 Jun 2021 11:52:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E15461245 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 08F81803B5; Wed, 16 Jun 2021 13:52:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dYAuZ3nf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 92A818009C; Wed, 16 Jun 2021 13:52:45 +0200 (CEST) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EB2248009C for ; Wed, 16 Jun 2021 13:52:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-ej1-x62c.google.com with SMTP id og14so3446532ejc.5 for ; Wed, 16 Jun 2021 04:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CZWqS80EkgXz0cRnYN/4kaAc7gk0cl0GKXdRDXU9Kv4=; b=dYAuZ3nfviMifQ9G+QZ81Gg3RVwPeint9SiJXX8PJqLxY9iIxkWh/Qk6X9WrAafjqt MHm1UMqhG7q1pr1/i2qvsKJHmv5BcKZ8M/w+mHf771zbguWhXWxJ+XSc7Owq5hGhVRvs qJmqUKVa+ua7zt6b9z+LrfXzXQWKYgVUuenpK50Zmvg2ZBF86pruYa9wzCTVx4IHefBh GqFGQQZJj7HwuRdk0WQPsIjLYEmAGVZ6hXKZgy5TcsRTuZWzmbh1Z0RH141Ail7jPMm/ kgixC/ewG1eVp70zPLW1lS1gNZAT2okeeFVG+edsJIY7naqsv/6g2z73b8+e1jt/oofQ Xr4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CZWqS80EkgXz0cRnYN/4kaAc7gk0cl0GKXdRDXU9Kv4=; b=YyA+QOXRkPDY9kRf5t6uIaY7OoKuvoyX4CFm2HKE44ety/rvGN6A6t/rbR1mxhgg0L 5j4xxrKWnlDo367CxbQAtdBRTi5Ih8u4qwho0xTNKziclrIrguDUMyjM8WxOAOYe3/c7 xzX1F7xbaLK5ZVfQ0lvRYGur5FVD6HnrYSuYalSpw9imQfSeB//tkq4G+xYktkU99nzM 5JwnDzQ35/nWZxy5WAB8vKPezXAtk8i7Mm8Meh9O+Fz9VMymKZ1bthMyXRnHLbwkcwm/ a/Dno6832VtyH95js1TvCJ482vuimTOG/FhJ2DEawJUoH5VwVvzv25bPd7B8a0fLSPDS KAoA== X-Gm-Message-State: AOAM533XE05sX8SYavEWW3lXud/pT0dbqHDXFASSLAFllC2ykmHF7Lpm WZNaqIqxUh4ln1IpvjJyhLrQwujUKA95oTqBcMg= X-Google-Smtp-Source: ABdhPJx4CIjoX1x8aUJ7GPfjBRPsi0XO6GzHw8iQMfsjGrYmPPZ+gVZtzsesBNeBHEc7o5N+Z5bt0UGP27M7PTLfEE0= X-Received: by 2002:a17:907:2136:: with SMTP id qo22mr4878731ejb.40.1623844361446; Wed, 16 Jun 2021 04:52:41 -0700 (PDT) MIME-Version: 1.0 References: <20210519012640.5970-1-trini@konsulko.com> <20210519132748.mgzyukuvfmlx3uch@pali> <20210519155203.GZ17669@bill-the-cat> <20210521144418.GI17669@bill-the-cat> <20210521213645.2y5dawkvr6wfaymy@pali> <20210615123436.GH9516@bill-the-cat> <5848e9c9-4dab-00cc-07dc-ffa57b9417cd@gmail.com> In-Reply-To: <5848e9c9-4dab-00cc-07dc-ffa57b9417cd@gmail.com> From: Adam Ford Date: Wed, 16 Jun 2021 06:52:30 -0500 Message-ID: Subject: Re: [maemo-leste] [PATCH] arm: Remove nokia_rx51 board To: Ivaylo Dimitrov Cc: Tom Rini , =?UTF-8?Q?Pali_Roh=C3=A1r?= , maemo-leste@lists.dyne.org, U-Boot Mailing List , Merlijn Wajer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Jun 16, 2021 at 6:26 AM Ivaylo Dimitrov wrote: > > Hi, > > On 15.06.21 =D0=B3. 15:34 =D1=87., Tom Rini wrote: > > On Tue, Jun 15, 2021 at 08:40:30AM +0300, Ivaylo Dimitrov wrote: > >> Hi, > >> > >> On 22.05.21 =D0=B3. 0:36 =D1=87., Pali Roh=C3=A1r wrote: > >>> On Friday 21 May 2021 10:44:18 Tom Rini wrote: > >>>> On Wed, May 19, 2021 at 11:52:03AM -0400, Tom Rini wrote: > >>>>> On Wed, May 19, 2021 at 03:27:48PM +0200, Pali Roh=C3=A1r wrote: > >>>>> > >>>>>> On Tuesday 18 May 2021 21:26:40 Tom Rini wrote: > >>>>>>> This board has not been converted to CONFIG_DM_USB by the deadlin= e. > >>>>>>> Remove it. > >>>>>> > >>>>>> I'm very disappointed that you want to remove Nokia N900 from U-Bo= ot. > >>>>>> > >>>>>> I was waiting waiting half of year because other developers did no= t > >>>>>> react to issues which were introduced and neither to patches which= I > >>>>>> sent (+ trying to remind open issues). And also I was waiting anot= her > >>>>>> half of year until other N900 related patches were merged. So the = whole > >>>>>> slowdown was not caused by me, why it is taking so long. > >>>>>> > >>>>>> Now there is still one N900 DM related patch waiting for review. I= 'm > >>>>>> converting code step by step. > >>>>>> > >>>>>> So the ball is not on my side. > >>>>> > >>>>> So, what patch(es) need to be applied to get DM_USB enabled? Thank= s. > >>>> > >>>> I don't see any open patches from you that look related to enabling > >>>> DM_USB on the platform. If you want to disable USB on the platform = for > >>>> now instead, that's fine too. > >>> > >> > >> I tried to migrate the latest master to DM_USB, but unfortunately the > >> results are pretty much sad - adding OF_CONTROL (which is a prerequisi= te to > >> have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k = to the > >> size of the u-boot binary, so it becomes 370284 bytes. Given that we h= ave > >> less than 256k of storage space for the u-boot, the produced binary ca= nnot > >> be used on n900 the same way current (no DM_USB) binary is used. Have you experimented with enabling LTO? I was successful in enabling LTO on an OMAP3530 and a DM3730 which really helped reduce the code size and I didn't notice any obvious regressions. adam > >> > >> As I see it, there are not much options left - u-boot on N900 is not S= PL, so > >> we can't use OF_PLATDATA, which in turn always links libfdt. > >> Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB req= uires > >> the board to be converted to DT and this is way bigger change. > >> > >> Please advice on how to proceed. > > > > Please post your WIP patches, thanks. > > > > Sorry, I am not sure I understand what patches you want me to post: > > WDT patch has already been sent couple of months ago - > https://lists.denx.de/pipermail/u-boot/2021-March/443868.html > Do you want it to be rebased and resend? > > DM_USB, I just started writing one and I immediately hit the OF_CONTROL > requirement. Enabling OF_CONTROL requires a full blown migration to DT, > which is a huge task and not really equal to "Please update the board to > use CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures: > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > DWARF error: could not find abbrev number 3998 > /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind': > :(.text+0x5672): undefined reference to > `ofnode_read_u32_default' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > :(.text+0x568c): undefined reference to > `ofnode_read_u32_default' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device': > :(.text+0x6c84): undefined reference to `ofnode_first_subnode= ' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > :(.text+0x6c96): undefined reference to `ofnode_read_u32' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > :(.text+0x6ca4): undefined reference to `ofnode_next_subnode' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8): > undefined reference to `dm_scan_fdt_dev' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x= 8): > undefined reference to `dm_scan_fdt_dev' > > Fixing those requires enabling of OF_CONTROL and this in turn means the > board must be migrated to DT, unless I am missing something. That's why > my "please advice..." stance. > > Thanks, > Ivo