From: Adam Ford <aford173@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Douglas Anderson <dianders@chromium.org>,
Yegor Yefremov <yegorslists@googlemail.com>,
linux-serial@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Serial 8250 DMA Broken on OMAP3630
Date: Thu, 10 Oct 2019 09:11:29 -0500 [thread overview]
Message-ID: <CAHCN7x+B5nw=muPPTXAv+Pwx69bJSmi2jZhC68fA=rtN7=ELoA@mail.gmail.com> (raw)
In-Reply-To: <20191009201612.GQ5610@atomide.com>
On Wed, Oct 9, 2019 at 3:16 PM Tony Lindgren <tony@atomide.com> wrote:
>
> * Adam Ford <aford173@gmail.com> [191009 19:28]:
> > On Wed, Oct 9, 2019 at 12:34 PM Tony Lindgren <tony@atomide.com> wrote:
> > > From what I recall I tested that DMA on omap3 worked fine with runtime
> > > PM for console. Certainly there are issues still remaining though.
> > >
> > > If you want to disable dma for a specific port, just delete the
> > > add /delete-property/dma-names for the port in question in your
> > > board specific dts file.
> > >
> > > See 8250_omap.c for of_property_count_strings(np, "dma-names").
> >
> > Thank you. That seems to have worked. I'll check the AM3517 when I
> > have some time to see if it needs the same patch. For now, I pushed
> > the patch to the omap mailing list for the Logic PD Torpedo board.
> >
> > Should we consider removing the OMAP_SERIAL from omap2plus_defconfig
> > in the 8250 is the preferred driver? It seems odd to me that both
> > drivers are enabled.
>
> We have CONFIG_SERIAL_8250_OMAP=y and by default also we have
> CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP=y. With those omap_serial
> won't probe.. So yeah I guess for v5.5 we could drop the
> option for CONFIG_SERIAL_OMAP for both omap2plus_defconfig and
> multi_v7_defconfig.
Do you want me to push a patch for that, or is that something you want to do?
adam
>
> Regards,
>
> Tony
prev parent reply other threads:[~2019-10-10 14:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 17:04 Serial 8250 DMA Broken on OMAP3630 Adam Ford
2019-10-07 8:17 ` Andy Shevchenko
2019-10-09 13:43 ` Vignesh Raghavendra
2019-10-09 13:43 ` Vignesh Raghavendra
2019-10-09 14:08 ` Adam Ford
2019-10-09 17:34 ` Tony Lindgren
2019-10-09 17:34 ` Tony Lindgren
2019-10-09 19:27 ` Adam Ford
2019-10-09 20:16 ` Tony Lindgren
2019-10-10 14:11 ` Adam Ford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHCN7x+B5nw=muPPTXAv+Pwx69bJSmi2jZhC68fA=rtN7=ELoA@mail.gmail.com' \
--to=aford173@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.