From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Ford Subject: Re: Passing NAND mtdparts to OMAP2+ Kernel Date: Wed, 29 Mar 2017 14:59:19 -0500 Message-ID: References: <20170328215705.438d7af8@bbrezillon> <04afe149-24b2-daec-5ef0-2d662ed79040@ti.com> <20170329151002.26203f2c@bbrezillon> <20170329151837.509c15c6@bbrezillon> <89e42bf8-4a69-1e99-59e8-94dc44889849@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <89e42bf8-4a69-1e99-59e8-94dc44889849@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Roger Quadros Cc: "Leto, Enrico" , Boris Brezillon , linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org List-Id: linux-omap@vger.kernel.org T24gV2VkLCBNYXIgMjksIDIwMTcgYXQgOTowNiBBTSwgUm9nZXIgUXVhZHJvcyA8cm9nZXJxQHRp LmNvbT4gd3JvdGU6Cj4gT24gMjkvMDMvMTcgMTY6MTgsIEJvcmlzIEJyZXppbGxvbiB3cm90ZToK Pj4gT24gV2VkLCAyOSBNYXIgMjAxNyAxNToxMDowMiArMDIwMAo+PiBCb3JpcyBCcmV6aWxsb24g PGJvcmlzLmJyZXppbGxvbkBmcmVlLWVsZWN0cm9ucy5jb20+IHdyb3RlOgo+Pgo+Pj4gT24gV2Vk LCAyOSBNYXIgMjAxNyAxNTo0MTowNyArMDMwMAo+Pj4gUm9nZXIgUXVhZHJvcyA8cm9nZXJxQHRp LmNvbT4gd3JvdGU6Cj4+Pgo+Pj4+IEFkYW0sCj4+Pj4KPj4+PiBPbiAyOS8wMy8xNyAxNDozOSwg QWRhbSBGb3JkIHdyb3RlOgo+Pj4+PiBPbiBUdWUsIE1hciAyOCwgMjAxNyBhdCAyOjU3IFBNLCBC b3JpcyBCcmV6aWxsb24KPj4+Pj4gPGJvcmlzLmJyZXppbGxvbkBmcmVlLWVsZWN0cm9ucy5jb20+ IHdyb3RlOgo+Pj4+Pj4gK1JvZ2VyIGFuZCBFbnJpY28KPj4+Pj4+Cj4+Pj4+PiBPbiBUdWUsIDI4 IE1hciAyMDE3IDEwOjQzOjAxIC0wNTAwCj4+Pj4+PiBBZGFtIEZvcmQgPGFmb3JkMTczQGdtYWls LmNvbT4gd3JvdGU6Cj4+Pj4+Pgo+Pj4+Pj4+IEkgcG9zdGVkIHRoaXMgb24gdGhlIGxpbnV4LW9t YXAgbGlzdCwgYW5kIEkgd2FzIGFza2VkIHRvIHBvc3QgdGhpcyBvbgo+Pj4+Pj4+IHRoZSBsaW51 eC1tdGQgbGlzdDoKPj4+Pj4+Pgo+Pj4+Pj4+Cj4+Pj4+Pj4gSSB0cmllZCB0byByZW1vdmUgdGhl IE1URCBwYXJ0aXRpb25zIGZyb20gdGhlIExpbnV4IGRldmljZSB0cmVlLCBhbmQgSQo+Pj4+Pj4+ IG5vdGljZWQgdGhhdCB0aGVyZSB3YXMgbm8gcGFydGl0aW9uIGluZm9ybWF0aW9uIGJlaW5nIHB1 c2hlZCBhbnltb3JlCj4+Pj4+Pj4gdW5sZXNzIEkgY2hhbmdlZCB0aGUgbXRkcGFydHMgbmFtZSBp biBVLUJvb3QuCj4+Pj4+Pj4KPj4+Pj4+PiBJdCBhcHBlYXJzIGFzIGlmIHRoZSBNVEQgZHJpdmVy cyBoYXZlIGNoYW5nZWQgYSBiaXQuICBJIGZvdW5kIGEgZmV3Cj4+Pj4+Pj4gZS1tYWlscyBmbG9h dGluZyBhcm91bmQgdGhhdCBhdHRlbXB0IHRvIGZpeCB0aGlzCj4+Pj4+Pj4KPj4+Pj4+PiBDb21t aXQgZjdhOGUzOGYwN2ExN2JlOTA3NTg1ICgibXRkOiBuYW5kOiBhc3NpZ24gcmVhc29uYWJsZSBk ZWZhdWx0Cj4+Pj4+Pj4gbmFtZSBmb3IgTkFORCBkcml2ZXJzIikgYXR0ZW1wdHMgdG8gYWRkcmVz cyB0aGlzLCBhbmQgc29tZW9uZSBvdmVyIGF0Cj4+Pj4+Pj4gaHR0cHM6Ly9wYXRjaHdvcmsub3ps YWJzLm9yZy9wYXRjaC83MDcwNjUvIGF0dGVtcHRlZCB0byBhZGRyZXNzIGl0IGFzCj4+Pj4+Pj4g d2VsbCBpbiBhIHNsaWdodGx5IGRpZmZlcmVudCB3YXkuCj4+Pj4+Pgo+Pj4+Pj4gQ2FuIHlvdSB0 ZXN0IHRoZSBwYXRjaCBhbmQgbGV0IG1lIGtub3cgaWYgc29sdmVzIHRoZSBwcm9ibGVtLiBJZiBp dAo+Pj4+Pj4gZG9lcywgSSdsbCBzZW5kIGEgY2xlYW4gdmVyc2lvbiBvZiB0aGUgcGF0Y2ggYW5k IHF1ZXVlIGl0IGZvciA0LjEyLgo+Pj4+Pj4KPj4+Pj4KPj4+Pj4gSSB0cmllZCB0byBhcHBseSB0 aGUgcGF0Y2ggZGlyZWN0bHksIGJ1dCBpdCBmYWlsZWQuICBJIHRoZW4gbWFudWFsbHkKPj4+Pj4g Y29weS1wYXN0ZWQgaXQgaW50byB0aGUgcHJvcGVyIHBsYWNlLCBidXQgaXQgZmFpbHMgdG8gY29t cGlsZS4KPj4+Pj4KPj4+Pj4gZHJpdmVycy9tdGQvbmFuZC9vbWFwMi5jOiBJbiBmdW5jdGlvbiDi gJhvbWFwX25hbmRfcHJvYmXigJk6Cj4+Pj4+IGRyaXZlcnMvbXRkL25hbmQvb21hcDIuYzoxODU5 OjE0OiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YKPj4+Pj4gZnVuY3Rpb24g4oCYZGV2 bV9rYXNwcmluZuKAmSBbLVdlcnJvcj1pbXBsaWNpdC1mdW5jdGlvbi1kZWNsYXJhdGlvbl0KPj4+ Pj4gICBtdGQtPm5hbWUgPSBkZXZtX2thc3ByaW5mKCZwZGV2LT5kZXYsICJvbWFwMi1uYW5kLiVk IiwgaW5mby0+Z3BtY19jcyk7Cj4+Pj4+ICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fgo+Pj4+ PiBkcml2ZXJzL210ZC9uYW5kL29tYXAyLmM6MTg1OToxMjogd2FybmluZzogYXNzaWdubWVudCBt YWtlcyBwb2ludGVyCj4+Pj4+IGZyb20gaW50ZWdlciB3aXRob3V0IGEgY2FzdCBbLVdpbnQtY29u dmVyc2lvbl0KPj4+Pj4gICBtdGQtPm5hbWUgPSBkZXZtX2thc3ByaW5mKCZwZGV2LT5kZXYsICJv bWFwMi1uYW5kLiVkIiwgaW5mby0+Z3BtY19jcyk7Cj4+Pj4+ICAgICAgICAgICAgIF4KPj4+Pj4g Y2MxOiBzb21lIHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJyb3JzCj4+Pj4+Cj4+Pj4+IEkg dXNlIGJ1aWxkcm9vdCB0byBidWlsZCBteSB0b29sY2hhaW4gYW5kIEkgYW0gdXNpbmcgZ2NjIHZl cnNpb24gNi4zLjAKPj4+Pj4gd2l0aCBnbGliYyAyLjI0LiAgSXMgdGhlcmUgc3VwcG9zZWQgdG8g YmUgYW4gaW5jbHVkZSBzb21ld2hlcmU/ICBJIGFtCj4+Pj4+IG5vdCBmYW1pbGlhciB3aXRoIGRl dm1fa2FzcHJpbmYuCj4+Pgo+Pj4gSXQncyBhIHR5cG86IHMvZGV2bV9rYXNwcmluZi9kZXZtX2th c3ByaW50Zi8uCj4+Pgo+Pj4+Pgo+Pj4+Pgo+Pj4+Cj4+Pj4gRG9lcyB0aGUgYmVsb3cgcGF0Y2gg d29yayBmb3IgeW91Pwo+Pj4KPj4+IFNob3VsZCB3b3JrIGluZGVlZC4KPj4+Cj4+PiBJIGhhZCBh IGNsb3NlciBsb29rIGFuZCBpdCBzZWVtcyB0aGF0IHRoZSBidWcgd2FzIGFjdHVhbGx5IGludHJv ZHVjZWQKPj4+IGJ5IGM5NzExZWM1MjUwYiBtdGQ6IG5hbmQ6IG9tYXA6IENsZWFuIHVwIGRldmlj ZSB0cmVlCj4+PiBzdXBwb3J0Lgo+Pj4gVGhlIHBhcmVudCBkZXZpY2UgbmFtZSBoYXMgY2hhbmdl ZCB3aGVuIHN3aXRjaGluZyB0byB0aGUgbmV3IERUCj4+PiByZXByZXNlbnRhdGlvbjogb21hcDIt bmFuZC4wICh3aGVyZSAwIGlzIHRoZSBjb250cm9sbGVyIGluc3RhbmNlKSBiZWNhbWUKPj4+IDMw MDAwMDAwLm5hbmQgKHdoZXJlIDMwMDAwMDAwIGlzIHRoZSBiYXNlIHJlZyBhZGRyZXNzIGluIHRo ZSBwaHlzaWNhbAo+Pj4gYWRkcmVzcyBzcGFjZSkuIFdoaWNoIG1lYW5zIG15IHByb3Bvc2FsIHdh cyBpbmNvcnJlY3QgKDAgaXMgbm90IHRoZSBDUwo+Pj4gbGluZSwgaXQncyB0aGUgTkFORCBjb250 cm9sbGVyIGluc3RhbmNlIG51bWJlciksIHNvIHdlJ2QgYmV0dGVyCj4+PiBzdGF0aWNhbGx5IHNl dCBpdCB0byAib21hcDItbmFuZC4wIi4KPj4KPj4gQ2hhbmdpbmcgbXkgbWluZCAoYWdhaW4gOikp LiBBY2NvcmRpbmcgdG8gWzFdLCB0aGUgaW5zdGFuY2UgaWQgaXMKPj4gcmVsYXRlZCB0byB0aGUg Q1MgbGluZSwgc28gZGV2bV9rYXNwcmludGYoKSBpcyB0aGUgcmlnaHQgc29sdXRpb24uCj4+Cj4+ IFNvcnJ5IGZvciB0aGUgbm9pc2UuCj4+Cj4+Pgo+Pj4+Cj4+Pj4gY2hlZXJzLAo+Pj4+IC1yb2dl cgo+Pj4+Cj4+Pj4gLS0tCj4+Pj4gIGRyaXZlcnMvbXRkL25hbmQvb21hcDIuYyB8IDcgKysrKysr Kwo+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspCj4+Pj4KPj4+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9tdGQvbmFuZC9vbWFwMi5jIGIvZHJpdmVycy9tdGQvbmFuZC9vbWFwMi5j Cj4+Pj4gaW5kZXggMmE1MjEwMS4uZjY5M2I4ZCAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJzL210 ZC9uYW5kL29tYXAyLmMKPj4+PiArKysgYi9kcml2ZXJzL210ZC9uYW5kL29tYXAyLmMKPj4+PiBA QCAtMTg1Niw2ICsxODU2LDEzIEBAIHN0YXRpYyBpbnQgb21hcF9uYW5kX3Byb2JlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+Pj4gICAgIG5hbmRfY2hpcC0+ZWNjLnByaXYgICAgID0g TlVMTDsKPj4+PiAgICAgbmFuZF9zZXRfZmxhc2hfbm9kZShuYW5kX2NoaXAsIGRldi0+b2Zfbm9k ZSk7Cj4+Pj4KPj4+Cj4+PiBuYW5kX3NldF9mbGFzaF9ub2RlKCkgaXMgbm93IHRha2luZyB0aGUg ImxhYmVsIiBEVCBwcm9wZXJ0eSBpbnRvIGFjY291bnQKPj4+IGFuZCBhc3NpZ25pbmcgbXRkLT5u YW1lIHRvIHRoaXMgdmFsdWUgaWYgcHJlc2VudC4gSSdkIHJlY29tbWVuZCBkb2luZwo+Pj4KPj4+ ICAgICAgaWYgKCFtdGQtPm5hbWUpCj4+PiAgICAgICAgICAgICAgbXRkLT5uYW1lID0gIm9tYXAy LW5hbmQuMCI7Cj4+Cj4+IFRoaXMgY29tbWVudCBzdGlsbCBzdGFuZHMsIGV4Y2VwdCBpdCBzaG91 bGQgYmU6Cj4+Cj4+ICAgICAgIGlmICghbXRkLT5uYW1lKQo+PiAgICAgICAgICAgICAgIG10ZC0+ bmFtZSA9IGRldm1fa2FzcHJpbnRmKCZwZGV2LT5kZXYsIEdGUF9LRVJORUwsCj4+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIm9tYXAyLW5hbmQuJWQiLCBpbmZvLT5n cG1jX2NzKTsKPj4KPj4gICAgICAgaWYgKCFtdGQtPm5hbWUpIHsKPj4gICAgICAgICAgICAgICBk ZXZfZXJyKCZwZGV2LT5kZXYsICJGYWlsZWQgdG8gc2V0IE1URCBuYW1lXG4iKTsKPj4gICAgICAg ICAgICAgICByZXR1cm4gLUVOT01FTTsKPj4gICAgICAgfQo+Pgo+PiBSZWdhcmRzLAo+Pgo+PiBC b3Jpcwo+Pgo+PiBbMV1odHRwOi8vbHhyLmZyZWUtZWxlY3Ryb25zLmNvbS9zb3VyY2UvYXJjaC9h cm0vbWFjaC1vbWFwMi9ncG1jLW5hbmQuYz92PTQuNiNMMTMzCj4+Cj4KPiBPSy4gSGVyZSBpcyB0 aGUgdXBkYXRlZCBwYXRjaC4gSSdsbCBzZW5kIGFuIHByb3BlciBwYXRjaCBieSB0b21vcnJvdy4K Pgo+IEFkYW0sIHBsZWFzZSB0ZXN0IGl0IG9uIHlvdXIgYm9hcmQgaWYgcG9zc2libGUuIFRoYW5r cy4KCkkgdGVzdGVkIHRoaXMgYWdhaW5zdCBMaW51eCBtYXN0ZXIgKDQuMTEuMC1yYzQpIGFuZCBp dCB3b3JrcyBmb3IgbWUuClRoYW5rIHlvdS4gIEdvIGFoZWFkIGFuZCBhZGQgbWUgYXMgJ3Rlc3Rl ZC1ieScgd2hlbiB5b3UgZG8geW91IGZpbmFsCnBhdGNoIHN1Ym1pc3Npb24uCgoKYWRhbQo+Cj4g LS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvb21hcDIuYyB8IDkgKysrKysrKysrCj4gIDEgZmlsZSBj aGFuZ2VkLCA5IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5k L29tYXAyLmMgYi9kcml2ZXJzL210ZC9uYW5kL29tYXAyLmMKPiBpbmRleCAyYTUyMTAxLi4xYjNk N2NjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvb21hcDIuYwo+ICsrKyBiL2RyaXZl cnMvbXRkL25hbmQvb21hcDIuYwo+IEBAIC0xODU2LDYgKzE4NTYsMTUgQEAgc3RhdGljIGludCBv bWFwX25hbmRfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgICAgICAgIG5h bmRfY2hpcC0+ZWNjLnByaXYgICAgID0gTlVMTDsKPiAgICAgICAgIG5hbmRfc2V0X2ZsYXNoX25v ZGUobmFuZF9jaGlwLCBkZXYtPm9mX25vZGUpOwo+Cj4gKyAgICAgICBpZiAoIW10ZC0+bmFtZSkg ewo+ICsgICAgICAgICAgICAgICBtdGQtPm5hbWUgPSBkZXZtX2thc3ByaW50ZigmcGRldi0+ZGV2 LCBHRlBfS0VSTkVMLCAib21hcDItbmFuZC4lZCIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGluZm8tPmdwbWNfY3MpOwo+ICsgICAgICAgICAgICAgICBpZiAo IW10ZC0+bmFtZSkgewo+ICsgICAgICAgICAgICAgICAgICAgICAgIGRldl9lcnIoJnBkZXYtPmRl diwgIkZhaWxlZCB0byBzZXQgTVREIG5hbWVcbiIpOwo+ICsgICAgICAgICAgICAgICAgICAgICAg IHJldHVybiAtRU5PTUVNOwo+ICsgICAgICAgICAgICAgICB9Cj4gKyAgICAgICB9Cj4gKwo+ICAg ICAgICAgcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAw KTsKPiAgICAgICAgIG5hbmRfY2hpcC0+SU9fQUREUl9SID0gZGV2bV9pb3JlbWFwX3Jlc291cmNl KCZwZGV2LT5kZXYsIHJlcyk7Cj4gICAgICAgICBpZiAoSVNfRVJSKG5hbmRfY2hpcC0+SU9fQURE Ul9SKSkKPiAtLQo+IDIuNy40Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1ctJkr-0004QM-3u for linux-mtd@lists.infradead.org; Wed, 29 Mar 2017 19:59:43 +0000 Received: by mail-pg0-x244.google.com with SMTP id o123so4347497pga.1 for ; Wed, 29 Mar 2017 12:59:20 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <89e42bf8-4a69-1e99-59e8-94dc44889849@ti.com> References: <20170328215705.438d7af8@bbrezillon> <04afe149-24b2-daec-5ef0-2d662ed79040@ti.com> <20170329151002.26203f2c@bbrezillon> <20170329151837.509c15c6@bbrezillon> <89e42bf8-4a69-1e99-59e8-94dc44889849@ti.com> From: Adam Ford Date: Wed, 29 Mar 2017 14:59:19 -0500 Message-ID: Subject: Re: Passing NAND mtdparts to OMAP2+ Kernel To: Roger Quadros Cc: Boris Brezillon , "Leto, Enrico" , linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Mar 29, 2017 at 9:06 AM, Roger Quadros wrote: > On 29/03/17 16:18, Boris Brezillon wrote: >> On Wed, 29 Mar 2017 15:10:02 +0200 >> Boris Brezillon wrote: >> >>> On Wed, 29 Mar 2017 15:41:07 +0300 >>> Roger Quadros wrote: >>> >>>> Adam, >>>> >>>> On 29/03/17 14:39, Adam Ford wrote: >>>>> On Tue, Mar 28, 2017 at 2:57 PM, Boris Brezillon >>>>> wrote: >>>>>> +Roger and Enrico >>>>>> >>>>>> On Tue, 28 Mar 2017 10:43:01 -0500 >>>>>> Adam Ford wrote: >>>>>> >>>>>>> I posted this on the linux-omap list, and I was asked to post this = on >>>>>>> the linux-mtd list: >>>>>>> >>>>>>> >>>>>>> I tried to remove the MTD partitions from the Linux device tree, an= d I >>>>>>> noticed that there was no partition information being pushed anymor= e >>>>>>> unless I changed the mtdparts name in U-Boot. >>>>>>> >>>>>>> It appears as if the MTD drivers have changed a bit. I found a few >>>>>>> e-mails floating around that attempt to fix this >>>>>>> >>>>>>> Commit f7a8e38f07a17be907585 ("mtd: nand: assign reasonable default >>>>>>> name for NAND drivers") attempts to address this, and someone over = at >>>>>>> https://patchwork.ozlabs.org/patch/707065/ attempted to address it = as >>>>>>> well in a slightly different way. >>>>>> >>>>>> Can you test the patch and let me know if solves the problem. If it >>>>>> does, I'll send a clean version of the patch and queue it for 4.12. >>>>>> >>>>> >>>>> I tried to apply the patch directly, but it failed. I then manually >>>>> copy-pasted it into the proper place, but it fails to compile. >>>>> >>>>> drivers/mtd/nand/omap2.c: In function =E2=80=98omap_nand_probe=E2=80= =99: >>>>> drivers/mtd/nand/omap2.c:1859:14: error: implicit declaration of >>>>> function =E2=80=98devm_kasprinf=E2=80=99 [-Werror=3Dimplicit-function= -declaration] >>>>> mtd->name =3D devm_kasprinf(&pdev->dev, "omap2-nand.%d", info->gpmc= _cs); >>>>> ^~~~~~~~~~~~~ >>>>> drivers/mtd/nand/omap2.c:1859:12: warning: assignment makes pointer >>>>> from integer without a cast [-Wint-conversion] >>>>> mtd->name =3D devm_kasprinf(&pdev->dev, "omap2-nand.%d", info->gpmc= _cs); >>>>> ^ >>>>> cc1: some warnings being treated as errors >>>>> >>>>> I use buildroot to build my toolchain and I am using gcc version 6.3.= 0 >>>>> with glibc 2.24. Is there supposed to be an include somewhere? I am >>>>> not familiar with devm_kasprinf. >>> >>> It's a typo: s/devm_kasprinf/devm_kasprintf/. >>> >>>>> >>>>> >>>> >>>> Does the below patch work for you? >>> >>> Should work indeed. >>> >>> I had a closer look and it seems that the bug was actually introduced >>> by c9711ec5250b mtd: nand: omap: Clean up device tree >>> support. >>> The parent device name has changed when switching to the new DT >>> representation: omap2-nand.0 (where 0 is the controller instance) becam= e >>> 30000000.nand (where 30000000 is the base reg address in the physical >>> address space). Which means my proposal was incorrect (0 is not the CS >>> line, it's the NAND controller instance number), so we'd better >>> statically set it to "omap2-nand.0". >> >> Changing my mind (again :)). According to [1], the instance id is >> related to the CS line, so devm_kasprintf() is the right solution. >> >> Sorry for the noise. >> >>> >>>> >>>> cheers, >>>> -roger >>>> >>>> --- >>>> drivers/mtd/nand/omap2.c | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c >>>> index 2a52101..f693b8d 100644 >>>> --- a/drivers/mtd/nand/omap2.c >>>> +++ b/drivers/mtd/nand/omap2.c >>>> @@ -1856,6 +1856,13 @@ static int omap_nand_probe(struct platform_devi= ce *pdev) >>>> nand_chip->ecc.priv =3D NULL; >>>> nand_set_flash_node(nand_chip, dev->of_node); >>>> >>> >>> nand_set_flash_node() is now taking the "label" DT property into accoun= t >>> and assigning mtd->name to this value if present. I'd recommend doing >>> >>> if (!mtd->name) >>> mtd->name =3D "omap2-nand.0"; >> >> This comment still stands, except it should be: >> >> if (!mtd->name) >> mtd->name =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, >> "omap2-nand.%d", info->gpmc_cs)= ; >> >> if (!mtd->name) { >> dev_err(&pdev->dev, "Failed to set MTD name\n"); >> return -ENOMEM; >> } >> >> Regards, >> >> Boris >> >> [1]http://lxr.free-electrons.com/source/arch/arm/mach-omap2/gpmc-nand.c?= v=3D4.6#L133 >> > > OK. Here is the updated patch. I'll send an proper patch by tomorrow. > > Adam, please test it on your board if possible. Thanks. I tested this against Linux master (4.11.0-rc4) and it works for me. Thank you. Go ahead and add me as 'tested-by' when you do you final patch submission. adam > > --- > drivers/mtd/nand/omap2.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > index 2a52101..1b3d7cc 100644 > --- a/drivers/mtd/nand/omap2.c > +++ b/drivers/mtd/nand/omap2.c > @@ -1856,6 +1856,15 @@ static int omap_nand_probe(struct platform_device = *pdev) > nand_chip->ecc.priv =3D NULL; > nand_set_flash_node(nand_chip, dev->of_node); > > + if (!mtd->name) { > + mtd->name =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, "oma= p2-nand.%d", > + info->gpmc_cs); > + if (!mtd->name) { > + dev_err(&pdev->dev, "Failed to set MTD name\n"); > + return -ENOMEM; > + } > + } > + > res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > nand_chip->IO_ADDR_R =3D devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(nand_chip->IO_ADDR_R)) > -- > 2.7.4 >