From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC60C49EA4 for ; Tue, 22 Jun 2021 03:09:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 563686023C for ; Tue, 22 Jun 2021 03:09:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbhFVDL3 (ORCPT ); Mon, 21 Jun 2021 23:11:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbhFVDL2 (ORCPT ); Mon, 21 Jun 2021 23:11:28 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7973FC061574; Mon, 21 Jun 2021 20:09:13 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id ji1so26000599ejc.4; Mon, 21 Jun 2021 20:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7niPUm2hSmXvDTZIayC2hRqOTqKfDH7sAfKGCNr3PSo=; b=Zx+57caGKfxlamUwXIlwuTe4G3ODjn+B6ted2HuK2+zIn7+TrVW2gdJcV3WxdX5s3N SZi/s1vDnktJkDb75Rju2zcYWol/4DqSJqO1AFsyRyAkqLmz5TRLavUZaK6+F9eqe9DK +xMHz+ytlIDL9ZwD+iy7cWeQ6KpavudGFcfEv2upbHvnoBjqpzH7oSy4rQKuvad1IQLV HLjWxc92fWmYc7nICmQ8qQI+XJ/BhU8mu+32kUgvtdIa1TjBAwWiCax9EeefIJvYK/pl VliD4SK7A5llEdkqCGaH2HgG81kNYg7Li/DSB4R7v6TgU0BHQ9uuxEsv10X7Yvnnbdz+ qCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7niPUm2hSmXvDTZIayC2hRqOTqKfDH7sAfKGCNr3PSo=; b=sqp5sfj/+kCSRHmD2JabyWx9tHo24AK+gTJdaugAfefjEiscG5BW+xUw1BOU/i9x8e sw7+GORYZlzYjmHnLKkNhK+1PWhy7IfVwZ0nscTnDJc6tfdmx3QuZbjzUO4S/XdddWZh Nb0DV0XDn7NKH+IgYLXR0UoFb8yCE1tl2hAOe5qmV9ABjOpNPxp3gJHSndixNkSwsIWY ++yc4qHigQS0VP0gaCUuBj/MbsE6b+x2e5xTjjfgLQPJFyfjUlN9rTZXWuCYxOgaXVOo luugMiMO3VlT1BZHOah6AgGd1tAgSG7JuNr+yO70KoQslYaF21DZt/qG6vK0uH4/Qdp1 Bgog== X-Gm-Message-State: AOAM530Cka7lDRsGd8OWEXcxKPoBtFkamVsYsxHwMKlyuR1iAsqefozu NL6VtnJLDAT4hsg60e/TeMliJzOXIMoHOJWyfME= X-Google-Smtp-Source: ABdhPJzozl3nK5cYfHbxs2Xty143R2O1VPZnWLAKoR/K4faLM/z8uiVuXlXqTrzTGoJdLISQuhOYfLCbJqd47LLTINE= X-Received: by 2002:a17:907:1611:: with SMTP id hb17mr1418947ejc.450.1624331351539; Mon, 21 Jun 2021 20:09:11 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-8-jagan@amarulasolutions.com> In-Reply-To: <20210621072424.111733-8-jagan@amarulasolutions.com> From: Adam Ford Date: Mon, 21 Jun 2021 22:09:00 -0500 Message-ID: Subject: Re: [RFC PATCH 7/9] arm64: dts: imx8mm: Add eLCDIF node support To: Jagan Teki Cc: Peng Fan , Shawn Guo , Sascha Hauer , Tomasz Figa , Fancy Fang , devicetree , Francis Laniel , Matteo Lisi , Linux Kernel Mailing List , dri-devel , Rob Herring , NXP Linux Team , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, linux-amarula@amarulasolutions.com, arm-soc Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 2:25 AM Jagan Teki wrote: > > Add eLCDIF controller node for i.MX8MM. > > Cc: Rob Herring > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index fe5485ee9419..5f68182ed3a6 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -1030,6 +1030,25 @@ aips4: bus@32c00000 { > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > > + lcdif: lcdif@32e00000 { > + compatible = "fsl,imx8mm-lcdif", "fsl,imx6sx-lcdif"; Based on a comment I read from Marek [1] from this patch series for the driver, I think fallback compatible should be fsl,imx28-lcdif. "The iMX8MM and iMX8MN do not support the overlay plane, so they are MXSFB V4" [1] - https://patchwork.kernel.org/project/dri-devel/patch/20210620224834.189411-1-marex@denx.de/ adam > + reg = <0x32e00000 0x10000>; > + clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>, > + <&clk IMX8MM_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MM_CLK_DISP_APB_ROOT>; > + clock-names = "pix", "disp_axi", "axi"; > + assigned-clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>, > + <&clk IMX8MM_CLK_DISP_AXI>, > + <&clk IMX8MM_CLK_DISP_APB>; > + assigned-clock-parents = <&clk IMX8MM_VIDEO_PLL1_OUT>, > + <&clk IMX8MM_SYS_PLL2_1000M>, > + <&clk IMX8MM_SYS_PLL1_800M>; > + assigned-clock-rate = <594000000>, <500000000>, <200000000>; > + interrupts = ; > + power-domains = <&dispmix_blk_ctl IMX8MM_BLK_CTL_PD_DISPMIX_LCDIF>; > + status = "disabled"; > + }; > + > dispmix_blk_ctl: blk-ctl@32e28000 { > compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon"; > reg = <0x32e28000 0x100>; > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B43BC2B9F4 for ; Tue, 22 Jun 2021 03:11:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00EFD610EA for ; Tue, 22 Jun 2021 03:11:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00EFD610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wuF6fTbv7cuw8TAI8U+zH95zFMYjUrE2u1K+9lgb3E4=; b=GyQotnsrLpwp++ 8ocAiWpE13Ye+q7FN+oWUoAcC6omLgLmtaq9lmBx0IP+lXXNWZ+5zt7aVShR1FZWOHZK2fDO7WUFd iXVywHbS4pYSc7q/frpZc99HEmpozkPP/3QePVPMwLbRxZtwNnxec8rC7ur9KWLAJKvntSqEATwgW tglrFdAd/f43W8WpPwWgKL9kDvra9yrE1k7zFjpl55pXJEuEHRhNzZrWCtIMK5S5G6+pRz+LtbGeR JCcP1P2v2+TyvsUfiq1nMppzTrKTtfaOML7etAlthA+4vmjTGmfTe4CPqg8dsd8uDQoK9PcSxu7Bb ZGYw+zcXGTe2ee8K1e4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvWmq-005TLr-Lg; Tue, 22 Jun 2021 03:09:16 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvWmn-005TKM-5g; Tue, 22 Jun 2021 03:09:14 +0000 Received: by mail-ej1-x633.google.com with SMTP id he7so32027693ejc.13; Mon, 21 Jun 2021 20:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7niPUm2hSmXvDTZIayC2hRqOTqKfDH7sAfKGCNr3PSo=; b=Zx+57caGKfxlamUwXIlwuTe4G3ODjn+B6ted2HuK2+zIn7+TrVW2gdJcV3WxdX5s3N SZi/s1vDnktJkDb75Rju2zcYWol/4DqSJqO1AFsyRyAkqLmz5TRLavUZaK6+F9eqe9DK +xMHz+ytlIDL9ZwD+iy7cWeQ6KpavudGFcfEv2upbHvnoBjqpzH7oSy4rQKuvad1IQLV HLjWxc92fWmYc7nICmQ8qQI+XJ/BhU8mu+32kUgvtdIa1TjBAwWiCax9EeefIJvYK/pl VliD4SK7A5llEdkqCGaH2HgG81kNYg7Li/DSB4R7v6TgU0BHQ9uuxEsv10X7Yvnnbdz+ qCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7niPUm2hSmXvDTZIayC2hRqOTqKfDH7sAfKGCNr3PSo=; b=Y8dCsBCyUjOfYdsmhuIqM/Oxx01Xbzn+or7s1Mn8vH+3oLsUK5X8EPbxcDlVUJ6YLJ j0dpbmY73RLNB/EjtlV6Wrdghq0P7EliBYCFc+IxmKgtiK5zR2VE0UwjkoWPuEnAn9kQ xKmjnSK7subiDVGrW4mJd47ZsD4qTbQ37Q4YveiCDdzXeueA/OYZIBjh0FTmBk4HXDFO wPHXntoYPvFCP550QFdbeU/Jv01mAFwWefhcSDbtWINylWyikxW1oYzRX0GOkoIHCzE2 ae5sD1YId5EdwzfcXeQIDGe1dQNvXJX/W/E2qFRURsG0vOhbC17DWYrGX+CWatHDF3Ds fWHg== X-Gm-Message-State: AOAM531/NIcCrBDUvG8r/YKkkg4xa3ANO/FCJU8W/rvfkf9sQZIE2FCj 0SSjkRb6olizYqWMMkwDlr9vzpobDKHKQmhd2/o= X-Google-Smtp-Source: ABdhPJzozl3nK5cYfHbxs2Xty143R2O1VPZnWLAKoR/K4faLM/z8uiVuXlXqTrzTGoJdLISQuhOYfLCbJqd47LLTINE= X-Received: by 2002:a17:907:1611:: with SMTP id hb17mr1418947ejc.450.1624331351539; Mon, 21 Jun 2021 20:09:11 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-8-jagan@amarulasolutions.com> In-Reply-To: <20210621072424.111733-8-jagan@amarulasolutions.com> From: Adam Ford Date: Mon, 21 Jun 2021 22:09:00 -0500 Message-ID: Subject: Re: [RFC PATCH 7/9] arm64: dts: imx8mm: Add eLCDIF node support To: Jagan Teki Cc: Peng Fan , Shawn Guo , Sascha Hauer , Tomasz Figa , Fancy Fang , devicetree , Francis Laniel , Matteo Lisi , Linux Kernel Mailing List , dri-devel , Rob Herring , NXP Linux Team , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, linux-amarula@amarulasolutions.com, arm-soc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_200913_261239_26BCCA5F X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 21, 2021 at 2:25 AM Jagan Teki wrote: > > Add eLCDIF controller node for i.MX8MM. > > Cc: Rob Herring > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index fe5485ee9419..5f68182ed3a6 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -1030,6 +1030,25 @@ aips4: bus@32c00000 { > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > > + lcdif: lcdif@32e00000 { > + compatible = "fsl,imx8mm-lcdif", "fsl,imx6sx-lcdif"; Based on a comment I read from Marek [1] from this patch series for the driver, I think fallback compatible should be fsl,imx28-lcdif. "The iMX8MM and iMX8MN do not support the overlay plane, so they are MXSFB V4" [1] - https://patchwork.kernel.org/project/dri-devel/patch/20210620224834.189411-1-marex@denx.de/ adam > + reg = <0x32e00000 0x10000>; > + clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>, > + <&clk IMX8MM_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MM_CLK_DISP_APB_ROOT>; > + clock-names = "pix", "disp_axi", "axi"; > + assigned-clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>, > + <&clk IMX8MM_CLK_DISP_AXI>, > + <&clk IMX8MM_CLK_DISP_APB>; > + assigned-clock-parents = <&clk IMX8MM_VIDEO_PLL1_OUT>, > + <&clk IMX8MM_SYS_PLL2_1000M>, > + <&clk IMX8MM_SYS_PLL1_800M>; > + assigned-clock-rate = <594000000>, <500000000>, <200000000>; > + interrupts = ; > + power-domains = <&dispmix_blk_ctl IMX8MM_BLK_CTL_PD_DISPMIX_LCDIF>; > + status = "disabled"; > + }; > + > dispmix_blk_ctl: blk-ctl@32e28000 { > compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon"; > reg = <0x32e28000 0x100>; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF87C48BE5 for ; Tue, 22 Jun 2021 03:09:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0F0761108 for ; Tue, 22 Jun 2021 03:09:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0F0761108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 39EA46E082; Tue, 22 Jun 2021 03:09:14 +0000 (UTC) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1543F6E07B for ; Tue, 22 Jun 2021 03:09:13 +0000 (UTC) Received: by mail-ej1-x635.google.com with SMTP id l1so32138056ejb.6 for ; Mon, 21 Jun 2021 20:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7niPUm2hSmXvDTZIayC2hRqOTqKfDH7sAfKGCNr3PSo=; b=Zx+57caGKfxlamUwXIlwuTe4G3ODjn+B6ted2HuK2+zIn7+TrVW2gdJcV3WxdX5s3N SZi/s1vDnktJkDb75Rju2zcYWol/4DqSJqO1AFsyRyAkqLmz5TRLavUZaK6+F9eqe9DK +xMHz+ytlIDL9ZwD+iy7cWeQ6KpavudGFcfEv2upbHvnoBjqpzH7oSy4rQKuvad1IQLV HLjWxc92fWmYc7nICmQ8qQI+XJ/BhU8mu+32kUgvtdIa1TjBAwWiCax9EeefIJvYK/pl VliD4SK7A5llEdkqCGaH2HgG81kNYg7Li/DSB4R7v6TgU0BHQ9uuxEsv10X7Yvnnbdz+ qCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7niPUm2hSmXvDTZIayC2hRqOTqKfDH7sAfKGCNr3PSo=; b=oL6n2kK2Mz4DVcpRL+gKz8pXwV65eRNv5RQVC8VTeTz91NgNbpwSUynGa/nA9Ouf6h /GxiQ4L794hcq4ypjuuw5FXCET4Co9QcQaXzGq+Zrxnzt400tdqEKb1zf45Tt3RM1Zr9 VGbZ2K7yP9Co5BbdKPMvGbfatkqtKEwdHkhclFONxBYa+ytQsS5hljLgokomZiWNBC5O BKT8IzxCTGyKN4KYlomWks6Dw3XwqYRDD/uIDBt+OSerKZenBjFFNMxQWXvdwUNTsA7M WEG4u1Uut4A+eNUj+k0hhEWq1WajBZMLetqJa/2l9Vsow7Pu9aGdbCE9L5Oo6BqqZz+8 LSKw== X-Gm-Message-State: AOAM533xZkeRErsASuktgZ5GCQwodlAot5UDKVNM01BUIIWMCLOuXwj5 buyKR7hWvu3ldpHt0DLGoMXYTIi8WTe9Dhp7FfY= X-Google-Smtp-Source: ABdhPJzozl3nK5cYfHbxs2Xty143R2O1VPZnWLAKoR/K4faLM/z8uiVuXlXqTrzTGoJdLISQuhOYfLCbJqd47LLTINE= X-Received: by 2002:a17:907:1611:: with SMTP id hb17mr1418947ejc.450.1624331351539; Mon, 21 Jun 2021 20:09:11 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-8-jagan@amarulasolutions.com> In-Reply-To: <20210621072424.111733-8-jagan@amarulasolutions.com> From: Adam Ford Date: Mon, 21 Jun 2021 22:09:00 -0500 Message-ID: Subject: Re: [RFC PATCH 7/9] arm64: dts: imx8mm: Add eLCDIF node support To: Jagan Teki Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Peng Fan , Francis Laniel , Matteo Lisi , linux-amarula@amarulasolutions.com, Tomasz Figa , Linux Kernel Mailing List , dri-devel , Rob Herring , NXP Linux Team , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Fancy Fang , Shawn Guo , Sascha Hauer , arm-soc Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jun 21, 2021 at 2:25 AM Jagan Teki wrote: > > Add eLCDIF controller node for i.MX8MM. > > Cc: Rob Herring > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index fe5485ee9419..5f68182ed3a6 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -1030,6 +1030,25 @@ aips4: bus@32c00000 { > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > > + lcdif: lcdif@32e00000 { > + compatible = "fsl,imx8mm-lcdif", "fsl,imx6sx-lcdif"; Based on a comment I read from Marek [1] from this patch series for the driver, I think fallback compatible should be fsl,imx28-lcdif. "The iMX8MM and iMX8MN do not support the overlay plane, so they are MXSFB V4" [1] - https://patchwork.kernel.org/project/dri-devel/patch/20210620224834.189411-1-marex@denx.de/ adam > + reg = <0x32e00000 0x10000>; > + clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>, > + <&clk IMX8MM_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MM_CLK_DISP_APB_ROOT>; > + clock-names = "pix", "disp_axi", "axi"; > + assigned-clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>, > + <&clk IMX8MM_CLK_DISP_AXI>, > + <&clk IMX8MM_CLK_DISP_APB>; > + assigned-clock-parents = <&clk IMX8MM_VIDEO_PLL1_OUT>, > + <&clk IMX8MM_SYS_PLL2_1000M>, > + <&clk IMX8MM_SYS_PLL1_800M>; > + assigned-clock-rate = <594000000>, <500000000>, <200000000>; > + interrupts = ; > + power-domains = <&dispmix_blk_ctl IMX8MM_BLK_CTL_PD_DISPMIX_LCDIF>; > + status = "disabled"; > + }; > + > dispmix_blk_ctl: blk-ctl@32e28000 { > compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon"; > reg = <0x32e28000 0x100>; > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06206C48BDF for ; Tue, 22 Jun 2021 03:09:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD28F6120D for ; Tue, 22 Jun 2021 03:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD28F6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6+IyR5CUJfAZHf46kryCfn+Y0fapFrjUc2f0FMsIyfY=; b=aewOGjUK5CnRHv SX+ZR8ZUNgC0uxP7LBFRWXxpvqMKzjn4QbroTvHat6Dt0C0isSKceHnlP2GfLm4Yla+9b8zlCcvJc iB4mlTIZO3NpaVWUjPLsnhGC8lBk1PDxCMuJ5GjJybj23x9J28DqyztrtCcI+1Lr4Nab4clh/uoXz AmdQZh72Z2bryXYYJ0ERsr09pzdczDUBfCYQuIrffiLXMvL/u1EoQxcI17n8Mm1UcDUCh9Vn2XbQ6 oXdiP0YVWNTW2Ub+jC3GJrOTy/e/uHuP9KPYLGSNTG1pHAB5F3MuTUBebs1CzXyZhIEK5XyIl/Phl k4eS4H9AQdRUFn3xi0Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvWmp-005TLm-Aw; Tue, 22 Jun 2021 03:09:15 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvWmn-005TKM-5g; Tue, 22 Jun 2021 03:09:14 +0000 Received: by mail-ej1-x633.google.com with SMTP id he7so32027693ejc.13; Mon, 21 Jun 2021 20:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7niPUm2hSmXvDTZIayC2hRqOTqKfDH7sAfKGCNr3PSo=; b=Zx+57caGKfxlamUwXIlwuTe4G3ODjn+B6ted2HuK2+zIn7+TrVW2gdJcV3WxdX5s3N SZi/s1vDnktJkDb75Rju2zcYWol/4DqSJqO1AFsyRyAkqLmz5TRLavUZaK6+F9eqe9DK +xMHz+ytlIDL9ZwD+iy7cWeQ6KpavudGFcfEv2upbHvnoBjqpzH7oSy4rQKuvad1IQLV HLjWxc92fWmYc7nICmQ8qQI+XJ/BhU8mu+32kUgvtdIa1TjBAwWiCax9EeefIJvYK/pl VliD4SK7A5llEdkqCGaH2HgG81kNYg7Li/DSB4R7v6TgU0BHQ9uuxEsv10X7Yvnnbdz+ qCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7niPUm2hSmXvDTZIayC2hRqOTqKfDH7sAfKGCNr3PSo=; b=Y8dCsBCyUjOfYdsmhuIqM/Oxx01Xbzn+or7s1Mn8vH+3oLsUK5X8EPbxcDlVUJ6YLJ j0dpbmY73RLNB/EjtlV6Wrdghq0P7EliBYCFc+IxmKgtiK5zR2VE0UwjkoWPuEnAn9kQ xKmjnSK7subiDVGrW4mJd47ZsD4qTbQ37Q4YveiCDdzXeueA/OYZIBjh0FTmBk4HXDFO wPHXntoYPvFCP550QFdbeU/Jv01mAFwWefhcSDbtWINylWyikxW1oYzRX0GOkoIHCzE2 ae5sD1YId5EdwzfcXeQIDGe1dQNvXJX/W/E2qFRURsG0vOhbC17DWYrGX+CWatHDF3Ds fWHg== X-Gm-Message-State: AOAM531/NIcCrBDUvG8r/YKkkg4xa3ANO/FCJU8W/rvfkf9sQZIE2FCj 0SSjkRb6olizYqWMMkwDlr9vzpobDKHKQmhd2/o= X-Google-Smtp-Source: ABdhPJzozl3nK5cYfHbxs2Xty143R2O1VPZnWLAKoR/K4faLM/z8uiVuXlXqTrzTGoJdLISQuhOYfLCbJqd47LLTINE= X-Received: by 2002:a17:907:1611:: with SMTP id hb17mr1418947ejc.450.1624331351539; Mon, 21 Jun 2021 20:09:11 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-8-jagan@amarulasolutions.com> In-Reply-To: <20210621072424.111733-8-jagan@amarulasolutions.com> From: Adam Ford Date: Mon, 21 Jun 2021 22:09:00 -0500 Message-ID: Subject: Re: [RFC PATCH 7/9] arm64: dts: imx8mm: Add eLCDIF node support To: Jagan Teki Cc: Peng Fan , Shawn Guo , Sascha Hauer , Tomasz Figa , Fancy Fang , devicetree , Francis Laniel , Matteo Lisi , Linux Kernel Mailing List , dri-devel , Rob Herring , NXP Linux Team , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, linux-amarula@amarulasolutions.com, arm-soc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_200913_261239_26BCCA5F X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Jun 21, 2021 at 2:25 AM Jagan Teki wrote: > > Add eLCDIF controller node for i.MX8MM. > > Cc: Rob Herring > Signed-off-by: Jagan Teki > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index fe5485ee9419..5f68182ed3a6 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -1030,6 +1030,25 @@ aips4: bus@32c00000 { > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > > + lcdif: lcdif@32e00000 { > + compatible = "fsl,imx8mm-lcdif", "fsl,imx6sx-lcdif"; Based on a comment I read from Marek [1] from this patch series for the driver, I think fallback compatible should be fsl,imx28-lcdif. "The iMX8MM and iMX8MN do not support the overlay plane, so they are MXSFB V4" [1] - https://patchwork.kernel.org/project/dri-devel/patch/20210620224834.189411-1-marex@denx.de/ adam > + reg = <0x32e00000 0x10000>; > + clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>, > + <&clk IMX8MM_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MM_CLK_DISP_APB_ROOT>; > + clock-names = "pix", "disp_axi", "axi"; > + assigned-clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>, > + <&clk IMX8MM_CLK_DISP_AXI>, > + <&clk IMX8MM_CLK_DISP_APB>; > + assigned-clock-parents = <&clk IMX8MM_VIDEO_PLL1_OUT>, > + <&clk IMX8MM_SYS_PLL2_1000M>, > + <&clk IMX8MM_SYS_PLL1_800M>; > + assigned-clock-rate = <594000000>, <500000000>, <200000000>; > + interrupts = ; > + power-domains = <&dispmix_blk_ctl IMX8MM_BLK_CTL_PD_DISPMIX_LCDIF>; > + status = "disabled"; > + }; > + > dispmix_blk_ctl: blk-ctl@32e28000 { > compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon"; > reg = <0x32e28000 0x100>; > -- > 2.25.1 > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy