All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Ford <aford173@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH v2 08/13] davinci: da850-evm: enable driver model for NAND
Date: Mon, 29 Jul 2019 13:14:56 -0500	[thread overview]
Message-ID: <CAHCN7x+gGGqLG6i0qHt_r+3hs_2N1LB8F6YdY76x8TdBZD_=1Q@mail.gmail.com> (raw)
In-Reply-To: <20190729065810.19452-9-brgl@bgdev.pl>

On Mon, Jul 29, 2019 at 1:58 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Enable the driver-model on da850-evm. We need to add a dummy nand node
> to the device tree, as the real nand node is a sub-node of the aemif
> device.
>
> On linux the aemif driver populates all its child nodes, but we can't do
> it in u-boot currently.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Tested-by: Adam Ford <aford173@gmail.com> #da850-evm

The current state of master currently has nand booting broken on the
da850evm_nand_defconfig, so I'll welcome this patch since it seems to
fix the broken booting.  I haven't bisected it because there is this
pending fix.

adam
> ---
>  arch/arm/dts/da850-evm-u-boot.dtsi    | 4 ++++
>  configs/da850evm_defconfig            | 1 +
>  configs/da850evm_direct_nor_defconfig | 1 +
>  configs/da850evm_nand_defconfig       | 1 +
>  include/configs/da850evm.h            | 4 ++++
>  5 files changed, 11 insertions(+)
>
> diff --git a/arch/arm/dts/da850-evm-u-boot.dtsi b/arch/arm/dts/da850-evm-u-boot.dtsi
> index 1683f3472e..d9e8b9926a 100644
> --- a/arch/arm/dts/da850-evm-u-boot.dtsi
> +++ b/arch/arm/dts/da850-evm-u-boot.dtsi
> @@ -10,6 +10,10 @@
>         soc at 1c00000 {
>                 u-boot,dm-spl;
>         };
> +
> +       nand {
> +               compatible = "ti,davinci-nand";
> +       };
>  };
>
>  &flash {
> diff --git a/configs/da850evm_defconfig b/configs/da850evm_defconfig
> index 99300cb297..7de1d2ffc4 100644
> --- a/configs/da850evm_defconfig
> +++ b/configs/da850evm_defconfig
> @@ -52,6 +52,7 @@ CONFIG_DA8XX_GPIO=y
>  CONFIG_DM_I2C=y
>  CONFIG_SYS_I2C_DAVINCI=y
>  CONFIG_DM_MMC=y
> +CONFIG_MTD=y
>  CONFIG_MTD_DEVICE=y
>  CONFIG_DM_SPI_FLASH=y
>  CONFIG_SPI_FLASH=y
> diff --git a/configs/da850evm_direct_nor_defconfig b/configs/da850evm_direct_nor_defconfig
> index dcb4d96d0d..e3c2d13986 100644
> --- a/configs/da850evm_direct_nor_defconfig
> +++ b/configs/da850evm_direct_nor_defconfig
> @@ -42,6 +42,7 @@ CONFIG_DA8XX_GPIO=y
>  CONFIG_DM_I2C=y
>  CONFIG_SYS_I2C_DAVINCI=y
>  # CONFIG_MMC is not set
> +CONFIG_MTD=y
>  CONFIG_MTD_NOR_FLASH=y
>  CONFIG_FLASH_CFI_DRIVER=y
>  CONFIG_SYS_FLASH_PROTECTION=y
> diff --git a/configs/da850evm_nand_defconfig b/configs/da850evm_nand_defconfig
> index 7065205783..96602e514a 100644
> --- a/configs/da850evm_nand_defconfig
> +++ b/configs/da850evm_nand_defconfig
> @@ -49,6 +49,7 @@ CONFIG_DM_GPIO=y
>  CONFIG_DA8XX_GPIO=y
>  CONFIG_DM_I2C=y
>  CONFIG_DM_MMC=y
> +CONFIG_MTD=y
>  CONFIG_NAND=y
>  CONFIG_NAND_DAVINCI=y
>  CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
> diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
> index 2dab17afab..ff536131ba 100644
> --- a/include/configs/da850evm.h
> +++ b/include/configs/da850evm.h
> @@ -174,6 +174,10 @@
>  #define CONFIG_SPL_NAND_DRIVERS
>  #define CONFIG_SPL_NAND_ECC
>  #define CONFIG_SPL_NAND_LOAD
> +
> +#ifndef CONFIG_SPL_BUILD
> +#define CONFIG_SYS_NAND_SELF_INIT
> +#endif
>  #endif
>
>  /*
> --
> 2.21.0
>

  reply	other threads:[~2019-07-29 18:14 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29  6:57 [U-Boot] [RESEND PATCH v2 00/13] ARM: davinci: driver-model improvements Bartosz Golaszewski
2019-07-29  6:57 ` [U-Boot] [RESEND PATCH v2 01/13] davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs Bartosz Golaszewski
2019-07-29 16:14   ` Tom Rini
2019-07-29 16:24     ` Adam Ford
2019-07-30  1:21   ` Tom Rini
2019-07-29  6:57 ` [U-Boot] [RESEND PATCH v2 02/13] sandbox: " Bartosz Golaszewski
2019-07-30  1:21   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 03/13] i2c: remove i2c driver-model compatibility layer Bartosz Golaszewski
2019-07-30  1:21   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 04/13] omapl138_lcdk_defconfig: don't build support for SPI Bartosz Golaszewski
2019-07-30  1:22   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 05/13] nand: davinci: make davinci_nand_init() static Bartosz Golaszewski
2019-07-30  1:22   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 06/13] nand: davinci: add support for driver model Bartosz Golaszewski
2019-07-30  1:22   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 07/13] davinci: omapl138-lcdk: enable driver model for NAND Bartosz Golaszewski
2019-07-30  1:22   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 08/13] davinci: da850-evm: " Bartosz Golaszewski
2019-07-29 18:14   ` Adam Ford [this message]
2019-07-30  1:22   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 09/13] davinci: omapl138-lcdk: enable SPL_SYS_MALLOC_SIMPLE Bartosz Golaszewski
2019-07-30  1:22   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 10/13] davinci: omapl138-lcdk: enable CONFIG_USE_TINY_PRINTF Bartosz Golaszewski
2019-07-30  1:22   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 11/13] davinci: omapl138-lcdk: remove unneeded includes Bartosz Golaszewski
2019-07-30  1:22   ` Tom Rini
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 12/13] davinci: omapl138-lcdk: enable driver-model in SPL Bartosz Golaszewski
2019-07-30  1:23   ` Tom Rini
2019-09-25 13:34   ` Faiz Abbas
2019-10-25 16:10     ` Bartosz Golaszewski
2019-10-25 17:25       ` Rizvi, Mohammad Faiz Abbas
2019-10-27 18:05         ` Bartosz Golaszewski
2019-11-08 15:50       ` Bartosz Golaszewski
2019-11-08 16:14         ` Adam Ford
2019-11-08 17:33           ` Bartosz Golaszewski
2019-11-08 17:59             ` Bartosz Golaszewski
2019-11-11 12:57               ` Adam Ford
2019-11-13 10:52                 ` Bartosz Golaszewski
2019-11-13 10:55                   ` Bartosz Golaszewski
2019-11-11 10:18         ` Faiz Abbas
2019-07-29  6:58 ` [U-Boot] [RESEND PATCH v2 13/13] configs: omapl138_lcdk: enable NAND self-init " Bartosz Golaszewski
2019-07-30  1:23   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHCN7x+gGGqLG6i0qHt_r+3hs_2N1LB8F6YdY76x8TdBZD_=1Q@mail.gmail.com' \
    --to=aford173@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.