From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABB86C433F5 for ; Thu, 10 Feb 2022 13:57:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 20F2D8309D; Thu, 10 Feb 2022 14:57:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CH01cwGB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 50A3783041; Thu, 10 Feb 2022 14:57:36 +0100 (CET) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6A34683388 for ; Thu, 10 Feb 2022 14:57:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-ej1-x632.google.com with SMTP id y22so3607166eju.9 for ; Thu, 10 Feb 2022 05:57:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nfqQxuMvuxh34rTHTSqdO3HCvb0EmU9YE5CoE++qWEo=; b=CH01cwGBr1MAFfqj7vft30vT8gVMocmWjDsJzsMeo/ZpVBmpCSXE5+oWbJTA9Be520 /0b13zAbJbEkQgR835diJfF0x+QZsE5UYjLr62DbDWrbzvqTJnJ8doSQ6APnmRuuVoYc Ae24KnW8UHz3mDv1bPWU5YmJpqiZ7EFRFsv8FecyyQvWM4eFiBnZbvEKIHjOSjUllzpL A6QXcn8UeImFlowja0rIdsFGQj9OL7XvcqZwAHgwePkhqV+oPOtuvTF9GN4bGbOoa9oe n1IjnwKhvlG8PsNw4jpsYCgtK5Ldr/GsDFc5lMo8UcdZaTNXSnrBGiPVI5SwSNGi/x+z zyxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nfqQxuMvuxh34rTHTSqdO3HCvb0EmU9YE5CoE++qWEo=; b=jvota7iekFqDQySJHzMpVDYQ2WECznhs9bIC+kb991HbjYMdk6jhLaptD+5q2PkgwO vNPRY12DXI33tLBajksCNnOyMo0EJyZIzCYuO4UVisv2B0MBsFasdkhKRuijQoGnuBMi I9gDcjD+jnobbLd25d4cs1eE99GVq65Z6t34RD20nSW5TAp/HeBtT6w0zTqTSXS+IEzQ xRXBLn+yu5QO47Q/Ess2/PDMuPuIaWzyjCPnr2dlUgwvZKU/Z60TtWEUqLKHM0dlufO9 mW63Xoksn6Yalohna0GwyuWqGbbxcZOsgzeqFcLUwPObTbEVH24q5ispafu4s/ZZ8E++ 9BxA== X-Gm-Message-State: AOAM533AJHjrkNNofKCuWDW71WuNaFhADlDIj7zrnfUZK3KVBfU4UE4k YQYEGyStBiRNqOWM8qW2H0iZ7csS3nftJZ/v1iI= X-Google-Smtp-Source: ABdhPJzMhUanTtO0xcGlsrz+wza9W2y0hecPiKVERxEeWTBmr6zGvuMT0My3+KsJfLh30+KPHOtFA7JSGRaAzl0AOQ4= X-Received: by 2002:a17:907:3f09:: with SMTP id hq9mr6712554ejc.32.1644501451878; Thu, 10 Feb 2022 05:57:31 -0800 (PST) MIME-Version: 1.0 References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.7.Id5595981cd99201c6a2d8b714254d775436a3483@changeid> <20220209123219.GZ7515@bill-the-cat> In-Reply-To: From: Adam Ford Date: Thu, 10 Feb 2022 07:57:20 -0600 Message-ID: Subject: Re: [PATCH v3 07/18] pxe: Move pxe_utils files To: Simon Glass Cc: Tom Rini , U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, Feb 10, 2022 at 7:56 AM Adam Ford wrote: > > On Wed, Feb 9, 2022 at 11:16 AM Simon Glass wrote: > > > > Hi, > > > > On Wed, 9 Feb 2022 at 05:32, Tom Rini wrote: > > > > > > On Wed, Feb 09, 2022 at 05:40:03AM -0600, Adam Ford wrote: > > > > On Thu, Oct 14, 2021 at 1:50 PM Simon Glass wrot= e: > > > > > > > > > > Move the header file into the main include/ directory so we can u= se it > > > > > from the bootmethod code. Move the C file into boot/ since it rel= ates to > > > > > booting. > > > > > > > > > +cc lokeshvutla@ti.com > > > > > > > > Simon, > > > > > > > > I can't explain why, but with git bisect, it appears this patch bre= aks > > > > my omap3_logic board (DM3730) by making it wrongly think there is 4= GB > > > > of RAM, when in reality there is only 256MB. We have both 256MB an= d > > > > 512MB parts, and the automatic memory detection has always 'just > > > > worked' in the past. > > > > > > > > With this patch now, I see: > > > > U-Boot 2022.01-rc1-00185-g262cfb5b15 (Feb 09 2022 - 05:23:42 -0600) > > > > > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > > > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > > > DRAM: 4 GiB > > > > > > > > > > > > With the previous commit, 8018b9af57b5 ("pxe: Tidy up the is_pxe > > > > global"), it properly detects the RAM and fully boots. > > > > > > > > U-Boot 2022.01-rc1-00184-g8018b9af57 (Feb 09 2022 - 05:21:39 -0600) > > > > > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > > > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > > > DRAM: 256 MiB > > > > NAND: 512 MiB > > > > MMC: OMAP SD/MMC: 0 > > > > Loading Environment from NAND... OK > > > > OMAP die ID: 619e00029ff800000168300f1502501f > > > > Net: eth0: ethernet@08000000 > > > > Hit any key to stop autoboot: 0 > > > > OMAP Logic # > > > > > > > > I have CONFIG_CMD_BOOTM, CONFIG_CMD_PXE and CONFIG_CMD_SYSBOOT all > > > > defined, so I am having a hard time understanding why this would > > > > change behavior or stomp on the the structure that knows the memory > > > > size. > > > > > > > > If I jump ahead to the current 'master' 531c0089457:("Merge branch > > > > '2022-02-08-TI-platform-updates') and revert this patch, my board > > > > boots correctly again, but I am struggling to understand why. > + Marek Beh=C3=BAn > > > > > > > > > Do you have any suggestions for me to try? > > > > > > I would suggest objdump disassemble U-Boot before/after and see what > > > functions have changed. > > > > Keep an eye out for a BSS variable that is used before relocation, perh= aps? > > I am still investigating, but disabling LTO appears to fix the issue > for me. I'd like to keep LTO, so I'm going to attempt to focus on the > differences in the affected functions and how this patch makes LTO > behave differently. > > The disassembly of U-Boot is large, so it's going to take me a bit of > time to investigate. If someone has any LTO-related suggestions that > I could try, I'd be open to try them too. > > adam > > > > Regards, > > Simon