From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CFACC433EF for ; Wed, 2 Mar 2022 01:58:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2081083BEE; Wed, 2 Mar 2022 02:58:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QPYxjzwP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BC1A483BF8; Wed, 2 Mar 2022 02:58:15 +0100 (CET) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4AE3681D5A for ; Wed, 2 Mar 2022 02:58:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-ej1-x634.google.com with SMTP id a8so622084ejc.8 for ; Tue, 01 Mar 2022 17:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WE92WiyD4zuurqOcxZu9dUAtcS9LAeMISeBM/43GiOg=; b=QPYxjzwPDoB7k0EhBYlpMWHF0Xf9vqJMAEsCjXqAPsjY2bGV/f6M9ySN/KlAxoclE9 R8zgsidQAd3N8YjAwVjp4ktlIejmvDk582K+FWWlNsVuZTM3lk3PpG+V9TRcVUu2jLQ8 2fUvy3+bzZynhNnVzr8fI4QPIxe+Tw8HF2RjlG69WA3CJ0rzubl5To88H1X04Lbfo36+ c4yGqbi+CzzXvjsqRjIv4vH+NMi4ycGHRi2kRGxH5Ek9SZLsO4mVPy7VZiMW1BlApnmY Eo24EfcFq+zqHVFVdHyj2N7u4724eeqmPZAuYeiyrHtpJl6Sqo9ROiS2LOOSV+lO4mKi i6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WE92WiyD4zuurqOcxZu9dUAtcS9LAeMISeBM/43GiOg=; b=fhYlvMNHACyYD5o3Z/BOsiVbleXxbsOUWiCfpGz96XL6uZ4JdD6Z24i7buGjLSii5M XYLvxLz5r366XZ+M+0qAbXOcWxxpgsYfgX1EcFq6NdLvHW7la3JgAw+FsJa3Q0IeUwFP sXmIIgD+Msna/Z7OV6cUgg8PRO/tPputpvmhnJ4D63mnxkgYwi426hNARDkglwFe7o5v EZf/IRChcXhqd+/UyKc2WIU3neecw/2mbE3ykPkVzkJeToWxY3Cl9IMFamV0b5uLbQWY JsS282lu62UUbypdPAf5h9N9cLSjKrjrtMHRGzjZxRXKa8KfC6NiUvIOx60zadgUZ7il g3LA== X-Gm-Message-State: AOAM533d/86hdYKY9YBjSMcqUdehlgrNq8CBgkuBOBSpPVb63Cwk3vz6 HyoopjsAyS00geia22b7KyvPBh297oNyma8YkElE276yFGo= X-Google-Smtp-Source: ABdhPJyZ9Jm/BWwzZEOcmWypzyFC8LsCXOgn6+VsyV3PZWMA+sWwZld6+qBL6F9Cm636T99EVgfkYFpG4nK7xO82GB4= X-Received: by 2002:a17:907:7b9f:b0:6d7:a24:8cbd with SMTP id ne31-20020a1709077b9f00b006d70a248cbdmr3349684ejc.588.1646186291554; Tue, 01 Mar 2022 17:58:11 -0800 (PST) MIME-Version: 1.0 References: <20220301201502.28026-1-tharvey@gateworks.com> <20220301201502.28026-2-tharvey@gateworks.com> In-Reply-To: From: Adam Ford Date: Tue, 1 Mar 2022 19:58:00 -0600 Message-ID: Subject: Re: [PATCH 1/2] net: fec: prevent undesired de-assertion of phy-reset on request To: Joe Hershberger Cc: Tim Harvey , u-boot , Ramon Fried , Sean Anderson Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Tue, Mar 1, 2022 at 2:38 PM Joe Hershberger wrote: > > On Tue, Mar 1, 2022 at 2:15 PM Tim Harvey wrote: > > > > When gpio_request_by_name allocates a gpio output it by default will > > de-assert the gpio which for phy-reset will take the PHY out of reset. > > As this occurs before fec_gpio_reset is called to assert the reset > > line it can cause undesired affects if reset timings are not properly > > met. > > > > Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active > > (reset asserted) to avoid this. > > > > Cc: Sean Anderson > > Signed-off-by: Tim Harvey > > Acked-by: Joe Hershberger Tested-by: Adam Ford #imx8mm-beacon