From: Adam Ford <aford173@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Adam Ford-BE <aford@beaconembedded.com>,
Rob Herring <robh+dt@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH V4] dt-bindings: soc: imx: Add binding doc for spba bus
Date: Thu, 12 Nov 2020 06:44:16 -0500 [thread overview]
Message-ID: <CAHCN7x+w3wpELWHVSd1-U38N+4TEDKWDRxzXEtDX2svkrTGJCw@mail.gmail.com> (raw)
In-Reply-To: <20201111191809.GA1859246@bogus>
On Wed, Nov 11, 2020 at 2:18 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, 11 Nov 2020 09:25:23 -0600, Adam Ford wrote:
> > Add binding doc for fsl,spba-bus.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > make dt_binding_check showed no errors if I did this right.
> >
> > V4: Remove an accidental makefile change
> > Move type:object under additional properties
> >
> > V3: Rebase sample from aips-bus example
> > Split off from series adding i.MX8M Nano functions to reduce noise
> >
> > V2: Attempted to update yaml from feedback
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml: bus@30000000: reg: [[805306368, 1048576]] is not of type 'object'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml
>
Rob,
Can you give me a pointer on what this message is saying? I don't
undertsand the YAML language, and I cannot get my machine to generate
the same messages you're seeing.
>
> See https://patchwork.ozlabs.org/patch/1398351
>
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
I have installed yamllint, and I have run the above line, but when I
run make dt_binding_check it fails to finish script even before I add
this new binding. If I revert the Makefile back to before the
implementation of yamllint, it works, but doesn't show the error.
When I restore the Makefile, it runs but it doesn't show the error.
Once I do a make clean, and run the dt_binding_check again, it fails
to finish with the following error
make[1]: *** [Documentation/devicetree/bindings/Makefile:59:
Documentation/devicetree/bindings/processed-schema-examples.json]
Error 123
It appears as if the processed-schema-examples.json is not generated at all.
When I revert back to the older makefile, it appears that file is
generated, but when I restore the makefile to the current version and
run it again, it doesn't show the dtschema warnings/errors you see.
I am guessing it's because the processed-schema-examples.json isn't
being generated correctly after I run make clean.
Do you have any ideas what might be missing from my build machine?
adam
>
> Please check and re-submit.
>
next prev parent reply other threads:[~2020-11-12 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 15:25 [PATCH V4] dt-bindings: soc: imx: Add binding doc for spba bus Adam Ford
2020-11-11 19:18 ` Rob Herring
2020-11-12 11:44 ` Adam Ford [this message]
2020-11-12 13:52 ` Rob Herring
2020-11-18 12:13 ` Adam Ford
2020-11-18 14:58 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHCN7x+w3wpELWHVSd1-U38N+4TEDKWDRxzXEtDX2svkrTGJCw@mail.gmail.com \
--to=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.