From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ACAAC433EF for ; Fri, 19 Nov 2021 12:53:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2648061279 for ; Fri, 19 Nov 2021 12:53:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2648061279 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 20FA281294; Fri, 19 Nov 2021 13:53:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oA2BJ947"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7C27782A68; Fri, 19 Nov 2021 13:53:19 +0100 (CET) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 520CC8128A for ; Fri, 19 Nov 2021 13:53:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-ed1-x530.google.com with SMTP id l25so25852945eda.11 for ; Fri, 19 Nov 2021 04:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0ge3Hyuu24I/jceT32ORAmI8bRya8uSoXMMhSprFCv4=; b=oA2BJ947E8qlbuhmg1d5YyCaCCoU9mYHbN+aNUfJhlQpghfbXYubzeFNgIw9rB5jkX z1jQZmX4y8FyesAJZoX26Ji/23Uxgzt0FO6ScfMYOZiLyJUo2gYMJwoPTospF87/6ZaH zX/p9BvqEPVdf34UZL4MZi1qjOJJmJf4v9//Elx+lNsncUK54yu7g8qSTIeB+ytjhPfI U7NYCuULO+IYtOXEtj5TP9yAgazGrxbj0rT/jHmSjVFQHMrtHBz3+nENKX+Fu4jw3eLn C0p01LqDao6YxL5Lp6a31v4fXhvpkxbQYBZZnWMPIJc3Ao29cP12Mn+pURjXTAjmRjI8 CERg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0ge3Hyuu24I/jceT32ORAmI8bRya8uSoXMMhSprFCv4=; b=OrORiTTLnxKgZ2YSUf19oVQsOe81L6FeWmIiCTwTT4xRD77HkkYVu+KfLFBRc9J8x8 zTTgZE1N6eXOWMFmpO/oAUJoKnKtLr0pC43HABX8EVqbaHXKPEqyEv5N/OJAVa7yndpJ hBWhLS75EY+76x/mJGUrwRCKKUdS3qLcnO3oGHVFbb7pGlayNv/wG6CAQ4rHRaPRMKw3 vz9DU9LhHM2hLQHkPK+asXQOEKv2wyv/eRyl99q/4Vb4zgiegD428+aX2Phe95G3nU5J L6/aVAsII8nJQbrG8G9JrQdsJyBoR5UMU6HGzy/vRSM1Z85BoZlweIlguUHL5HsB0XjK Q/1g== X-Gm-Message-State: AOAM530akJGUQPeDC3fzlKZ4gDoZe2w+pwGsUTtOROa6pIg1/oxKgSBz WIpk6rkSXugxz4OdLTuVsurLY9i2MiDub5gDZzw= X-Google-Smtp-Source: ABdhPJyu4fP9+2qsI15vNTqgyHe0oisSMkZ7C9XJxV0+aDlLPl2oxJAgA00pbBZQd1xgJatBzki/i8bR65lUBa2G0Fs= X-Received: by 2002:a17:906:79c3:: with SMTP id m3mr7388627ejo.332.1637326388376; Fri, 19 Nov 2021 04:53:08 -0800 (PST) MIME-Version: 1.0 References: <20210910201922.263481-1-aford173@gmail.com> <20211118211208.GZ24579@bill-the-cat> <20211118213056.GA24579@bill-the-cat> In-Reply-To: <20211118213056.GA24579@bill-the-cat> From: Adam Ford Date: Fri, 19 Nov 2021 06:52:57 -0600 Message-ID: Subject: Re: [PATCH] imx8mn_beacon: Fix booting hang and switch to binman To: Tom Rini Cc: "Peng Fan (OSS)" , "u-boot@lists.denx.de" , "sbabic@denx.de" , "festevam@gmail.com" , dl-uboot-imx , Peng Fan , "aford@beaconembedded.com" Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Nov 18, 2021 at 3:30 PM Tom Rini wrote: > > On Thu, Nov 18, 2021 at 03:26:40PM -0600, Adam Ford wrote: > > On Thu, Nov 18, 2021 at 3:12 PM Tom Rini wrote: > > > > > > On Wed, Nov 17, 2021 at 08:08:10AM -0600, Adam Ford wrote: > > > > > > > On Fri, Oct 22, 2021 at 2:36 PM Adam Ford wrote: > > > > > > > > > > On Wed, Sep 29, 2021 at 8:26 AM Adam Ford wrote: > > > > > > > > > > > > On Thu, Sep 23, 2021 at 3:03 PM Adam Ford wrote: > > > > > > > > > > > > > > On Tue, Sep 14, 2021 at 9:49 PM Peng Fan (OSS) wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +Tom Rini > > > > > > > > > > > > On 2021/9/11 4:19, Adam Ford wrote: > > > > > > > > > Somewhere along the line, the board stopped being able to boot. > > > > > > > > > Rather than just fixing the issue, let's fix the issue and migrate > > > > > > > > > to binman to eliminate a warning when using custom imx tools for > > > > > > > > > generating the binary. > > > > > > > > > > > > > > > > > > > > > > > Any chance this can make it into 2021.10? it's currently broken, and > > > > > > > this seems to fix the problem. i didn't bisect to see where the issue > > > > > > > broke, or i would have added a fixes tag. > > > > > > > > > > > > Stefano or Tom? could someone comment and/or merge? the board is > > > > > > currently not booting, and this fixes the issue > > > > > > > > > > It's been over a month, and we missed the 2021.10 release. Is there > > > > > something stopping this from being applied? > > > > > > > > Tom, > > > > > > > > Is there any chance you can apply this? I can't get anyone to respond > > > > to me, and it's been over 2 months since the initial submission. > > > > > > > > thanks, > > > > > > > > adam > > > > > > > > > > adam > > > > > > > > > > > > > > adam > > > > > > > > > Signed-off-by: Adam Ford > > > > > > > > > > > > > > > > > > diff --git a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi > > > > > > > > > index bbc64a2819..69fd69c8d0 100644 > > > > > > > > > --- a/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi > > > > > > > > > +++ b/arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi > > > > > > > > > @@ -4,6 +4,10 @@ > > > > > > > > > */ > > > > > > > > > > > > > > > > > > / { > > > > > > > > > + binman: binman { > > > > > > > > > + multiple-images; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > wdt-reboot { > > > > > > > > > compatible = "wdt-reboot"; > > > > > > > > > wdt = <&wdog1>; > > > > > > > > > @@ -40,6 +44,9 @@ > > > > > > > > > &clk { > > > > > > > > > u-boot,dm-spl; > > > > > > > > > u-boot,dm-pre-reloc; > > > > > > > > > + /delete-property/ assigned-clocks; > > > > > > > > > + /delete-property/ assigned-clock-parents; > > > > > > > > > + /delete-property/ assigned-clock-rates; > > > > > > > > > }; > > > > > > > > > > > > > > > > > > &gpio1 { > > > > > > > > > @@ -99,6 +106,10 @@ > > > > > > > > > u-boot,off-on-delay-us = <20000>; > > > > > > > > > }; > > > > > > > > > > > > > > > > > > +&uart2 { > > > > > > > > > + u-boot,dm-spl; > > > > > > > > > +}; > > > > > > > > > + > > > > > > > > > &usdhc1 { > > > > > > > > > u-boot,dm-spl; > > > > > > > > > sd-uhs-sdr104; > > > > > > > > > @@ -120,3 +131,122 @@ > > > > > > > > > &wdog1 { > > > > > > > > > u-boot,dm-spl; > > > > > > > > > }; > > > > > > > > > + > > > > > > > > > +&binman { > > > > > > > > > + u-boot-spl-ddr { > > > > > > > > > + filename = "u-boot-spl-ddr.bin"; > > > > > > > > > + pad-byte = <0xff>; > > > > > > > > > + align-size = <4>; > > > > > > > > > + align = <4>; > > > > > > > > > + > > > > > > > > > + u-boot-spl { > > > > > > > > > + align-end = <4>; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + blob_1: blob-ext@1 { > > > > > > > > > + filename = "lpddr4_pmu_train_1d_imem.bin"; > > > > > > > > > + size = <0x8000>; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + blob_2: blob-ext@2 { > > > > > > > > > + filename = "lpddr4_pmu_train_1d_dmem.bin"; > > > > > > > > > + size = <0x4000>; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + blob_3: blob-ext@3 { > > > > > > > > > + filename = "lpddr4_pmu_train_2d_imem.bin"; > > > > > > > > > + size = <0x8000>; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + blob_4: blob-ext@4 { > > > > > > > > > + filename = "lpddr4_pmu_train_2d_dmem.bin"; > > > > > > > > > + size = <0x4000>; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + > > > > > > > > > + spl { > > > > > > > > > + filename = "spl.bin"; > > > > > > > > > + > > > > > > > > > + mkimage { > > > > > > > > > + args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000"; > > > > > > > > > + > > > > > > > > > + blob { > > > > > > > > > + filename = "u-boot-spl-ddr.bin"; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + itb { > > > > > > > > > + filename = "u-boot.itb"; > > > > > > > > > + > > > > > > > > > + fit { > > > > > > > > > + description = "Configuration to load ATF before U-Boot"; > > > > > > > > > + #address-cells = <1>; > > > > > > > > > + fit,external-offset = ; > > > > > > > > > + > > > > > > > > > + images { > > > > > > > > > + uboot { > > > > > > > > > + description = "U-Boot (64-bit)"; > > > > > > > > > + type = "standalone"; > > > > > > > > > + arch = "arm64"; > > > > > > > > > + compression = "none"; > > > > > > > > > + load = ; > > > > > > > > > + > > > > > > > > > + uboot_blob: blob-ext { > > > > > > > > > + filename = "u-boot-nodtb.bin"; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + atf { > > > > > > > > > + description = "ARM Trusted Firmware"; > > > > > > > > > + type = "firmware"; > > > > > > > > > + arch = "arm64"; > > > > > > > > > + compression = "none"; > > > > > > > > > + load = <0x960000>; > > > > > > > > > + entry = <0x960000>; > > > > > > > > > + > > > > > > > > > + atf_blob: blob-ext { > > > > > > > > > + filename = "bl31.bin"; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + fdt { > > > > > > > > > + description = "NAME"; > > > > > > > > > + type = "flat_dt"; > > > > > > > > > + compression = "none"; > > > > > > > > > + > > > > > > > > > + uboot_fdt_blob: blob-ext { > > > > > > > > > + filename = "u-boot.dtb"; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + configurations { > > > > > > > > > + default = "conf"; > > > > > > > > > + > > > > > > > > > + conf { > > > > > > > > > + description = "NAME"; > > > > > > > > > + firmware = "uboot"; > > > > > > > > > + loadables = "atf"; > > > > > > > > > + fdt = "fdt"; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + imx-boot { > > > > > > > > > + filename = "flash.bin"; > > > > > > > > > + pad-byte = <0x00>; > > > > > > > > > + > > > > > > > > > + spl: blob-ext@1 { > > > > > > > > > + offset = <0x0>; > > > > > > > > > + filename = "spl.bin"; > > > > > > > > > + }; > > > > > > > > > + > > > > > > > > > + uboot: blob-ext@2 { > > > > > > > > > + offset = <0x58000>; > > > > > > > > > + filename = "u-boot.itb"; > > > > > > > > > + }; > > > > > > > > > + }; > > > > > > > > > +}; > > > > > > > > > diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig > > > > > > > > > index 8fedf45987..9a1eb108e4 100644 > > > > > > > > > --- a/arch/arm/mach-imx/imx8m/Kconfig > > > > > > > > > +++ b/arch/arm/mach-imx/imx8m/Kconfig > > > > > > > > > @@ -116,6 +116,7 @@ config TARGET_IMX8MM_BEACON > > > > > > > > > > > > > > > > > > config TARGET_IMX8MN_BEACON > > > > > > > > > bool "imx8mn Beacon Embedded devkit" > > > > > > > > > + select BINMAN > > > > > > > > > select IMX8MN > > > > > > > > > select SUPPORT_SPL > > > > > > > > > select IMX8M_LPDDR4 > > > > > > > > > diff --git a/board/beacon/imx8mn/imximage-8mn-lpddr4.cfg b/board/beacon/imx8mn/imximage-8mn-lpddr4.cfg > > > > > > > > > new file mode 100644 > > > > > > > > > index 0000000000..7286b26494 > > > > > > > > > --- /dev/null > > > > > > > > > +++ b/board/beacon/imx8mn/imximage-8mn-lpddr4.cfg > > > > > > > > > @@ -0,0 +1,10 @@ > > > > > > > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > > > > > > +/* > > > > > > > > > + * Copyright 2021 NXP > > > > > > > > > + */ > > > > > > > > > + > > > > > > > > > +#define __ASSEMBLY__ > > > > > > > > > + > > > > > > > > > +ROM_VERSION v2 > > > > > > > > > +BOOT_FROM sd > > > > > > > > > +LOADER u-boot-spl-ddr.bin 0x912000 > > > > > > > > > diff --git a/configs/imx8mn_beacon_defconfig b/configs/imx8mn_beacon_defconfig > > > > > > > > > index 5296204aad..f2515874a2 100644 > > > > > > > > > --- a/configs/imx8mn_beacon_defconfig > > > > > > > > > +++ b/configs/imx8mn_beacon_defconfig > > > > > > > > > @@ -26,9 +26,9 @@ CONFIG_LTO=y > > > > > > > > > CONFIG_FIT=y > > > > > > > > > CONFIG_FIT_EXTERNAL_OFFSET=0x3000 > > > > > > > > > CONFIG_SPL_LOAD_FIT=y > > > > > > > > > -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" > > > > > > > > > +# CONFIG_USE_SPL_FIT_GENERATOR is not set > > > > > > > > > CONFIG_OF_SYSTEM_SETUP=y > > > > > > > > > -CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/imx8m/imximage-8mn-lpddr4.cfg" > > > > > > > > > +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/beacon/imx8mn/imximage-8mn-lpddr4.cfg" > > > > > > > > > CONFIG_DEFAULT_FDT_FILE="imx8mn-beacon-kit.dtb" > > > > > > > > > CONFIG_ARCH_MISC_INIT=y > > > > > > > > > CONFIG_SPL_BOARD_INIT=y > > > > > > > > > @@ -36,6 +36,7 @@ CONFIG_SPL_BOOTROM_SUPPORT=y > > > > > > > > > CONFIG_SPL_SEPARATE_BSS=y > > > > > > > > > CONFIG_SPL_I2C=y > > > > > > > > > CONFIG_SPL_POWER=y > > > > > > > > > +CONFIG_SPL_WATCHDOG=y > > > > > > > > > CONFIG_HUSH_PARSER=y > > > > > > > > > CONFIG_SYS_PROMPT="u-boot=> " > > > > > > > > > # CONFIG_BOOTM_NETBSD is not set > > > > > > > > > @@ -62,7 +63,6 @@ CONFIG_CMD_EXT4_WRITE=y > > > > > > > > > CONFIG_CMD_FAT=y > > > > > > > > > CONFIG_OF_CONTROL=y > > > > > > > > > CONFIG_SPL_OF_CONTROL=y > > > > > > > > > -CONFIG_OF_SPL_REMOVE_PROPS="interrupt-parent interrupts" > > > > > > > > > CONFIG_ENV_IS_IN_MMC=y > > > > > > > > > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > > > > > > > > > CONFIG_SYS_MMC_ENV_DEV=2 > > > > > > > > > @@ -106,6 +106,7 @@ CONFIG_PHY_GIGE=y > > > > > > > > > CONFIG_FEC_MXC=y > > > > > > > > > CONFIG_MII=y > > > > > > > > > CONFIG_PINCTRL=y > > > > > > > > > +CONFIG_SPL_PINCTRL=y > > > > > > > > > CONFIG_PINCTRL_IMX8M=y > > > > > > > > > CONFIG_DM_PMIC=y > > > > > > > > > # CONFIG_SPL_PMIC_CHILDREN is not set > > > > > > > > > @@ -122,7 +123,9 @@ CONFIG_SPI=y > > > > > > > > > CONFIG_DM_SPI=y > > > > > > > > > CONFIG_NXP_FSPI=y > > > > > > > > > CONFIG_SYSRESET=y > > > > > > > > > +CONFIG_SPL_SYSRESET=y > > > > > > > > > CONFIG_SYSRESET_PSCI=y > > > > > > > > > +CONFIG_SYSRESET_WATCHDOG=y > > > > > > > > > CONFIG_DM_THERMAL=y > > > > > > > > > CONFIG_USB=y > > > > > > > > > # CONFIG_SPL_DM_USB is not set > > > > > > > > > @@ -134,3 +137,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > > > > > > > > > CONFIG_CI_UDC=y > > > > > > > > > CONFIG_SDP_LOADADDR=0x0 > > > > > > > > > CONFIG_OF_LIBFDT_OVERLAY=y > > > > > > > > > +CONFIG_IMX_WATCHDOG=y > > > > > > > > > > > > > > > > > > > > > > > > > Reviewed-by: Peng Fan > > > > > > This introduces failure to build now: > > > https://source.denx.de/u-boot/u-boot/-/jobs/352491 > > > > This goes to another discussion [1] because the binman requires some > > file outside of U-Boot in order to create the binary. > > If we could let the CI build with missing files, that would be helpful. > > > > [1] - https://lore.kernel.org/all/20211109194224.GB24579@bill-the-cat/ > > Oh this fun.. :( Does that mean I should find a solution without binman? > > -- > Tom