From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16710C433ED for ; Tue, 11 May 2021 14:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D765061396 for ; Tue, 11 May 2021 14:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231826AbhEKOt7 (ORCPT ); Tue, 11 May 2021 10:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbhEKOt6 (ORCPT ); Tue, 11 May 2021 10:49:58 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCDB3C061574; Tue, 11 May 2021 07:48:50 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id j26so19538174edf.9; Tue, 11 May 2021 07:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EnXg6Kh16FhklatDAvmNh/kvk7jA2VwWCKHJwBrPgEI=; b=KjBr6w4Svz3OfDzOH34kdTnM4yU4Tuh/vR+P/XX7L+oBcwVUto0HT4Xh0YYpjQDVsh rSADgtm6apdD9p1FwJ1uGRmh5Fl6jJMaLi/xQFQLVLgMNP4W40AIq6n30DnixAzmbtgH gxmmd8vwtEx0A396fOrXJ+BNxuMnuTUg+hOy/skPgLnGmf3QmXMsYMY2wPiR1+DLDVPJ ZspkCtDVCxti+//8LJih7IWM+bM0KB7eHFLwlzI5EPmcdfeRZbZR74nwNv39/tNbQlFw /oVhPn6FfetXSgnne2e2ufpjWR00bZO9SQmWayOeyRN9pX8D8pfPHyyGrwUPV5Y2LoW4 4+4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EnXg6Kh16FhklatDAvmNh/kvk7jA2VwWCKHJwBrPgEI=; b=fXh54plrdieZitG1DmL+GaAQo+KEkL/LFGaDdczzARYhyLLKVLX1o8piiVk4k3TLgK f3pgkUVyU4wDCubnfSy9gDqAp6/BwYFP8hj0m6HcORzpQuzKi167QhV6E1lFe2GvkCX1 lglwcQ/AKpxYtqrYbyl9Bl9DurL1gD2h8L94xAIk6bc1sD8HJiI2ksrJKD6WwMARyFUD HVYAt2PQBFcRLLCAmqDyR3zeDDGIL5IiGQBqpXT/3o587BNDYgl6C11Jssw8cInA6gzk A6Y+AUU7rx+Fw6590Scip1z0G/L5l77evET6RlMgF7uHboEpVJKH2uPir0DdxGSWJ43B Bf7w== X-Gm-Message-State: AOAM5335NXGxOc4dTYj6+dl/pwr8/+EzT9NOSDibFPnpbN+n2kMVuGad xMj77MehCvnBa0xef0L+FxqXDtHa3F8TOkqfQEU= X-Google-Smtp-Source: ABdhPJzQFyLz4ZFpSUNk38OWbNw2oSVem0pBtecySCljHXX+NjBW06/tp7bhL/h4Rqn+kDO2lkA1VKhl3Fp6Hd8G4iw= X-Received: by 2002:a05:6402:310a:: with SMTP id dc10mr36794847edb.38.1620744529500; Tue, 11 May 2021 07:48:49 -0700 (PDT) MIME-Version: 1.0 References: <20210406013344.124255-1-aford173@gmail.com> <20210511024604.GE3425@dragon> In-Reply-To: From: Adam Ford Date: Tue, 11 May 2021 09:48:38 -0500 Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: imx8mn: Add spba1 bus To: Robin Gong Cc: Shawn Guo , arm-soc , Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2021 at 7:20 AM Robin Gong wrote: > > On 2021/05/11 18:45 Adam Ford wrote: > > > Also may I ask if you have a real use case for this bus node? > > > > The reference manual shows the SPBA bus tells the DMA controller which > > peripherals are associated with it. Nearly all the i.MX boards use this. The > > boards I support have Bluetooth devices connected to a UART running high > > speeds, and if the DMA driver isn't loaded, I can see a performance change. > Compare PIO with DMA on UART, but not w/o this 'spba bus node ' patch? > > > In fact, if the DMA firmware isn't loaded, I often get transfer errors. > UART use SDMA ROM firmware instead of RAM firmware, so it should work > even without sdma RAM firmware loaded. Still curious what really happen in > your board without this patch. What I am seeing is that at times, the HCI UART loading before the DMA firmware is loaded. [ 10.582037] Bluetooth: HCI UART driver ver 2.3 [ 10.586867] Bluetooth: HCI UART protocol H4 registered [ 10.593566] imx-sdma 30bd0000.dma-controller: sdma firmware not ready! [ 10.594548] Bluetooth: HCI UART protocol Broadcom registered [ 10.600108] imx-uart 30860000.serial: We cannot prepare for the RX slave dma! When I get the above message, the bluetooth chip I have throws timeouts and does not function. [ 10.615090] imx-sdma 302c0000.dma-controller: loaded firmware 4.5 Once the firmware is loaded, I can unload the HCI Uart driver and re-load Bluetooth works again. Based on that, I've been having my system delay the loading of the Bluetooth modules until after the firmware is loaded, but this tells me there is a relationship between the DMA and UART. adam > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF49DC433B4 for ; Tue, 11 May 2021 14:51:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EB2E613C1 for ; Tue, 11 May 2021 14:51:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EB2E613C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qyam4Prgwp7Nfqzkg0rfV0ibttFBKlHVlNYq6U3IX0Q=; b=UmX2gM8v32P+T8JqEN1cCevAU LmL+Qjd0CwPqTuW2xVctIVZLzZIwsde1M/xhZmFAYyUCHsFwy48l+sOTs/O8wA/+egVrRNxwhhgRA PCQ1r44Yt2Z53QkOlZkewCtj8orr/AvhDJgVErnJeEA8hhw+QhoRTE9zU+yeuMQ97CfQ43y9nkm1R eIzkaTjJSGepcZF0+HxCugNB7XKSj8XgEwMdTiAtQZSjJvqTU8m5LfLu3u4sirpIyqQM4DDIDBNaq xval1G3BTezhNqiaI5iMfMIUy2fHtufJlADZ/eKvwc76Z4RATEDHIcz5mq4CdC/L1HNkN6PtLJCMJ 4trbRempQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgThB-000VPw-Sr; Tue, 11 May 2021 14:49:14 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgTgt-000VKd-1F for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 14:48:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EnXg6Kh16FhklatDAvmNh/kvk7jA2VwWCKHJwBrPgEI=; b=vPObvxzEJ+7Iosj7R3sixxD8SM PvAReyKwJo37liRXULGRweHc85z8Zt1SjduoydNoR2maNebc4F9WQZxI/mMVxp5EL6lIoMlkMtpNm hNzKd3NaXXz2OvtUMZsHOsvsj0gxkGfWaE/E7QU+wegZ3CsxpcQyTCiigLVKSFi8webTMQGwWio+J hgl4WvhqJHjROcD5QHWUgim/K219d98Q/q0BciAsTg5lrU4h49OCs+oEFc+3rC+BYIVV1RT2w+lOV Nx/Z6jB1FCBN+wIWlAj0aL1a7vs2DFrFvMjSHoPasZn1VkEna/GxWtQ0FVBcuc0CBeSqus3YGba0t f6gUHWxg==; Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgTgp-009goF-Ff for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 14:48:53 +0000 Received: by mail-ed1-x52b.google.com with SMTP id j19so833115edr.12 for ; Tue, 11 May 2021 07:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EnXg6Kh16FhklatDAvmNh/kvk7jA2VwWCKHJwBrPgEI=; b=KjBr6w4Svz3OfDzOH34kdTnM4yU4Tuh/vR+P/XX7L+oBcwVUto0HT4Xh0YYpjQDVsh rSADgtm6apdD9p1FwJ1uGRmh5Fl6jJMaLi/xQFQLVLgMNP4W40AIq6n30DnixAzmbtgH gxmmd8vwtEx0A396fOrXJ+BNxuMnuTUg+hOy/skPgLnGmf3QmXMsYMY2wPiR1+DLDVPJ ZspkCtDVCxti+//8LJih7IWM+bM0KB7eHFLwlzI5EPmcdfeRZbZR74nwNv39/tNbQlFw /oVhPn6FfetXSgnne2e2ufpjWR00bZO9SQmWayOeyRN9pX8D8pfPHyyGrwUPV5Y2LoW4 4+4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EnXg6Kh16FhklatDAvmNh/kvk7jA2VwWCKHJwBrPgEI=; b=YcFpqYVTecpyQ9b2upmPMW5C0yAGgPyQJibm2++Jo/VG0gn78r1Gein4CZTblbaaqB E44VqFu803iOboJSP3/mlRp4R0MaHHKaiE5wgv0HR+9VdZRy8ugBYKraKC2SM3Bw9L6N rrzKkW3etmvnibiL+daxCvxE+7i/214RToQWb1Sz0gSxB3/mlUlUkToCeW3fMBrsp+eP mLVJT7lKxCUfommWCfFTKCX2xc085M4La9ZScteb6FVyZNNHr9VYV+xdsVhTinOBdYMy 2kQC++Hka/SAse1m5bnhwAk6u84UtEZpGCvw95EAK5pRoHTRSbZJuqL2Kr92uGAxXrNu SNvg== X-Gm-Message-State: AOAM531g0IW38uiJEUrNsOMuMAzF/rwLLWrvU9qCJ7c97QsVMjfzGKQB 8dt5PtTsVxxDS5AM1K8EX6yynuG9hE4KfnIjaIw= X-Google-Smtp-Source: ABdhPJzQFyLz4ZFpSUNk38OWbNw2oSVem0pBtecySCljHXX+NjBW06/tp7bhL/h4Rqn+kDO2lkA1VKhl3Fp6Hd8G4iw= X-Received: by 2002:a05:6402:310a:: with SMTP id dc10mr36794847edb.38.1620744529500; Tue, 11 May 2021 07:48:49 -0700 (PDT) MIME-Version: 1.0 References: <20210406013344.124255-1-aford173@gmail.com> <20210511024604.GE3425@dragon> In-Reply-To: From: Adam Ford Date: Tue, 11 May 2021 09:48:38 -0500 Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: imx8mn: Add spba1 bus To: Robin Gong Cc: Shawn Guo , arm-soc , Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , devicetree , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_074851_563075_1CEE2FD6 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 11, 2021 at 7:20 AM Robin Gong wrote: > > On 2021/05/11 18:45 Adam Ford wrote: > > > Also may I ask if you have a real use case for this bus node? > > > > The reference manual shows the SPBA bus tells the DMA controller which > > peripherals are associated with it. Nearly all the i.MX boards use this. The > > boards I support have Bluetooth devices connected to a UART running high > > speeds, and if the DMA driver isn't loaded, I can see a performance change. > Compare PIO with DMA on UART, but not w/o this 'spba bus node ' patch? > > > In fact, if the DMA firmware isn't loaded, I often get transfer errors. > UART use SDMA ROM firmware instead of RAM firmware, so it should work > even without sdma RAM firmware loaded. Still curious what really happen in > your board without this patch. What I am seeing is that at times, the HCI UART loading before the DMA firmware is loaded. [ 10.582037] Bluetooth: HCI UART driver ver 2.3 [ 10.586867] Bluetooth: HCI UART protocol H4 registered [ 10.593566] imx-sdma 30bd0000.dma-controller: sdma firmware not ready! [ 10.594548] Bluetooth: HCI UART protocol Broadcom registered [ 10.600108] imx-uart 30860000.serial: We cannot prepare for the RX slave dma! When I get the above message, the bluetooth chip I have throws timeouts and does not function. [ 10.615090] imx-sdma 302c0000.dma-controller: loaded firmware 4.5 Once the firmware is loaded, I can unload the HCI Uart driver and re-load Bluetooth works again. Based on that, I've been having my system delay the loading of the Bluetooth modules until after the firmware is loaded, but this tells me there is a relationship between the DMA and UART. adam > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel