All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Ford <aford173@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/6] am33xx: Provide platform data for mmc
Date: Wed, 26 Apr 2017 06:56:03 -0500	[thread overview]
Message-ID: <CAHCN7xJJrqY2x4hwA-55+sBYqnU3KoevV_iFC+Lh3WYtMJ+Gag@mail.gmail.com> (raw)
In-Reply-To: <176e6a77-6707-0c7a-995e-c8819e8ef8f8@ti.com>

On Wed, Apr 26, 2017 at 6:13 AM, Lokesh Vutla <lokeshvutla@ti.com> wrote:
>
>
> On Wednesday 26 April 2017 04:41 PM, Adam Ford wrote:
>> On Wed, Apr 26, 2017 at 3:07 AM, Lokesh Vutla <lokeshvutla@ti.com> wrote:
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>> ---
>>> Changes since v1:
>>> - Update base addresses for MMC0 and MMC1
>>>  board/ti/am335x/board.c | 32 ++++++++++++++++++++++++++++++++
>>>  1 file changed, 32 insertions(+)
>>>
>>> diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c
>>> index 3e842d3187..6786229680 100644
>>> --- a/board/ti/am335x/board.c
>>> +++ b/board/ti/am335x/board.c
>>> @@ -9,6 +9,7 @@
>>>   */
>>>
>>>  #include <common.h>
>>> +#include <dm.h>
>>>  #include <errno.h>
>>>  #include <spl.h>
>>>  #include <serial.h>
>>> @@ -26,6 +27,7 @@
>>>  #include <asm/emif.h>
>>>  #include <asm/gpio.h>
>>>  #include <asm/omap_sec_common.h>
>>> +#include <asm/omap_mmc.h>
>>>  #include <i2c.h>
>>>  #include <miiphy.h>
>>>  #include <cpsw.h>
>>> @@ -892,3 +894,33 @@ void board_fit_image_post_process(void **p_image, size_t *p_size)
>>>         secure_boot_verify_image(p_image, p_size);
>>>  }
>>>  #endif
>>> +
>>> +#if !CONFIG_IS_ENABLED(OF_CONTROL)
>>> +static const struct omap_hsmmc_plat am335x_mmc0_platdata = {
>>> +       .base_addr = (struct hsmmc *)OMAP_HSMMC1_BASE,
>>> +       .cfg.host_caps = MMC_MODE_HS_52MHz | MMC_MODE_HS | MMC_MODE_4BIT,
>>> +       .cfg.f_min = 400000,
>>> +       .cfg.f_max = 52000000,
>>> +       .cfg.voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195,
>>> +       .cfg.b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT,
>>> +};
>>
>> Do you need to address the offset factor here if you're going to
>> rebase from my series?  My series removed the offset from struct hsmmc
>
> OMAP_HSMMC1_BASE includes the offset. This is currently being used in
> driver as well for non-DM cases.

Great!

thanks

>
> Thanks and regards,
> Lokesh
>

  reply	other threads:[~2017-04-26 11:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  8:07 [U-Boot] [PATCH v2 0/6] arm: am335x: Enable SPL_DM Lokesh Vutla
2017-04-26  8:07 ` [U-Boot] [PATCH v2 1/6] dm: mmc: omap_hsmmc: Update to support of-platdata Lokesh Vutla
2017-05-12 17:19   ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-04-26  8:07 ` [U-Boot] [PATCH v2 2/6] dm: mmc: omap_hsmmc: Add pre-reloc flag to the driver Lokesh Vutla
2017-05-12 17:19   ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-04-26  8:07 ` [U-Boot] [PATCH v2 3/6] configs: am335x_evm: Use omap2 generic spl load script Lokesh Vutla
2017-04-26 11:25   ` Tom Rini
2017-05-12 17:19   ` [U-Boot] [U-Boot, v2, " Tom Rini
2017-04-26  8:07 ` [U-Boot] [PATCH v2 4/6] am33xx: Provide platform data for mmc Lokesh Vutla
2017-04-26 11:11   ` Adam Ford
2017-04-26 11:13     ` Lokesh Vutla
2017-04-26 11:56       ` Adam Ford [this message]
2017-04-26 11:58   ` Tom Rini
2017-04-28 17:40     ` Adam Ford
2017-04-28 17:43       ` Tom Rini
2017-04-28 17:43         ` Adam Ford
2017-05-12 17:19   ` [U-Boot] [U-Boot,v2,4/6] " Tom Rini
2017-04-26  8:07 ` [U-Boot] [PATCH v2 5/6] configs: am335x_evm: Enable SPL_DM Lokesh Vutla
2017-05-12 17:19   ` [U-Boot] [U-Boot,v2,5/6] " Tom Rini
2017-04-26  8:07 ` [U-Boot] [PATCH v2 6/6] arm: am335x: Enable tiny printf in SPL Lokesh Vutla
2017-05-12 17:19   ` [U-Boot] [U-Boot, v2, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHCN7xJJrqY2x4hwA-55+sBYqnU3KoevV_iFC+Lh3WYtMJ+Gag@mail.gmail.com \
    --to=aford173@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.