From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05E5CC433F5 for ; Thu, 21 Apr 2022 11:15:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6738B839FD; Thu, 21 Apr 2022 13:15:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="X/8XxkO/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9AF86834BC; Thu, 21 Apr 2022 13:15:16 +0200 (CEST) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2775083BF4 for ; Thu, 21 Apr 2022 13:15:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-ej1-x62c.google.com with SMTP id bv19so9294286ejb.6 for ; Thu, 21 Apr 2022 04:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kz9YVx73FeuWyqCfNw5HKeOBqBNqpU+CxXcdPbhXgx0=; b=X/8XxkO/FQOxYP9162i4G+iHVPiI+f6QwFKF63dD+eb05qohsGEbvbdoCxw9UcDL8t pC6m1ehPKwKUsHRUjdnOYydH5+SPjhjK+blxOsz6hmZusEmFX58q21L3kn+aJHauxjvQ jtYCSstEx+2HW1+datkR+WhsaGpa7qOk+PbdKkrZ66AHjZCrM49xn+nS3usNULzGzyAD 8+fBVO/NJ83JWL0vKva3mpMhe/+Skql+hsvYjOjZN90rckWqWxWy3AdV0m9k98+jJGFm TbmTbVG897kxLT5RXF961iBSOiHdki06fvuBFfRvhEae4+tDuwPYjZxjfVwa6kpoL2Bm egrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kz9YVx73FeuWyqCfNw5HKeOBqBNqpU+CxXcdPbhXgx0=; b=23wEtXJPfC1ssi3EjizibFKNEvF24pk85hzWt/IZOQydgLuYHiUepNRKkeSv7k9WbS lBJvyH0Qpv8R1CnHKOfFWf6kO4wiasLULD8uNRXYpF4xaN8vySI+8mZqYI2XHBBNJs8X KLTrrmD4oNYFSw6b7Q5VJFALhP9N+D+tDLaKqeWgSfUdXouBbMHJ2b7u5l+ElF/KYLW7 3aDGCPKRXFsYhRl/Ocj+Ize1pOLTcH8LwyP76bxGkILSerjtR3dITrgoouotJWt2nbbu NYFZLjI9AXN9qoVYLXyfZSnthjV0ZNughvNhT9Pgfg/riGIOB7zMCIMbyJ36mBrLO02w mX0Q== X-Gm-Message-State: AOAM530OntStPY5ASYINzwFpovYTEH6NRNOk95HmepumaCKx1exO/o71 8vfFsoG330I0kXFkmk35z51+vvdqHjduKm/gy/0= X-Google-Smtp-Source: ABdhPJyfiged3Utxq+7TkEcY4q9209/dl+/2uswaJ7Voukm0KRhFO2S3WAT+InD7zSrsoYPTmamYGD0QcpfF2YVFBLA= X-Received: by 2002:a17:906:dc93:b0:6e8:8d81:b4bb with SMTP id cs19-20020a170906dc9300b006e88d81b4bbmr22576183ejc.32.1650539710342; Thu, 21 Apr 2022 04:15:10 -0700 (PDT) MIME-Version: 1.0 References: <20220421064805.GA2335@tom-ThinkPad-T14s-Gen-2i> <20220421102907.GC2335@tom-ThinkPad-T14s-Gen-2i> In-Reply-To: <20220421102907.GC2335@tom-ThinkPad-T14s-Gen-2i> From: Adam Ford Date: Thu, 21 Apr 2022 06:14:58 -0500 Message-ID: Subject: Re: imx8mm eLCDIF clock To: Tommaso Merciai Cc: U-Boot Mailing List , Lukasz Majewski , Sean Anderson , Fabio Estevam , Tim Harvey , Marek Vasut , Michael Trimarchi Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, Apr 21, 2022 at 5:29 AM Tommaso Merciai wrote: > > On Thu, Apr 21, 2022 at 08:48:05AM +0200, Tommaso Merciai wrote: > > + Fabio > + Tim > + Michael > + Marek > + Adam > > > Hi, > > I'm working on drivers/clk/imx/clk-imx8mm.c to port and bring up eLCDIF > > clocks. After port all necessary clocks needed by eLCDIF I found that > > IMX8MM_VIDEO_PLL1 clock is not enabled and need the clk_enable to enable > > it at the end of the clk-imx8mm probe: > > > > struct clk *clkp; > > > > clk_get_by_id(IMX8MM_VIDEO_PLL1, &clkp); > > clk_set_rate(clkp, 594000000UL); > > clk_enable(clkp); > > > > What do you think about this solution? > > There is a more standard way to do this? > > I'm missing somethings? I think the LCD driver should request the clock and clock rate based on settings the device tree. However, I think the bigger issues is that you might run into issues with the lack of a disp-blkctrl driver. Marek enable the GPC driver fairly recently, but the blkctrl driver will be needed to enable the LCD and DSI portions or the system may hang. adam > > > > Thanks, > > Tommmaso > > -- > > Tommaso Merciai > > Embedded Linux Engineer > > tommaso.merciai@amarulasolutions.com > > __________________________________ > > > > Amarula Solutions SRL > > Via Le Canevare 30, 31100 Treviso, Veneto, IT > > T. +39 042 243 5310 > > info@amarulasolutions.com > > www.amarulasolutions.com > > -- > Tommaso Merciai > Embedded Linux Engineer > tommaso.merciai@amarulasolutions.com > __________________________________ > > Amarula Solutions SRL > Via Le Canevare 30, 31100 Treviso, Veneto, IT > T. +39 042 243 5310 > info@amarulasolutions.com > www.amarulasolutions.com