From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 691B4C433DB for ; Tue, 5 Jan 2021 12:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 369FA20735 for ; Tue, 5 Jan 2021 12:54:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729629AbhAEMyH (ORCPT ); Tue, 5 Jan 2021 07:54:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728006AbhAEMyG (ORCPT ); Tue, 5 Jan 2021 07:54:06 -0500 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99EBDC061574; Tue, 5 Jan 2021 04:53:26 -0800 (PST) Received: by mail-io1-xd2c.google.com with SMTP id q137so28044171iod.9; Tue, 05 Jan 2021 04:53:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K79eXZC/Zmmt2A7zkyWNbssvWSflnyrmEKHoezkqZ24=; b=TjRq6EUrmxaMZI2yT57rLdCc+HPWMANWnsF5tA119UKg8fel0rlvaXSK/62AOFRUo/ gNqA/oPjVsKYaubGPBNVzMUBZT7RWnkPGn97v/SDVqJ2mDjVQcj2O12j9CHsDIJRRKO6 cdvKm3JzMIACMJbraIqGfqI1jhDwohAGZu49HFeOaBZUslnz7G1BmwCp0IasQL3AjLB0 vQrkQ2VXJFjk1ZyZVumXvEOJC7lVC8Y8Mkk7OPsw3qDqs7M5UuRke/etX1m2jkidDX9j eeyp345mB6gQYeBaMF1WdVzp9UMfgeGd81vPE5CMsC21GxQ8IzoprFlhAJAXsWPnKJi3 DNYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K79eXZC/Zmmt2A7zkyWNbssvWSflnyrmEKHoezkqZ24=; b=DTl6C9N7C/mM3DT6k7GltFQEpkL4vF0+c5k2nFiJ/dTfsIbSM606Ylb5o6lwuAzZGd ojxuWHO5qFWTl5c0kyw7zX3kiaOvEq8iH93FdLRysWmm0g8HiGna6Fs3U8XSnUSt2BKd 6uXWQhQ0XzyiwISQrL88xDmMc5rar9Gj4274MbuegzYw1Q3Gf3rB7ynHNnbDzaGnRlBN SoBAohJ+eGTH1bc4YKAF1nxZJkdZJ6cgSM1P9JLFD+9ADVUXdVoK+ri7vM7MwrG7B9HK /J0EHZiLhRny+Ma0HfTR4x5BIW+o8MOQx38/7jD6ApuR3FN82Zy9YmjM+/1jPALh4GBJ JrxA== X-Gm-Message-State: AOAM533mp7YFM2zkJs7QVgT43T8EcLRj4A9vKdMp6S5sf6dMCtNNFCpB l3x0Kzgm/Ef51hlOOm1YRukylWFZddYAy3bChleUHzOZ X-Google-Smtp-Source: ABdhPJy+xl2oI1UvjCXfcYUlgNcKNWFiiu+kttdPrBY+8CZh9AgWwQVAab76cv4Cr9pEdsJXPPQxdYrYweYeS9NTNjs= X-Received: by 2002:a5d:9a8e:: with SMTP id c14mr63963527iom.178.1609851205863; Tue, 05 Jan 2021 04:53:25 -0800 (PST) MIME-Version: 1.0 References: <20201228213121.2331449-1-aford173@gmail.com> <20201228213121.2331449-4-aford173@gmail.com> In-Reply-To: From: Adam Ford Date: Tue, 5 Jan 2021 06:53:14 -0600 Message-ID: Subject: Re: [PATCH 4/4] net: ethernet: ravb: Name the AVB functional clock fck To: Geert Uytterhoeven Cc: Linux-Renesas , Adam Ford-BE , Sergei Shtylyov , "David S. Miller" , Jakub Kicinski , Rob Herring , Magnus Damm , netdev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 4, 2021 at 4:41 AM Geert Uytterhoeven wrote: > > Hi Adam, > > On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote: > > The bindings have been updated to support two clocks, but the > > original clock now requires the name fck to distinguish it > > from the other. > > > > Signed-off-by: Adam Ford > > Thanks for your patch! > > > --- a/drivers/net/ethernet/renesas/ravb_main.c > > +++ b/drivers/net/ethernet/renesas/ravb_main.c > > @@ -2142,7 +2142,7 @@ static int ravb_probe(struct platform_device *pdev) > > > > priv->chip_id = chip_id; > > > > - priv->clk = devm_clk_get(&pdev->dev, NULL); > > + priv->clk = devm_clk_get(&pdev->dev, "fck"); > > This change is not backwards compatible, as existing DTB files do not > have the "fck" clock. So the driver has to keep on assuming the first > clock is the functional clock, and this patch is thus not needed nor > desired. Should I post a V2 with this removed, or can this patch just be excluded? adam > > > if (IS_ERR(priv->clk)) { > > error = PTR_ERR(priv->clk); > > goto out_release; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds