From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B1EC433E0 for ; Thu, 18 Feb 2021 12:57:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFE2464ECC for ; Thu, 18 Feb 2021 12:57:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFE2464ECC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VuxwWBqQGVbnc3XeEkEund5chjlK+t34RS34OirmDlQ=; b=ipz33YtgYimpWkE+VGKtdnF42 4yB7YSUyB/6GQuLsuS+7sSuOmLVsb5QBBSXfbooyC/KhfK7aDB0Sq6+uXeqCEt/YnTEOFNtQHxNLa dTeOKSzlGlJtift2NX9NJAl78/hPkmYnOTVNae47RbMeY72Z/BAJ5Z4KK6+D6zHOM96AQ3fztpAtk q4Bq3phedA41LJ2PeX+OYKJVFiBYYzo6Sr0L2WlmduTg5Cfb6PwMYN/5ok5LF6MtXgwH4LlbbdHhp no6EjG2Pe7p/wbo8a4qsdaUCNp4mXrYbYLmCUQvIpm1vdH5sbN1ZW6NfNbmeAJ65EJdPZnhRgnvny qajm52ltA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCipv-0007BW-MT; Thu, 18 Feb 2021 12:55:15 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCipt-0007At-RS for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 12:55:14 +0000 Received: by mail-pl1-x629.google.com with SMTP id r2so1198150plr.10 for ; Thu, 18 Feb 2021 04:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xpg7rVXuc506uimZ6irnC3z7aZxqk2CTMxG9M5ZAHG0=; b=ktnbTyJoRsTYAHPHK117Qin5iBG1P2E5MeJ/9UqfbXJ3TwkfUzfgTB4YCQOyYLKeQS WUPGwun28XhYJJgoGC23lH0iAiQWr8BmWa0y7lD5PCTXI7OwnJcGDAY5XhN2XyUkmq5x maafSQokf7NDH6pk5oMZMXn98EidvGt6WCHiG5KIQsuBcg4zgT0FWzfoVKy1h6rjuQni SGS4JfhQxkCs/yV9auKcSLy8UNpssy9Cuc6n41J1nEIIIwwPSej/c1JQhfUK37PR5XbS YM7Z0TADlKE4d56ntsV4pDUXmNHTP1+DyvFwGAAr4b68tgNC+KZgTZYTRzY8BAHsw7eI TKGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xpg7rVXuc506uimZ6irnC3z7aZxqk2CTMxG9M5ZAHG0=; b=BjjW9XFXnR1hxhc5kDAhxqnN85cHMDSi0RF2CB8Gcm/B0kwa+GxA8HQb4jWU0Mnt0O R+m7T8FQY05a4fQZ1i1QIgt9H310mZtDCmQdCFC6J8Ojrzo3oghKhBzRnrXuQlwmtZ/E rdvci7A26J8+BaX8DukU5Gik+dIIpeglt1nDUN971vmR133+7TAUTfcGRbuA9WfOtvFJ xJ3H/ATttybDXDN2M7ae0s1vm0NUh61vnIpUwaWHRRIXPDX6k/qeWl4xSiw1Qw7/eznu gfmAM6wPpWk9bGvZEpu1buktKStCLK/CXNG0ByTq5/nIzamQsKDH+PXCjc8Ad2poWLIX s00g== X-Gm-Message-State: AOAM532qVC1FAHhsqBVDX5ygvKCgPDE8phasnwa50ox/czFCaxHpwOyi qpg1aUHfKx6Ja3aQ0hNFcEdz7vkqtC/N14Uv97dG2+3XXCOIpQ== X-Google-Smtp-Source: ABdhPJxY/DKFRAIHgFiXmkY7QOapq3rOK6a/UhNlqUmL2cy92RnSvSAKrxRHWqmuDaH5emoQKIJ77TVr4xWknIYVNww= X-Received: by 2002:a17:90a:5601:: with SMTP id r1mr3843391pjf.236.1613652909881; Thu, 18 Feb 2021 04:55:09 -0800 (PST) MIME-Version: 1.0 References: <20201105174434.1817539-1-l.stach@pengutronix.de> <20201105174434.1817539-13-l.stach@pengutronix.de> <35f1fdad-580c-9b90-9536-98246e31250b@kontron.de> <4a5d653a-237c-cab4-905b-af8205fc348f@kontron.de> In-Reply-To: <4a5d653a-237c-cab4-905b-af8205fc348f@kontron.de> From: Adam Ford Date: Thu, 18 Feb 2021 06:54:58 -0600 Message-ID: Subject: Re: [PATCH v2 12/13] arm64: dts: imx8mm: add GPC node and power domains To: Frieder Schrempf X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_075513_933953_EF394427 X-CRM114-Status: GOOD ( 35.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , patchwork-lst@pengutronix.de, NXP Linux Team , Sascha Hauer , Fabio Estevam , arm-soc , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 14, 2021 at 4:39 AM Frieder Schrempf wrote: > > On 09.12.20 16:26, Frieder Schrempf wrote: > > Hi Lucas, > > > > On 05.11.20 18:44, Lucas Stach wrote: > >> This adds the DT nodes to describe the power domains available on the > >> i.MX8MM. Things are a bit more complex compared to other GPCv2 power > >> domain setups, as there is now a hierarchy of domains where complete > >> subsystems (HSIO, GPU, DISPLAY) can be gated as a whole, but also > >> fine granular gating within those subsystems is possible. > >> > >> Note that this is still incomplete, as both VPU and DISP domains are > >> missing their reset clocks. Those aren't directly sourced from the CCM, > >> but have another level of clock gating in the BLKCTL of those domains, > >> which needs a separate driver. > >> > >> Signed-off-by: Lucas Stach > >> --- > >> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 58 +++++++++++++++++++++++ > >> 1 file changed, 58 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > >> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > >> index b83f400def8b..c21901a8aea9 100644 > >> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > >> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > >> @@ -4,6 +4,8 @@ > >> */ > >> #include > >> +#include > >> +#include > >> #include > >> #include > >> #include > >> @@ -547,6 +549,62 @@ > >> interrupts = ; > >> #reset-cells = <1>; > >> }; > >> + > >> + gpc: gpc@303a0000 { > >> + compatible = "fsl,imx8mm-gpc"; > >> + reg = <0x303a0000 0x10000>; > >> + interrupts = ; > >> + interrupt-parent = <&gic>; > >> + interrupt-controller; > >> + #interrupt-cells = <3>; > >> + > >> + pgc { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + pgc_hsiomix: power-domain@0 { > >> + #power-domain-cells = <0>; > >> + reg = ; > >> + clocks = <&clk IMX8MM_CLK_USB_BUS>; > >> + }; > >> + > >> + pgc_pcie: power-domain@1 { > >> + #power-domain-cells = <0>; > >> + reg = ; > >> + power-domains = <&pgc_hsiomix>; > >> + }; > >> + > >> + pgc_otg1: power-domain@2 { > >> + #power-domain-cells = <0>; > >> + reg = ; > >> + power-domains = <&pgc_hsiomix>; > >> + }; > >> + > >> + pgc_otg2: power-domain@3 { > >> + #power-domain-cells = <0>; > >> + reg = ; > >> + power-domains = <&pgc_hsiomix>; > >> + }; > > > > I'm currently doing some testing on top of v5.10-rc with GPC, BLK-CTL, > > DSIM, etc. I noticed that as soon as I add the nodes above for HSIO/OTG > > (even without referencing them elsewhere) my system freezes on > > suspend/resume. > > > > The same problem exists when I remove the power domains for HSIO/USB and > > add the ones for DISPMIX and DSI to test Marek's work on BLK-CTL. > > > > I'm not really sure at what point exactly the system freezes but this is > > what I see (no_console_suspend is set) and the system does not wake up > > anymore: > > > > echo mem > /sys/power/state > > [ 13.888711] PM: suspend entry (deep) > > [ 13.892429] Filesystems sync: 0.000 seconds > > [ 13.907231] Freezing user space processes ... (elapsed 0.031 seconds) > > done. > > [ 13.945407] OOM killer disabled. > > [ 13.948642] Freezing remaining freezable tasks ... (elapsed 0.001 > > seconds) done. > > [ 13.957216] printk: Suspending console(s) (use no_console_suspend to > > debug) > > It seems like I failed to set no_console_suspend correctly. Here is a > proper log with kernel 5.10.6. The system wakes up, but stalls. > > Can you reproduce this on your system? > [snip] Frieder / Lucas, I was able to get similar behavior on the Nano. I rebased Lucas' patch on the 5.11 kernel, and applied the corresponding patches to my Nano board. It works fine until the system sleeps, but after it wakes, even the heartbeat LED stops beating. I don't know if there is a conflict between TF-A and the gpc driver in there, or if the gpcv2 driver needs to do something differently to wake the system from sleep. # echo mem > /sys/power/state [ 3754.346162] PM: suspend entry (deep) [ 3754.349872] Filesystems sync: 0.000 seconds [ 3754.387641] Freezing user space processes ... (elapsed 0.001 seconds) done. [ 3754.395890] OOM killer disabled. [ 3754.399141] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done. [ 3754.407674] printk: Suspending console(s) (use no_console_suspend to debug) [ 3754.992015] Disabling non-boot CPUs ... [ 3755.027902] i.mx8mm_thermal 30260000.tmu: failed to register thermal zone sensor[0]: -517 [ 3755.036317] OOM killer enabled. [ 3755.039467] Restarting tasks ... done. [ 3755.050669] PM: suspend exit root@imx8mmevk:~# Then it hangs. adam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel