From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13E16C433F5 for ; Mon, 3 Jan 2022 22:32:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9941280384; Mon, 3 Jan 2022 23:32:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dEyKE7lX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2D7CE80378; Mon, 3 Jan 2022 23:32:39 +0100 (CET) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7743B80605 for ; Mon, 3 Jan 2022 23:32:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-ed1-x52a.google.com with SMTP id b13so140985181edd.8 for ; Mon, 03 Jan 2022 14:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gVZuNoVko3aduymaCAxPkBDheJyPdRFHxgADoWPosM8=; b=dEyKE7lXKu7AWeQYLEAYjjTuWwwDsMLM9lw9jQec85iR+W//Uhspd/ilQqbCQzEb3m /JLbciLBZDK9VuhF4/yz3kn7QkkghxWmtPuGd1UeoU8x0wDhGvynOeBawmP3smof++Ho bRUz9g+q8T0D2RKrxs5MHiUNwNdsRWsDllWviWP3ISUFC9OZxEeIUmVIbi2adk2KLVzY qtlRZ5F6Hr/LHzLSXS8HGpx2zxVmfyR28f+zSIvZC57eiD2f/Uwym4e/sAs9iQFSqBWw OuAY4xo1VuxYZBp8lG5vTWNqge2pRvgW6Nqbt3LbwAKXH/+t0rdyBOfuqX2Jcw9sqUj3 7Skg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gVZuNoVko3aduymaCAxPkBDheJyPdRFHxgADoWPosM8=; b=CinkfwVXbsjYg7rfd0bSzpNDUAlb/f2vNV8v7ajj2m8Grldud4qTKi5p3M5qXsPmQ1 B5A3uzLLb3exaMjXatuBMjq5Wk7jvSUjle1cFaQh9sUBnLG36P69UJWLCZB8cEL9COWZ 6qbMkx71DFTFOaeGSe3pL+s7Dx5uRVFuTwUVre8ToW0eP6/nWBb4imfYU2YtSUr4ZF2U covSQ2N1mhmjtnDws+JZt5BE0Ynp7pJkLhLP+/twmqmConLRTFWfgA51QSaLpP5gWytG kjgOwqFDZos0TjThN1/LdmL54X1kmPGlpHoWEcUsikENDQP9WPg0VwrPwZttULBw2x43 neVQ== X-Gm-Message-State: AOAM530plKA3zqpTz0LLM00IxYbsVv730bTPemT7uAB9p7z9lCvFuZ4p 2pnXvOGNVZuGY+M/N2E51+NkTnR5KjCRaR+zzyFCd3pdqRfN7g== X-Google-Smtp-Source: ABdhPJwOhPRQsruXLm9SlX/3fcXIPOQx2PHfZjpzuaYTMzIjtBuju0ZYND8sYvuNX6AYL0j/+ED78sVXa+5grnYv0hs= X-Received: by 2002:a17:907:3f1e:: with SMTP id hq30mr36797841ejc.613.1641249152798; Mon, 03 Jan 2022 14:32:32 -0800 (PST) MIME-Version: 1.0 References: <20211223140756.304527-1-aford173@gmail.com> In-Reply-To: From: Adam Ford Date: Mon, 3 Jan 2022 22:32:21 +0000 Message-ID: Subject: Re: [PATCH V2] usb: ehci-mx6: Enable OTG detection on imx8mm and imx8mn To: Tim Harvey Cc: u-boot , Marek Vasut , Simon Glass , Fabio Estevam Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.38 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Jan 3, 2022 at 10:20 PM Tim Harvey wrote: > On Thu, Dec 23, 2021 at 6:08 AM Adam Ford wrote: > > > > The imx8mm and imx8mn appear compatible with imx7d-usb > > flags in the OTG driver. If the dr_mode is defined as > > host or peripheral, the device appears to operate correctly, > > however the auto host/peripheral detection results in an error. > > > > The solution isn't just adding checks for imx8mm and imx8mn to > > the check for imx7, because the USB clock needs to be running > > to read from the USBNC_PHY_STATUS_OFFSET register or it will hang. > > > > The init_type in both priv and plat data are the same, so it doesn't > > make sense to configure the data in the plat data and copy the > > data to priv when priv can be configured directly. Instead, rename > > ehci_usb_of_to_plat to ehci_usb_dr_mode and call it from the > > probe functions after the clocks are enabled, but before the data > > is required. > > > > With that added, the additional checks for imx8mm and imx8mn will > > allow reading the register to automatically determine the state > > (host or device) of the OTG controller. > > > > Signed-off-by: Adam Ford > > --- > > V2: Rename ehci_usb_of_to_plat to ehci_usb_dr_mode and call it > > from the probe after the clocks are enabled, but before > > the data is needed. > > > > diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c > > index 1bd6147c76..f2a34b7f06 100644 > > --- a/drivers/usb/host/ehci-mx6.c > > +++ b/drivers/usb/host/ehci-mx6.c > > @@ -513,7 +513,7 @@ static const struct ehci_ops mx6_ehci_ops = { > > > > static int ehci_usb_phy_mode(struct udevice *dev) > > { > > - struct usb_plat *plat = dev_get_plat(dev); > > + struct ehci_mx6_priv_data *priv = dev_get_priv(dev); > > void *__iomem addr = dev_read_addr_ptr(dev); > > void *__iomem phy_ctrl, *__iomem phy_status; > > const void *blob = gd->fdt_blob; > > @@ -540,18 +540,18 @@ static int ehci_usb_phy_mode(struct udevice *dev) > > val = readl(phy_ctrl); > > > > if (val & USBPHY_CTRL_OTG_ID) > > - plat->init_type = USB_INIT_DEVICE; > > + priv->init_type = USB_INIT_DEVICE; > > else > > - plat->init_type = USB_INIT_HOST; > > - } else if (is_mx7()) { > > + priv->init_type = USB_INIT_HOST; > > + } else if (is_mx7() || is_imx8mm() || is_imx8mn()) { > > phy_status = (void __iomem *)(addr + > > USBNC_PHY_STATUS_OFFSET); > > val = readl(phy_status); > > > > if (val & USBNC_PHYSTATUS_ID_DIG) > > - plat->init_type = USB_INIT_DEVICE; > > + priv->init_type = USB_INIT_DEVICE; > > else > > - plat->init_type = USB_INIT_HOST; > > + priv->init_type = USB_INIT_HOST; > > } else { > > return -EINVAL; > > } > > @@ -559,19 +559,19 @@ static int ehci_usb_phy_mode(struct udevice *dev) > > return 0; > > } > > > > -static int ehci_usb_of_to_plat(struct udevice *dev) > > +static int ehci_usb_dr_mode(struct udevice *dev) > > { > > - struct usb_plat *plat = dev_get_plat(dev); > > + struct ehci_mx6_priv_data *priv = dev_get_priv(dev); > > enum usb_dr_mode dr_mode; > > > > dr_mode = usb_get_dr_mode(dev_ofnode(dev)); > > > > switch (dr_mode) { > > case USB_DR_MODE_HOST: > > - plat->init_type = USB_INIT_HOST; > > + priv->init_type = USB_INIT_HOST; > > break; > > case USB_DR_MODE_PERIPHERAL: > > - plat->init_type = USB_INIT_DEVICE; > > + priv->init_type = USB_INIT_DEVICE; > > break; > > case USB_DR_MODE_OTG: > > case USB_DR_MODE_UNKNOWN: > > @@ -639,10 +639,8 @@ static int mx6_parse_dt_addrs(struct udevice *dev) > > > > static int ehci_usb_probe(struct udevice *dev) > > { > > - struct usb_plat *plat = dev_get_plat(dev); > > struct usb_ehci *ehci = dev_read_addr_ptr(dev); > > struct ehci_mx6_priv_data *priv = dev_get_priv(dev); > > - enum usb_init_type type = plat->init_type; > > struct ehci_hccr *hccr; > > struct ehci_hcor *hcor; > > int ret; > > @@ -660,8 +658,6 @@ static int ehci_usb_probe(struct udevice *dev) > > return ret; > > > > priv->ehci = ehci; > > - priv->init_type = type; > > - priv->phy_type = usb_get_phy_mode(dev_ofnode(dev)); > > > > #if CONFIG_IS_ENABLED(CLK) > > ret = clk_get_by_index(dev, 0, &priv->clk); > > @@ -677,6 +673,11 @@ static int ehci_usb_probe(struct udevice *dev) > > mdelay(1); > > #endif > > > > + ret = ehci_usb_dr_mode(dev); > > + if (ret) > > + goto err_clk; > > + priv->phy_type = usb_get_phy_mode(dev_ofnode(dev)); > > + > > #if CONFIG_IS_ENABLED(DM_REGULATOR) > > ret = device_get_supply_regulator(dev, "vbus-supply", > > &priv->vbus_supply); > > @@ -700,7 +701,7 @@ static int ehci_usb_probe(struct udevice *dev) > > #if CONFIG_IS_ENABLED(DM_REGULATOR) > > if (priv->vbus_supply) { > > ret = regulator_set_enable(priv->vbus_supply, > > - (type == USB_INIT_DEVICE) ? > > + (priv->init_type == > USB_INIT_DEVICE) ? > > false : true); > > if (ret && ret != -ENOSYS) { > > printf("Error enabling VBUS supply (ret=%i)\n", > ret); > > @@ -785,11 +786,9 @@ U_BOOT_DRIVER(usb_mx6) = { > > .name = "ehci_mx6", > > .id = UCLASS_USB, > > .of_match = mx6_usb_ids, > > - .of_to_plat = ehci_usb_of_to_plat, > > .probe = ehci_usb_probe, > > .remove = ehci_usb_remove, > > .ops = &ehci_usb_ops, > > - .plat_auto = sizeof(struct usb_plat), > > .priv_auto = sizeof(struct ehci_mx6_priv_data), > > .flags = DM_FLAG_ALLOC_PRIV_DMA, > > }; > > -- > > 2.32.0 > > > > Adam, > > How are you testing this for IMX8MM or IMX8MN? > I ran "ums 0 mmc 2" to test peripheral mode and verified that I could see the corresponding MMC device appear on my host machine. I actually burned an image to the eMMC and I was able to get Linux to run the eMMC I burned. I connected a USB host adapter that grounds the ID pin and ran "usb start" to test for mass storage devices, and did simple tests like "fatls usb 0" to verify I could read the thumb drive. I had to enable power-domain support, USB, mass storage, and a few other items in my config file to get it all to work. I'm traveling, so I won't be able to give you my exact config options that I enabled. adam > > Best Regards, > > Tim >