From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B76E7C77B60 for ; Fri, 28 Apr 2023 11:58:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8838D863A5; Fri, 28 Apr 2023 13:58:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JBeiL7T7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 27B8385D4E; Fri, 28 Apr 2023 13:58:03 +0200 (CEST) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4FBB685D4E for ; Fri, 28 Apr 2023 13:57:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-247296def99so6733796a91.1 for ; Fri, 28 Apr 2023 04:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682683077; x=1685275077; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LqivPH1a0EYqi5q35tXbtyupetwm6COM1bcGSUmVvOQ=; b=JBeiL7T7Y1v+PFQI8OZR07JyhuIfYwru2xzGFhv2Ryq4pL02/msC5OPBVgJ8jWNqdu b/WVNpz6O3fVLKWzzjnAViB1oBzGa56raUy+lAgURa3q1Bjmie5oGpZlld5g3ROrQ9BK urONmoxdhjRg1aCx2AC/sQLsg4LB4zJ5aSgg3J1Hn/H+pRPypzxaTbpyFjL1YTwpBgl3 QecC3bKUnr/XVjtR7AeH5rFzy0ceMp1ABpc7c2QF65SSQpXHE19ozn6Vc3mVgYnH4KjM MK5zQ5MbKs/E6rp9YTR+Zspibeg+ZOlYQQe/JAtP9BfSs9YDZPorx6FnztLJb8IAJr4P ocnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682683077; x=1685275077; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LqivPH1a0EYqi5q35tXbtyupetwm6COM1bcGSUmVvOQ=; b=MAjDBK/TkIWSA18k8K/w3xziYkwmrQvuLAud/F1I30bIdUOVIchFlkoknmNu2X2LIg B2eA/exfS6KoYHMyKxBVgsbUC+q9w1FO3bVrOTen7Ht09T7Jr22tqVdTcAK7VPpNB+8Q x2+Z2Sw+hQ+SagerG8agwB3TgPDrNRE1hZgfm5Mfhzmm0hR4m947Gxayy0ohyIiitL9a 2nE4joOTiX2d9tW9wLwRzSF/UzE0ITCrK8wsdmxgtiEjMSmsCJIrybXo/afiPmxZlXeA Z9a9LU2QVPJcVwyEutdwDXKMSBBmnzfBMRFme4eGa8T8QOCVwWkX9pB76pxNxGMCSx+J XB3g== X-Gm-Message-State: AC+VfDxodVhXQOMFnGLly8wmC8W2PGye4RXgk7NCRy9ppa9lbBDLVZQt MWIc6vb9jtncCsZzlCfMKqYAxchUFY8z6Xrlsd08VELC X-Google-Smtp-Source: ACHHUZ4DDcSZRvYeSgVv3UlX8ejlPuENvKknUpGizos7bQh8vpSm8DfLi9IyG46ToLOsVAoUo6Rw6O/Ts6depT+ddlw= X-Received: by 2002:a17:90b:fcb:b0:24b:8221:5bb4 with SMTP id gd11-20020a17090b0fcb00b0024b82215bb4mr5504645pjb.4.1682683077516; Fri, 28 Apr 2023 04:57:57 -0700 (PDT) MIME-Version: 1.0 References: <20230427180845.127439-1-festevam@gmail.com> In-Reply-To: From: Adam Ford Date: Fri, 28 Apr 2023 06:57:46 -0500 Message-ID: Subject: Re: [PATCH 1/3] arm: dts: imx8mm: Sync with Linux 6.3 To: Tim Harvey Cc: Fabio Estevam , sbabic@denx.de, u-boot@lists.denx.de, Fabio Estevam Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, Apr 27, 2023 at 5:25=E2=80=AFPM Tim Harvey = wrote: > > On Thu, Apr 27, 2023 at 12:49=E2=80=AFPM Fabio Estevam wrote: > > > > On Thu, Apr 27, 2023 at 4:44=E2=80=AFPM Tim Harvey wrote: > > > > > Fabio, > > > > > > Sorry for the confusion. > > > > > > This imx8mm dt sync patch will hang on imx8mm boards that use 'both' > > > usbotg1 and usbotg2. You can reproduce this hang on your imx8mm-evk b= y > > > enabling usbotg2 in the dt (the board has it but it is not enabled du= e > > > to the gpio based usb 3.0 mux not being sorted out yet): > > > +&usbotg2 { > > > + dr_mode =3D "otg"; > > > + status =3D "okay"; > > > +}; > > > + > > > > > > u-boot=3D> usb start && usb tree > > > starting USB... > > > Bus usb@32e40000: Bus usb@32e50000: > > > ^^^ imx8mm-evk hangs > > > > Yes, I can reproduce the hang, but it happens with or without the > > imx8mm dt sync. > > > > Fabio, > > I do 'not' see a hang on imx8mm-evk on 'usb start && usb tree' on > master (my other issue was on a 'usb stop' but only with usb > controllers in host mode). > > > This hang is a separate issue, not dt related, as far as I understand. > > > > The imx8mm dts sync does solve the issue of running 'ums' after CTRL+C. > > I don't agree. The hang 'is' related because all my imx8mm-venice-* > boards which use 'both' USB controllers hang with this patch on a 'usb > start' and don't hang without it. While a basic 'review' of the patch > looks good but actual product testing shows issues. As a maintainer > for ARM FREESCALE IMX you must have another imx8mm board which uses > both usbotg devices to test against and verify you see what I see? > > Until we know what other fix is needed to go along with this: > Nacked-by: Tim Harvey What is the harm is sync'ing the device tree with the kernel? I seemed like you found a solution with the regulator patch. Did I misunderstand that? adam > > I've verified that it's the changes from Linux commit 4585c79ff477f > ("arm64: dts: imx8mm: correct usb power domains") that causes the > hang, but I don't know why yet. > > Why are we seeing different behavior on the imx8mm-evk? Are we on > different branches? My testing today is on caf0a88d9f31 > > Best Regards, > > Tim