[U-Boot] [PATCH v13 5/7] cmd: mtd: add 'mtd' command

[Adam Ford <aford173@gmail.com>]

On Wed, Oct 3, 2018 at 7:43 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Adam,
>
> Adam Ford <aford173@gmail.com> wrote on Wed, 3 Oct 2018 07:35:15 -0500:
>
> > On Mon, Oct 1, 2018 at 8:48 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > > There should not be a 'nand' command, a 'sf' command and certainly not
> > > a new 'spi-nand' command. Write a 'mtd' command instead to manage all
> > > MTD devices/partitions at once. This should be the preferred way to
> > > access any MTD device.
> >
> > What is the expected behavior when I type 'mtd list' on my omap37
> > board, it just hangs.
>
> What do you mean "hangs", does U-Boot crashes? Or is it really hanging
> with no more on the console? Can you Ctrl-C to cancel the command or is
> it really stuck?

It's really stuck

  U-Boot 2018.11-rc1-00636-g592cd5defd (Oct 03 2018 - 07:28:27 -0500)

  OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 800 MHz
  Model: LogicPD Zoom OMAP3 Development Kit
  Logic DM37x/OMAP35x reference board + LPDDR/NAND
  DRAM:  256 MiB
  NAND:  512 MiB
  MMC:   OMAP SD/MMC: 0
  Loading Environment from NAND... OK
  OMAP die ID: 155000029ff800000168301018021018
  Board: DM37xx Torpedo
  Net:   smc911x-0
  Hit any key to stop autoboot:  0
  OMAP Logic # mtd list

Control-C does nothing.


>
> >
> > I can use the nand read/write functions and mtdparts lists the
> > partitions, so I know nand works.  My defconfig
> > lists the partitions, so if we're not supposed to use mtdparts, where
> > I do store the partition information?
>
> You are not supposed to use the mtdpart _command_, but the mtdparts
> _variable_ must be used in order to declare the partitions.

OK.  If I can get MTD working, I'll work to remove the other commands
like NAND and MTDPARTS

>
> >
> > I intentionally removed it from the device tree a while ago, because
> > U-Boot was passing the partition info to Linux.
>
> Indeed, that's his primary role.

OK, I just want to make sure I'm understanding it correctly.

thanks,

adam
>
> Thanks,
> Miquèl