From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE807C433FE for ; Tue, 2 Nov 2021 04:22:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BE9160E8C for ; Tue, 2 Nov 2021 04:22:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232782AbhKBEZJ (ORCPT ); Tue, 2 Nov 2021 00:25:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbhKBEZI (ORCPT ); Tue, 2 Nov 2021 00:25:08 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C408C061714; Mon, 1 Nov 2021 21:22:34 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id w1so17433157edd.10; Mon, 01 Nov 2021 21:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8wvlsTEh9v6d7t2lqZ3L4fn0Kl7+4KHrTzQoMERiXTg=; b=VrxGInNXD0B4oQVm8NkWETycecI5eXLtWhb8kTg8HD4lP84ibgT0vUOVkIwSzT1eEy yoxOeUGulCy8lX1byszNOYTqIOIXQSOsXAiJVV/cCAbdRhLjy/CUXp3BSXeALbhODKM/ UzRDsNG69E6VYV1/whtSuUFkTMrwI1m3CyvQdl719RtpChPfZXX9C2kSfl2UK+Ecqd68 OCQ+E27sOrMNbd0obOeiSSmdeUVO2oQhLu+1bNHdr+wYRXvc+NBEOw8ApWusvZAzyuHx U6mx6hk3xUQNAthJdVZWvuF3Ni3qS5jXAL0E8PJ75+ACrjalFtxdUeEN2SGJ2w7OI3VC kfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8wvlsTEh9v6d7t2lqZ3L4fn0Kl7+4KHrTzQoMERiXTg=; b=FOM2YOXW3T3Rn06i36139QLpdvjbdnj1NbTWr1iGNizRmNmheddshpuzOwcn9ob/vy 00GCkKt2fFsPkoJrkk4QNQFq3zJj+OsL1BAj8g9ilATMNYmMm8uPRHuQ8ud7LsmY/Q39 pBNHjd6snnPPR7aYni9n4uM+4Ew4PjoeO57+9vyDhoiEyAcHhkFefdr+SSnGpk/igEFW ejD6syW+QCiVPZYEJS/YgEO8aea8Sr8oiqxo4oVGoq6NCFRhIZ1PCMhUqO+tKYdL8kOq r+3PSMgb7pdnrSODH2hg9NpXJgOHHR5MjWZM4/C+5TegQPmuskxD/CYaWpA+t9M2H63W SpTA== X-Gm-Message-State: AOAM532xdNUFOZMdfNmrQ4y5EUR/x67KYR+hMWrue56mz4tRGL1yNT5I sBlu5HsMxxRZUjEudQaY+bh772FfXCnfLFivqRs= X-Google-Smtp-Source: ABdhPJz04lDpzZsKg7vUXthp25hdWbyRKaHlNT+vcWzgKd1s76PCi4SjNQat12axJKG6PcfAq/CMGarHTyyNgg2o2BM= X-Received: by 2002:a17:906:284e:: with SMTP id s14mr41215732ejc.332.1635826952470; Mon, 01 Nov 2021 21:22:32 -0700 (PDT) MIME-Version: 1.0 References: <20211101222857.6940-1-tomm.merciai@gmail.com> <20211101225827.GA9208@tom-desktop> In-Reply-To: <20211101225827.GA9208@tom-desktop> From: Adam Ford Date: Mon, 1 Nov 2021 23:22:21 -0500 Message-ID: Subject: Re: [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs To: Tommaso Merciai Cc: Ahmad Fatoum , arm-soc , devicetree , Peng Fan , Alice Guo , Shawn Guo , Sascha Hauer , Joakim Zhang , Krzysztof Kozlowski , Linux Kernel Mailing List , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Lucas Stach Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 1, 2021 at 5:58 PM Tommaso Merciai wrote: > > On Mon, Nov 01, 2021 at 11:35:49PM +0100, Ahmad Fatoum wrote: > > Hello Tommaso, > > > > On 01.11.21 23:28, Tommaso Merciai wrote: > > > Add system controller node for registers of module Display Block Control > > > (DISPLAY_BLK_CTRL, base address: 0x32e28000). > > > The DISPLAY_BLK_CTRL module contains general purpose registers (GPRs), > > > which control varied features of the associated peripherals. > > > Reference: IMX8MMRM Rev. 3, 11/2020, p 3897 > > > --- > > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > index 2f632e8ca388..3e496b457e1a 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > @@ -961,6 +961,11 @@ aips4: bus@32c00000 { > > > #size-cells = <1>; > > > ranges = <0x32c00000 0x32c00000 0x400000>; > > > > > > + dispmix_gpr: display-gpr@32e28000 { > > > + compatible = "fsl, imx8mm-iomuxc-gpr", "syscon"; > > > > Please read vendor patches before submitting them. The space > > is out-of-place in the compatible and the compatible is wrong: > > This doesn't look like a i.MX8MM pin controller. > > > > Cheers, > > Ahmad > > Hi Ahmad, > Thanks for your review. Do you think this is correct? > > compatible = "fsl,imx8mm-dispmix-gpr", "syscon"; > > Let me know. There was already a driver created for the blk-ctrl stuff and it has a device tree binding at 32e28000. It's tied into the power-domain system, so if you want to enable the csi, dsi, or lcd, etc. you can just reference the blt-ctrl power domain index, and it enables the device's gpc power domain and takes the corresponding device out of reset. adam > > Thanks, > Tommaso > > > > > > + reg = <0x32e28000 0x100>; > > > + }; > > > + > > > usbotg1: usb@32e40000 { > > > compatible = "fsl,imx8mm-usb", "fsl,imx7d-usb"; > > > reg = <0x32e40000 0x200>; > > > > > > > > > -- > > Pengutronix e.K. | | > > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C813CC433F5 for ; Tue, 2 Nov 2021 04:24:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85B0860F4B for ; Tue, 2 Nov 2021 04:24:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85B0860F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GJdsYcDgJzYraX5ZtXQUIaH4f1qBBXFt2c67oARgHjg=; b=uh2pRlKaQ8y0X9 zJGVdbcaNxlGEkeRmXqKAyMNmvYEsO3S4wr7YsSk5cGxgX7XrTjy62rWKKXOyYVSNxz6ULFaPDe3h Gy21AiIwY12bqTq/cju0WbqEPu3hmTy0HXFx3DslaYBwv1NHqcl8eqGbLZIQmp2R77yA0QLvASAz5 7jxF+EH9YH+MRZ6zjsZByw5Vh8Rwpp40C911MErefzyErnMk+SuRfdhlRgpJPOnyZZF6WYdssMgR6 LD3732rqS7I5VZsvIWd4A3DNo8/ep50OHYpI7Y99jbVpdO+tGDiLeTYoATdedQ+doZ4IcRqIe+XJl 1w5PRxVyPsReyv74Trcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhlJm-000W06-9u; Tue, 02 Nov 2021 04:22:38 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhlJi-000VzF-J4 for linux-arm-kernel@lists.infradead.org; Tue, 02 Nov 2021 04:22:36 +0000 Received: by mail-ed1-x532.google.com with SMTP id g14so9322411edz.2 for ; Mon, 01 Nov 2021 21:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8wvlsTEh9v6d7t2lqZ3L4fn0Kl7+4KHrTzQoMERiXTg=; b=VrxGInNXD0B4oQVm8NkWETycecI5eXLtWhb8kTg8HD4lP84ibgT0vUOVkIwSzT1eEy yoxOeUGulCy8lX1byszNOYTqIOIXQSOsXAiJVV/cCAbdRhLjy/CUXp3BSXeALbhODKM/ UzRDsNG69E6VYV1/whtSuUFkTMrwI1m3CyvQdl719RtpChPfZXX9C2kSfl2UK+Ecqd68 OCQ+E27sOrMNbd0obOeiSSmdeUVO2oQhLu+1bNHdr+wYRXvc+NBEOw8ApWusvZAzyuHx U6mx6hk3xUQNAthJdVZWvuF3Ni3qS5jXAL0E8PJ75+ACrjalFtxdUeEN2SGJ2w7OI3VC kfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8wvlsTEh9v6d7t2lqZ3L4fn0Kl7+4KHrTzQoMERiXTg=; b=N6ELW1KY+/0lzrvpFsRVPDpJqXFN2XNshJ2dulK0K9XKdIbbrctJ3H2siplJ2OCvFv WfNW0h20qOZqGqctp5oQvj1BfEb81AYvDBkCfRl6NkgZkGDtfd1USL1mIM4CMEnmaOwD geLuhhnI4iRpXvAwmgBWx+stQr24qPv5p0psom9v9z1w7wZmvjowTW4JF/zZx+OranFk RYm6T1lRErY/WUSKv2742GJdudiXmeC6st6YUyoTHmCew45Qzpdw/uSySkES8HehYBnu Y2OWaVjKw9Dte6+mIj6UY7xZhRX82znKgOAnc1F7hETRfF+4V7twmAKGS05GfUq3eP+1 XkYQ== X-Gm-Message-State: AOAM533Mb8Zp7X3aGF2pNqrXl/5GbiUgGqw/jNBF8QiImN3sC6DuTBL8 7FI3E/io0O+rf3quSELX6IE5fKcdtG6U4MYl2iQ= X-Google-Smtp-Source: ABdhPJz04lDpzZsKg7vUXthp25hdWbyRKaHlNT+vcWzgKd1s76PCi4SjNQat12axJKG6PcfAq/CMGarHTyyNgg2o2BM= X-Received: by 2002:a17:906:284e:: with SMTP id s14mr41215732ejc.332.1635826952470; Mon, 01 Nov 2021 21:22:32 -0700 (PDT) MIME-Version: 1.0 References: <20211101222857.6940-1-tomm.merciai@gmail.com> <20211101225827.GA9208@tom-desktop> In-Reply-To: <20211101225827.GA9208@tom-desktop> From: Adam Ford Date: Mon, 1 Nov 2021 23:22:21 -0500 Message-ID: Subject: Re: [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs To: Tommaso Merciai Cc: Ahmad Fatoum , arm-soc , devicetree , Peng Fan , Alice Guo , Shawn Guo , Sascha Hauer , Joakim Zhang , Krzysztof Kozlowski , Linux Kernel Mailing List , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Lucas Stach X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_212234_675998_2F475B84 X-CRM114-Status: GOOD ( 29.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 1, 2021 at 5:58 PM Tommaso Merciai wrote: > > On Mon, Nov 01, 2021 at 11:35:49PM +0100, Ahmad Fatoum wrote: > > Hello Tommaso, > > > > On 01.11.21 23:28, Tommaso Merciai wrote: > > > Add system controller node for registers of module Display Block Control > > > (DISPLAY_BLK_CTRL, base address: 0x32e28000). > > > The DISPLAY_BLK_CTRL module contains general purpose registers (GPRs), > > > which control varied features of the associated peripherals. > > > Reference: IMX8MMRM Rev. 3, 11/2020, p 3897 > > > --- > > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > index 2f632e8ca388..3e496b457e1a 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > @@ -961,6 +961,11 @@ aips4: bus@32c00000 { > > > #size-cells = <1>; > > > ranges = <0x32c00000 0x32c00000 0x400000>; > > > > > > + dispmix_gpr: display-gpr@32e28000 { > > > + compatible = "fsl, imx8mm-iomuxc-gpr", "syscon"; > > > > Please read vendor patches before submitting them. The space > > is out-of-place in the compatible and the compatible is wrong: > > This doesn't look like a i.MX8MM pin controller. > > > > Cheers, > > Ahmad > > Hi Ahmad, > Thanks for your review. Do you think this is correct? > > compatible = "fsl,imx8mm-dispmix-gpr", "syscon"; > > Let me know. There was already a driver created for the blk-ctrl stuff and it has a device tree binding at 32e28000. It's tied into the power-domain system, so if you want to enable the csi, dsi, or lcd, etc. you can just reference the blt-ctrl power domain index, and it enables the device's gpc power domain and takes the corresponding device out of reset. adam > > Thanks, > Tommaso > > > > > > + reg = <0x32e28000 0x100>; > > > + }; > > > + > > > usbotg1: usb@32e40000 { > > > compatible = "fsl,imx8mm-usb", "fsl,imx7d-usb"; > > > reg = <0x32e40000 0x200>; > > > > > > > > > -- > > Pengutronix e.K. | | > > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel