From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21829C433F5 for ; Thu, 10 Feb 2022 13:57:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8BAB782F5E; Thu, 10 Feb 2022 14:57:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HmsLsEes"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 68C9F83041; Thu, 10 Feb 2022 14:57:07 +0100 (CET) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1461C81F9A for ; Thu, 10 Feb 2022 14:57:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-ej1-x62a.google.com with SMTP id ka4so15449426ejc.11 for ; Thu, 10 Feb 2022 05:57:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=P14T75C32qf/JxSBmZAol3ZBvOG+dZQzyMsMVzJvsfA=; b=HmsLsEesB/SP1IoviR3/zOFEijIyKfp4ezHCfA1fukOpZbzv8lL03Z/Db07X32l3hw yZGevTSgGUi3ZXoBeWksirBbCLjJkhj8mC3B1P9vYfU5Z2bax2qeNP74J4/kOFpLS2QA GPwHZwbPwDb2UenL1D8f+a29gRHUEurytPtxqsY42jxrLUCI63faBvyIkJqZF/epRBNK dyefkeOmlKynEdvtNv+52gTAfwVAoc749huBNiHKN9hNdVXVLvR6KtIyVH/MXkAbWAcy vCo2OWBYUKruHw2kZckbvnH682tye467lBzDBm0iWe4Ng5IYCZ4AzPKzlEzXYEHNnlcQ 4rbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=P14T75C32qf/JxSBmZAol3ZBvOG+dZQzyMsMVzJvsfA=; b=0mo23NymlEtEl53zEnEKU4nxIcfYmGBme7a8ny+TMskg2sbVn8BQGEzDGpovWSIOam 9eSChW/3kI49Jw4ECchkRf917bAUnPJI8JWieZxg3cADTKUhjE94fBZIGVBr6UBdtkjX 748n+ak334KbKxDvhbg5K66w2Gu6mApX31McV7rgKqQzdC7sDm+PbUcKfi4H7+HBdGU8 dva4xLQvMIDTtmxGTO3L/OL+4gC57s+3PyU0hIdCOC9isCHZWjW5nFSyNvKCM5w1BiQ3 pVSTaHfJ/LDAks18kRjBDMPzBae3WVXnsa3Ad84utt8e6XYiaHODlYzUvfHeZX8Y0nYB pLwg== X-Gm-Message-State: AOAM532zSr/cz3YkO/FYbr1zHXwL362euo/AM+iStKTdYgFuh5CS/yR+ YiEds/92z5OhL2+W3IPV0V+erFD8MS/wKICotxI= X-Google-Smtp-Source: ABdhPJxLuN06SAvc9UsOh6Rx3yLSwF8zZ4J1wZxtIBF9XE2+osjzHJpMUJjGf/p5f7BtNwcu76UIBHEWi5Dat3xYAK0= X-Received: by 2002:a17:907:60ca:: with SMTP id hv10mr3156894ejc.316.1644501422407; Thu, 10 Feb 2022 05:57:02 -0800 (PST) MIME-Version: 1.0 References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.7.Id5595981cd99201c6a2d8b714254d775436a3483@changeid> <20220209123219.GZ7515@bill-the-cat> In-Reply-To: From: Adam Ford Date: Thu, 10 Feb 2022 07:56:52 -0600 Message-ID: Subject: Re: [PATCH v3 07/18] pxe: Move pxe_utils files To: Simon Glass Cc: Tom Rini , U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, Feb 9, 2022 at 11:16 AM Simon Glass wrote: > > Hi, > > On Wed, 9 Feb 2022 at 05:32, Tom Rini wrote: > > > > On Wed, Feb 09, 2022 at 05:40:03AM -0600, Adam Ford wrote: > > > On Thu, Oct 14, 2021 at 1:50 PM Simon Glass wrote: > > > > > > > > Move the header file into the main include/ directory so we can use= it > > > > from the bootmethod code. Move the C file into boot/ since it relat= es to > > > > booting. > > > > > > > +cc lokeshvutla@ti.com > > > > > > Simon, > > > > > > I can't explain why, but with git bisect, it appears this patch break= s > > > my omap3_logic board (DM3730) by making it wrongly think there is 4GB > > > of RAM, when in reality there is only 256MB. We have both 256MB and > > > 512MB parts, and the automatic memory detection has always 'just > > > worked' in the past. > > > > > > With this patch now, I see: > > > U-Boot 2022.01-rc1-00185-g262cfb5b15 (Feb 09 2022 - 05:23:42 -0600) > > > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > > DRAM: 4 GiB > > > > > > > > > With the previous commit, 8018b9af57b5 ("pxe: Tidy up the is_pxe > > > global"), it properly detects the RAM and fully boots. > > > > > > U-Boot 2022.01-rc1-00184-g8018b9af57 (Feb 09 2022 - 05:21:39 -0600) > > > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > > DRAM: 256 MiB > > > NAND: 512 MiB > > > MMC: OMAP SD/MMC: 0 > > > Loading Environment from NAND... OK > > > OMAP die ID: 619e00029ff800000168300f1502501f > > > Net: eth0: ethernet@08000000 > > > Hit any key to stop autoboot: 0 > > > OMAP Logic # > > > > > > I have CONFIG_CMD_BOOTM, CONFIG_CMD_PXE and CONFIG_CMD_SYSBOOT all > > > defined, so I am having a hard time understanding why this would > > > change behavior or stomp on the the structure that knows the memory > > > size. > > > > > > If I jump ahead to the current 'master' 531c0089457:("Merge branch > > > '2022-02-08-TI-platform-updates') and revert this patch, my board > > > boots correctly again, but I am struggling to understand why. + Marek Beh=C3=BAn > > > > > > Do you have any suggestions for me to try? > > > > I would suggest objdump disassemble U-Boot before/after and see what > > functions have changed. > > Keep an eye out for a BSS variable that is used before relocation, perhap= s? I am still investigating, but disabling LTO appears to fix the issue for me. I'd like to keep LTO, so I'm going to attempt to focus on the differences in the affected functions and how this patch makes LTO behave differently. The disassembly of U-Boot is large, so it's going to take me a bit of time to investigate. If someone has any LTO-related suggestions that I could try, I'd be open to try them too. adam > > Regards, > Simon