From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 374FAC433EF for ; Thu, 10 Feb 2022 14:41:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AE42C80820; Thu, 10 Feb 2022 15:41:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="O3I5vuHV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5737E80FEB; Thu, 10 Feb 2022 15:41:40 +0100 (CET) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F3688803B7 for ; Thu, 10 Feb 2022 15:41:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-ed1-x52b.google.com with SMTP id s7so11350682edd.3 for ; Thu, 10 Feb 2022 06:41:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nUyMgVE8uV/vje/9pSP371CEw5JsK2mkhAvwImndmXM=; b=O3I5vuHVHTu+XxnrugumAajGsyOHvNnqErEacLTHWWWaQjTESYBTi7Iars+TYzXDF4 OnQn94nSQwPAiwgZGtd3TQIFXd0NIeLtRHmm4xjtwwWmSkynBGQdyHjreRk2+PomoT3M 5gVg86TTqXrhdNCC9P3aFmmFhaC8r5RpDaWcCRWPxW5Ch8CZEhy+u0cpsBwhC192apKK xAqAtDgUP2YHC+c63Rk0DumCYnyGAstaIaVwC6dWoyvuaVG1ziQCJQXsNL/KZS5405lT 8L3IhQDiRR/35cVx/TtrQSHIi4mRR9dF9qeCPpcyxM07Nrjv5WqC+wkLUDqPkOUKW9mA 6BHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nUyMgVE8uV/vje/9pSP371CEw5JsK2mkhAvwImndmXM=; b=t794vDM8222zT7x8PxvwYOSqut4d0d5M1KxSZpZcVmdROAXszV/ejhiXe0siIeOFb3 JblikyFqVOt9l3whizBAYHGQPHA8GNue8pNRNv4ZSyUWiKoqCqHM45tbmVhxDFiYxuJA Up5t6dzTvQyhUWkFF411CjxXAAaxMYH3nr0Vw7C1o39d1ZWr5ohVper4WV3yGcxUcPYw rMXetdZLTxFOcj0LXT+ZfSAxJ/Zroj+TfZVIGjhSGZmbS//mS7b8Bh12XslKTYBSEfEY un0suvlFsME9gy263lQzu/9Rc41jiuWRR2WH6GPi4bvrHRX02eLAzS5Od7mMgPRLuTv5 /JOg== X-Gm-Message-State: AOAM531I1aha27F8H7RKTcchuoAh5DV7rnF1hAHx1yMQ5CQQCJtLbEGw uAF2QBrcSrVFfJseqDl2J1aBOOQjWMLrCc6yElQ= X-Google-Smtp-Source: ABdhPJzqpLHhjiYsifaxvVcKhyiSwqZCfuK0JCsql/bFIhBJTs1pzBePgvkc5ohB068IIgCl70SDG+G7NDMQ8QkI0qY= X-Received: by 2002:aa7:d7da:: with SMTP id e26mr8756118eds.70.1644504096177; Thu, 10 Feb 2022 06:41:36 -0800 (PST) MIME-Version: 1.0 References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.7.Id5595981cd99201c6a2d8b714254d775436a3483@changeid> <20220209123219.GZ7515@bill-the-cat> In-Reply-To: From: Adam Ford Date: Thu, 10 Feb 2022 08:41:25 -0600 Message-ID: Subject: Re: [PATCH v3 07/18] pxe: Move pxe_utils files To: Simon Glass Cc: Tom Rini , U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, Feb 10, 2022 at 8:32 AM Simon Glass wrote: > > Hi Adam, > > On Thu, 10 Feb 2022 at 06:57, Adam Ford wrote: > > > > On Thu, Feb 10, 2022 at 7:56 AM Adam Ford wrote: > > > > > > On Wed, Feb 9, 2022 at 11:16 AM Simon Glass wrote: > > > > > > > > Hi, > > > > > > > > On Wed, 9 Feb 2022 at 05:32, Tom Rini wrote: > > > > > > > > > > On Wed, Feb 09, 2022 at 05:40:03AM -0600, Adam Ford wrote: > > > > > > On Thu, Oct 14, 2021 at 1:50 PM Simon Glass = wrote: > > > > > > > > > > > > > > Move the header file into the main include/ directory so we c= an use it > > > > > > > from the bootmethod code. Move the C file into boot/ since it= relates to > > > > > > > booting. > > > > > > > > > > > > > +cc lokeshvutla@ti.com > > > > > > > > > > > > Simon, > > > > > > > > > > > > I can't explain why, but with git bisect, it appears this patch= breaks > > > > > > my omap3_logic board (DM3730) by making it wrongly think there = is 4GB > > > > > > of RAM, when in reality there is only 256MB. We have both 256M= B and > > > > > > 512MB parts, and the automatic memory detection has always 'jus= t > > > > > > worked' in the past. > > > > > > > > > > > > With this patch now, I see: > > > > > > U-Boot 2022.01-rc1-00185-g262cfb5b15 (Feb 09 2022 - 05:23:42 -0= 600) > > > > > > > > > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GH= z > > > > > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > > > > > DRAM: 4 GiB > > > > > > > > > > > > > > > > > > With the previous commit, 8018b9af57b5 ("pxe: Tidy up the is_px= e > > > > > > global"), it properly detects the RAM and fully boots. > > > > > > > > > > > > U-Boot 2022.01-rc1-00184-g8018b9af57 (Feb 09 2022 - 05:21:39 -0= 600) > > > > > > > > > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GH= z > > > > > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > > > > > DRAM: 256 MiB > > > > > > NAND: 512 MiB > > > > > > MMC: OMAP SD/MMC: 0 > > > > > > Loading Environment from NAND... OK > > > > > > OMAP die ID: 619e00029ff800000168300f1502501f > > > > > > Net: eth0: ethernet@08000000 > > > > > > Hit any key to stop autoboot: 0 > > > > > > OMAP Logic # > > > > > > > > > > > > I have CONFIG_CMD_BOOTM, CONFIG_CMD_PXE and CONFIG_CMD_SYSBOOT= all > > > > > > defined, so I am having a hard time understanding why this woul= d > > > > > > change behavior or stomp on the the structure that knows the me= mory > > > > > > size. > > > > > > > > > > > > If I jump ahead to the current 'master' 531c0089457:("Merge bra= nch > > > > > > '2022-02-08-TI-platform-updates') and revert this patch, my bo= ard > > > > > > boots correctly again, but I am struggling to understand why. > > > + Marek Beh=C3=BAn > > > > > > > > > > > > > > > Do you have any suggestions for me to try? > > > > > > > > > > I would suggest objdump disassemble U-Boot before/after and see w= hat > > > > > functions have changed. > > > > > > > > Keep an eye out for a BSS variable that is used before relocation, = perhaps? > > > > > > I am still investigating, but disabling LTO appears to fix the issue > > > for me. I'd like to keep LTO, so I'm going to attempt to focus on th= e > > > differences in the affected functions and how this patch makes LTO > > > behave differently. > > > > > > The disassembly of U-Boot is large, so it's going to take me a bit of > > > time to investigate. If someone has any LTO-related suggestions that > > > I could try, I'd be open to try them too. > > Another thing that might help is to put your revert in a branch and then: > > buildman -b > > then > > buildman -b -sB > > which will show function changes. > > But more directly, the DRAM calculation should be something you can > print out and debug (perhaps with DEBUG_UART) and see where it is > going wrong. I have some meetings, but I'll try that this weekend. I was able to narrow the specific file to pxe_utils.o. If I add 1 line to the Makefile, the issue goes away: CFLAGS_REMOVE_pxe_utils.o :=3D $(LTO_CFLAGS) Would this be acceptable? I haven't tested this, but I am guessing any OMAP3 board with LTO would be affected (maybe others), and I have 5. :-( adam > > Regards, > Simon