From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D73C7C77B60 for ; Fri, 28 Apr 2023 15:32:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AA4B985FBD; Fri, 28 Apr 2023 17:32:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="K0OeqNeZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 998FC85DAA; Fri, 28 Apr 2023 17:32:34 +0200 (CEST) Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2BC4C85FBD for ; Fri, 28 Apr 2023 17:32:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-24b29812c42so87219a91.0 for ; Fri, 28 Apr 2023 08:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682695950; x=1685287950; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N+NGF22QRI2HuXk8eIdI6+udNb5XhIUNIt6Ilzid5bc=; b=K0OeqNeZ8LJp1xl2Ygtcv3AgLPJ3ecyQ7U7I6xMT1oSisvtc3ENJgZOvzpJXCFVp/8 mqZkw2Fd3nr76vwxsjA3z2y2EOaZ7TkQsJK0IqiYuiF87GcdykhcwM4sCKmH7YSjUkSq hZZovxH5b1u4tgpwrSoAA2PwbFDtp9RDhMGNJhwv5VcOs/DBzq55X14W6mBDLzvhXKDG o90bbGYG+2qZeD24AGRFwR7+LQ7o6DzIaqqXneGqy+JDISzLvcR+nBixB0/8mUEE6C7M /CVaHCKXTrFV6oMDnJPMgAkeFeCOqEpEWVGZJaH7G0BmNHFW+jgOFWBPN2SAB+YiO/K8 2FJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682695950; x=1685287950; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N+NGF22QRI2HuXk8eIdI6+udNb5XhIUNIt6Ilzid5bc=; b=Fr88s5ECxzmmKRSmG0scCh9EtIbXaTRnYk8vVxGbSUoJSXlD+Yzd38lcdtg1WLb2U3 PGql3+fFfPin1oukaQQqvJeyVBA5u4C+wetFYXp0ZSPdo0xffy+jvf8YjKL2mwQrBNd+ qFqjWmdvGXZdKWeTQIq6XZCOrwOLu4A3WiZZ+f0EDmq1tvVW+zE4xN/2vQBl477rUNZo yVKhcY/X42IgzCTEQQp6CsVPx9y0bvDfeqSUwWbbIOylYSj1HLaQul1de4eJeEab2y1w A6DSxrQ192KcVuUKLgPbknvu7iiwiO9ZxwNh6ketMHYtDHM2Cy2FibqsXAFJKjxQAGw6 t+ZA== X-Gm-Message-State: AC+VfDxOwG01eEcZ0xxzk8uF337nbxsI7/ussPYxdjPB0pErCd6CcSuT w2cdfZ3z8MMA6iTEhctCCyDzZXGnDS507jFrEJPmzWjn X-Google-Smtp-Source: ACHHUZ7DQWEfCNdvscXrWhlGacT3KH+HxqCg5xvz53z7pinDODnnQHQUA+7I/w2WLeGVnWi9c+C78Hx0hWZqISW+sW0= X-Received: by 2002:a17:90b:1647:b0:24b:2b9a:7fd2 with SMTP id il7-20020a17090b164700b0024b2b9a7fd2mr5563342pjb.9.1682695950225; Fri, 28 Apr 2023 08:32:30 -0700 (PDT) MIME-Version: 1.0 References: <20230427180845.127439-1-festevam@gmail.com> In-Reply-To: From: Adam Ford Date: Fri, 28 Apr 2023 10:32:19 -0500 Message-ID: Subject: Re: [PATCH 1/3] arm: dts: imx8mm: Sync with Linux 6.3 To: Tim Harvey Cc: Fabio Estevam , sbabic@denx.de, u-boot@lists.denx.de, Fabio Estevam Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, Apr 28, 2023 at 10:27=E2=80=AFAM Tim Harvey = wrote: > > On Fri, Apr 28, 2023 at 4:57=E2=80=AFAM Adam Ford wr= ote: > > > > On Thu, Apr 27, 2023 at 5:25=E2=80=AFPM Tim Harvey wrote: > > > > > > On Thu, Apr 27, 2023 at 12:49=E2=80=AFPM Fabio Estevam wrote: > > > > > > > > On Thu, Apr 27, 2023 at 4:44=E2=80=AFPM Tim Harvey wrote: > > > > > > > > > Fabio, > > > > > > > > > > Sorry for the confusion. > > > > > > > > > > This imx8mm dt sync patch will hang on imx8mm boards that use 'bo= th' > > > > > usbotg1 and usbotg2. You can reproduce this hang on your imx8mm-e= vk by > > > > > enabling usbotg2 in the dt (the board has it but it is not enable= d due > > > > > to the gpio based usb 3.0 mux not being sorted out yet): > > > > > +&usbotg2 { > > > > > + dr_mode =3D "otg"; > > > > > + status =3D "okay"; > > > > > +}; > > > > > + > > > > > > > > > > u-boot=3D> usb start && usb tree > > > > > starting USB... > > > > > Bus usb@32e40000: Bus usb@32e50000: > > > > > ^^^ imx8mm-evk hangs > > > > > > > > Yes, I can reproduce the hang, but it happens with or without the > > > > imx8mm dt sync. > > > > > > > > > > Fabio, > > > > > > I do 'not' see a hang on imx8mm-evk on 'usb start && usb tree' on > > > master (my other issue was on a 'usb stop' but only with usb > > > controllers in host mode). > > > > > > > This hang is a separate issue, not dt related, as far as I understa= nd. > > > > > > > > The imx8mm dts sync does solve the issue of running 'ums' after CTR= L+C. > > > > > > I don't agree. The hang 'is' related because all my imx8mm-venice-* > > > boards which use 'both' USB controllers hang with this patch on a 'us= b > > > start' and don't hang without it. While a basic 'review' of the patch > > > looks good but actual product testing shows issues. As a maintainer > > > for ARM FREESCALE IMX you must have another imx8mm board which uses > > > both usbotg devices to test against and verify you see what I see? > > > > > > Until we know what other fix is needed to go along with this: > > > Nacked-by: Tim Harvey > > > > What is the harm is sync'ing the device tree with the kernel? I seemed > > like you found a solution with the regulator patch. Did I > > misunderstand that? > > > > adam > > Adam, > > No, the regulator patch did 'not' resolve the issue created by syncing > the imx8mm dt (I caused confusion by responding to the wrong thread - > the regulator patch resolved a different issue). Ok. > > Could you please verify my results on a board that uses both usbotg1 > and usbotg2? What I see is on master + this imx8mm dt sync > (specifically the changes from Linux commit 4585c79ff477f ("arm64: > dts: imx8mm: correct usb power domains")) the board hangs on usb start > when bringing up usbotg2. I can, but I am about to board a plane to go visit some sick family, but I'll try to do it early next week. I have a board with both USB controllers enabled. My OTG2 is host-only, so I think it's similar to your setup. Should I apply the regulator patch when I test? adam > > Best Regards, > > Tim