From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73025C352AA for ; Tue, 1 Oct 2019 13:07:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48FE421D79 for ; Tue, 1 Oct 2019 13:07:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xw20c9x/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388178AbfJANHB (ORCPT ); Tue, 1 Oct 2019 09:07:01 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:35182 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbfJANHB (ORCPT ); Tue, 1 Oct 2019 09:07:01 -0400 Received: by mail-io1-f68.google.com with SMTP id q10so47791756iop.2; Tue, 01 Oct 2019 06:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cp/Wd/WE/qtr58O8CIKrw9xVR0kc+YHnKSoI3k7iFoE=; b=Xw20c9x/ImWA3eDRYwl/LwBt2HDNu6d0CSqz66wAfceNHwcGfaIBxzWI7v++Q45UOp bQhuuCLYn2+LvT73H5QjKXlAJnMBGUjW9gfaJZHOtObCuN9lhE7tKWCbjKBTkXh/jgVv EHnYEkMqRNKO3COsBT3KBCxAv9jcWCdvnBXN5HjOcckRbFqhWShAjDpTPs0N5+N9CqDn L6mRFPLordUGYgnZp3SaQYbHv5yHuF5zpR1N7ANQWRv+L0lphq4V+CauZgtP+Cxr7mMM TQsPctgyzXvt/WkvHGlKfIq30rmk2ASytzv6RU7aj1+LISKDIw34ggx0+DylGkPjxPa4 tSEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cp/Wd/WE/qtr58O8CIKrw9xVR0kc+YHnKSoI3k7iFoE=; b=HWH7HVLu6M5EGbRUOBYPva3mP98Zqxy1yOqmeeLi8gXowiSwLCOnpFnK6t8sTD+q1W xJf3TpCtbojdWc5g1TjLOInf67YfFJlKZxcTP4DAO4yw8x2qfZyIcd584Lk076FTPkPV oYZD0ZbVnvT0Mj4i0/adW5wDinPVMQ3sJgY8jDaQQuSQoQ52OZrMW+wY+t4UF8FJsDxC RsO/lM0MKTKEkh8yNyymROg5x4HFkHYMTkFYcU3FhkMnQzUeUUHDA2bbc0c8+ZygR2vX yisrztk54GzzQy6yzSm+tlNQqtUP49DZO3XGqZKh5OKmv+E1ZiPRmFbfaAsazAy1dOWb XK5Q== X-Gm-Message-State: APjAAAURn5EJU5gynUtr+pAGh8/uGkJin5dXMSuY4SQeO9lHrIfenx60 VVHfY95DwDLxV3zpwFLCbWopTkrlwfcptOqQYJ4= X-Google-Smtp-Source: APXvYqznkJDopjamhtmxc1W8n98xjkqIiKBEnHNL6qVQXQ78v+UpGJqNIQdhGxnLExPr/6/bClFut0YBHttO9x5dH3w= X-Received: by 2002:a92:3f0a:: with SMTP id m10mr24812690ila.158.1569935218649; Tue, 01 Oct 2019 06:06:58 -0700 (PDT) MIME-Version: 1.0 References: <20190510194229.20628-1-aford173@gmail.com> <854f6130-c8a8-81cb-aa76-4830f218ae54@ti.com> <0473526e-df0a-94a5-5c22-debd0084ab16@ti.com> <36369388-e9c8-22cd-8c19-e2bdf2d0389b@ti.com> <23eba53a-9304-2ceb-d97e-01891ec0b3ed@ti.com> <04306a5e-f9be-35a4-1aa1-5795d780e289@ti.com> <3777f1b1-2d9a-334b-b9e7-99dfda2ae29b@ti.com> <6cd7c9f0-cb26-588b-dfd1-faf462732549@ti.com> <202ae3b3-f72c-5b5b-4344-be22c8368cc7@ti.com> In-Reply-To: From: Adam Ford Date: Tue, 1 Oct 2019 08:06:47 -0500 Message-ID: Subject: Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts To: Tomi Valkeinen Cc: Tero Kristo , "H. Nikolaus Schaller" , Tony Lindgren , Linux-OMAP , Adam Ford , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , dri-devel , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 1, 2019 at 4:31 AM Tomi Valkeinen wrote: > > On 01/10/2019 11:12, Tero Kristo wrote: > > On 01/10/2019 08:07, Tomi Valkeinen wrote: > >> On 30/09/2019 20:48, Tero Kristo wrote: > >> > >>> Hmmh, after some testing, it seems there is bad stuff happening with > >>> the divider clock implementation, I am re-working it as of now. > >>> Basically what is wrong is that with a divider max value of say 16, > >>> the driver attempts to craft the max value into a mask, but this ends > >>> up being 0x1f. If the max value is 15, it ends up into 0xf which is > >>> correct. > >> > >> Ok, that explains the max not working. > >> > >> It doesn't explain the other issue, where the TRM says the max div is > >> 32, but it does not work. But taking the max div from the old SoCs, > >> 16, is not correct either, as it seems that dividers up to 31 work ok. > >> > >> Tomi > >> > > > > Ok, attached a series that hopefully fixes it, any testing feedback > > welcome before I post this properly. > > > > This also supports omap36xx dpll4_m4_ck divider up-to 31, other omap3 > > family is limited to 16. Thank you! This works for me. > > Works for me. This also needs the change to dss.c to change the max from > 32 to 31. I'll send a patch for that separately. Tomi, Do you want me to push a patch to remove the CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK hack once these patches have been posted? It seems like the divider fix eliminates the need for this hack. adam > > Tomi > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Ford Subject: Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts Date: Tue, 1 Oct 2019 08:06:47 -0500 Message-ID: References: <20190510194229.20628-1-aford173@gmail.com> <854f6130-c8a8-81cb-aa76-4830f218ae54@ti.com> <0473526e-df0a-94a5-5c22-debd0084ab16@ti.com> <36369388-e9c8-22cd-8c19-e2bdf2d0389b@ti.com> <23eba53a-9304-2ceb-d97e-01891ec0b3ed@ti.com> <04306a5e-f9be-35a4-1aa1-5795d780e289@ti.com> <3777f1b1-2d9a-334b-b9e7-99dfda2ae29b@ti.com> <6cd7c9f0-cb26-588b-dfd1-faf462732549@ti.com> <202ae3b3-f72c-5b5b-4344-be22c8368cc7@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: devicetree , Tony Lindgren , "H. Nikolaus Schaller" , Linux Kernel Mailing List , dri-devel , Tero Kristo , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Linux-OMAP , Adam Ford List-Id: devicetree@vger.kernel.org T24gVHVlLCBPY3QgMSwgMjAxOSBhdCA0OjMxIEFNIFRvbWkgVmFsa2VpbmVuIDx0b21pLnZhbGtl aW5lbkB0aS5jb20+IHdyb3RlOgo+Cj4gT24gMDEvMTAvMjAxOSAxMToxMiwgVGVybyBLcmlzdG8g d3JvdGU6Cj4gPiBPbiAwMS8xMC8yMDE5IDA4OjA3LCBUb21pIFZhbGtlaW5lbiB3cm90ZToKPiA+ PiBPbiAzMC8wOS8yMDE5IDIwOjQ4LCBUZXJvIEtyaXN0byB3cm90ZToKPiA+Pgo+ID4+PiBIbW1o LCBhZnRlciBzb21lIHRlc3RpbmcsIGl0IHNlZW1zIHRoZXJlIGlzIGJhZCBzdHVmZiBoYXBwZW5p bmcgd2l0aAo+ID4+PiB0aGUgZGl2aWRlciBjbG9jayBpbXBsZW1lbnRhdGlvbiwgSSBhbSByZS13 b3JraW5nIGl0IGFzIG9mIG5vdy4KPiA+Pj4gQmFzaWNhbGx5IHdoYXQgaXMgd3JvbmcgaXMgdGhh dCB3aXRoIGEgZGl2aWRlciBtYXggdmFsdWUgb2Ygc2F5IDE2LAo+ID4+PiB0aGUgZHJpdmVyIGF0 dGVtcHRzIHRvIGNyYWZ0IHRoZSBtYXggdmFsdWUgaW50byBhIG1hc2ssIGJ1dCB0aGlzIGVuZHMK PiA+Pj4gdXAgYmVpbmcgMHgxZi4gSWYgdGhlIG1heCB2YWx1ZSBpcyAxNSwgaXQgZW5kcyB1cCBp bnRvIDB4ZiB3aGljaCBpcwo+ID4+PiBjb3JyZWN0Lgo+ID4+Cj4gPj4gT2ssIHRoYXQgZXhwbGFp bnMgdGhlIG1heCBub3Qgd29ya2luZy4KPiA+Pgo+ID4+IEl0IGRvZXNuJ3QgZXhwbGFpbiB0aGUg b3RoZXIgaXNzdWUsIHdoZXJlIHRoZSBUUk0gc2F5cyB0aGUgbWF4IGRpdiBpcwo+ID4+IDMyLCBi dXQgaXQgZG9lcyBub3Qgd29yay4gQnV0IHRha2luZyB0aGUgbWF4IGRpdiBmcm9tIHRoZSBvbGQg U29DcywKPiA+PiAxNiwgaXMgbm90IGNvcnJlY3QgZWl0aGVyLCBhcyBpdCBzZWVtcyB0aGF0IGRp dmlkZXJzIHVwIHRvIDMxIHdvcmsgb2suCj4gPj4KPiA+PiAgIFRvbWkKPiA+Pgo+ID4KPiA+IE9r LCBhdHRhY2hlZCBhIHNlcmllcyB0aGF0IGhvcGVmdWxseSBmaXhlcyBpdCwgYW55IHRlc3Rpbmcg ZmVlZGJhY2sKPiA+IHdlbGNvbWUgYmVmb3JlIEkgcG9zdCB0aGlzIHByb3Blcmx5Lgo+ID4KPiA+ IFRoaXMgYWxzbyBzdXBwb3J0cyBvbWFwMzZ4eCBkcGxsNF9tNF9jayBkaXZpZGVyIHVwLXRvIDMx LCBvdGhlciBvbWFwMwo+ID4gZmFtaWx5IGlzIGxpbWl0ZWQgdG8gMTYuCgpUaGFuayB5b3UhICBU aGlzIHdvcmtzIGZvciBtZS4KCj4KPiBXb3JrcyBmb3IgbWUuIFRoaXMgYWxzbyBuZWVkcyB0aGUg Y2hhbmdlIHRvIGRzcy5jIHRvIGNoYW5nZSB0aGUgbWF4IGZyb20KPiAzMiB0byAzMS4gSSdsbCBz ZW5kIGEgcGF0Y2ggZm9yIHRoYXQgc2VwYXJhdGVseS4KClRvbWksCgpEbyB5b3Ugd2FudCBtZSB0 byBwdXNoIGEgcGF0Y2ggdG8gcmVtb3ZlIHRoZQpDT05GSUdfT01BUDJfRFNTX01JTl9GQ0tfUEVS X1BDSyBoYWNrIG9uY2UgdGhlc2UgcGF0Y2hlcyBoYXZlIGJlZW4KcG9zdGVkPyAgSXQgc2VlbXMg bGlrZSB0aGUgZGl2aWRlciBmaXggZWxpbWluYXRlcyB0aGUgbmVlZCBmb3IgdGhpcwpoYWNrLgoK YWRhbQo+Cj4gICBUb21pCj4KPiAtLQo+IFRleGFzIEluc3RydW1lbnRzIEZpbmxhbmQgT3ksIFBv cmtrYWxhbmthdHUgMjIsIDAwMTgwIEhlbHNpbmtpLgo+IFktdHVubnVzL0J1c2luZXNzIElEOiAw NjE1NTIxLTQuIEtvdGlwYWlra2EvRG9taWNpbGU6IEhlbHNpbmtpCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==