From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE6DC433EF for ; Tue, 11 Jan 2022 16:52:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C677E80FDA; Tue, 11 Jan 2022 17:52:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="p7dk5g6Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6A3CD830AB; Tue, 11 Jan 2022 17:52:30 +0100 (CET) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3EC6E80562 for ; Tue, 11 Jan 2022 17:52:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-ed1-x533.google.com with SMTP id t24so21855941edi.8 for ; Tue, 11 Jan 2022 08:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HR9lwAS2Oal5fuTt8jxidM0WZXwjdDHe37OecZzHugY=; b=p7dk5g6YT5+A3QCRsDXqvsQTSSRXnnHBHk8dTzpOZVagu7xnr040f8AtbHtxki0BJb QjjUKg1Q29iRAHKn5NadBDGngqrWNRg4kmcLMRx9K0V6oNhqhRC7XU9MoAq7drQzv/QC uQNvvOn6xeNXZ0z2cQ+6gU4Yz133YISj3CT6F5e5stKhok95VNRVRCWspOpjbZbJgTMc cHHS45vAI5FXNxwUpdHTeTVsHujiFYSdrMxKqyViV0zftIkwxvQlbgXt2DXEtUrqP/6A jk6ZRjwcdu+QmnCtLbt6NHe5d/yRVR0hJ5lIt2EnO5z9GoIrkdIkm23KmXlBcG+2Te8t AKkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HR9lwAS2Oal5fuTt8jxidM0WZXwjdDHe37OecZzHugY=; b=rvY0Jxrsovnyj9GNrqBcA+BJSn5c8b1reRd86RF1JIVTGxySMoSYVuDfXphNjUKkm9 QIJa5Y+/eh9fkjWgPT1aJ67xO4eq9LnBUKv3JPmMuWMmOo29Se9ZIogLgfClCxOLjgZ5 ZaIV0E3OZKbpStouzNMLvnkjAQHO1gx/9j8kDetLFJykmes3kLeYImGCTnWDx/LBxe7x vf8Lm//Je35mcB/zUZAIITOA72kv5a7BDw7LFCtLSrewkBKF7EZIWcBE5fMhMlub0HHv LOi/aZzAavLirCTEfbowu0mjs+gDhaqS/CwvuyUHUBYvO3qsXzq8wQmZVDPkQIQBoDeX BwEg== X-Gm-Message-State: AOAM532r7w+Cn57F2l3LcdjCZJ5cBvC7ZrDQ160T4u+PMQCsl/um4Ht7 GZdHRX7CFB18NF7767niGOckUfC0wUNEruSpXog= X-Google-Smtp-Source: ABdhPJzVvf4LDcbjrUEXK3IvvmrFckQXr5GNeJCaOUtRDRpbJbqiQnoCQn6qQAsAoaINbar/6tUMuQYCa6bM9fqrssc= X-Received: by 2002:a05:6402:1d50:: with SMTP id dz16mr5269708edb.348.1641919946322; Tue, 11 Jan 2022 08:52:26 -0800 (PST) MIME-Version: 1.0 References: <20211223140756.304527-1-aford173@gmail.com> <20220104083148.1328623-1-michael@walle.cc> In-Reply-To: From: Adam Ford Date: Tue, 11 Jan 2022 10:52:15 -0600 Message-ID: Subject: Re: [PATCH V2] usb: ehci-mx6: Enable OTG detection on imx8mm and imx8mn To: Michael Walle Cc: Fabio Estevam , Marek Vasut , Simon Glass , U-Boot Mailing List , Tim Harvey Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Jan 11, 2022 at 9:31 AM Michael Walle wrote: > > Hi, > > Am 2022-01-11 15:20, schrieb Adam Ford: > > On Tue, Jan 4, 2022 at 2:32 AM Michael Walle wrote: > >> > The imx8mm and imx8mn appear compatible with imx7d-usb > >> > flags in the OTG driver. If the dr_mode is defined as > >> > host or peripheral, the device appears to operate correctly, > >> > however the auto host/peripheral detection results in an error. > >> > > >> > The solution isn't just adding checks for imx8mm and imx8mn to > >> > the check for imx7, because the USB clock needs to be running > >> > to read from the USBNC_PHY_STATUS_OFFSET register or it will hang. > >> > > >> > The init_type in both priv and plat data are the same, so it doesn't > >> > make sense to configure the data in the plat data and copy the > >> > data to priv when priv can be configured directly. Instead, rename > >> > ehci_usb_of_to_plat to ehci_usb_dr_mode and call it from the > >> > probe functions after the clocks are enabled, but before the data > >> > is required. > >> > > >> > With that added, the additional checks for imx8mm and imx8mn will > >> > allow reading the register to automatically determine the state > >> > (host or device) of the OTG controller. > >> > > >> > Signed-off-by: Adam Ford > >> > --- > >> > V2: Rename ehci_usb_of_to_plat to ehci_usb_dr_mode and call it > >> > from the probe after the clocks are enabled, but before > >> > the data is needed. > >> > > >> > diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c > >> > index 1bd6147c76..f2a34b7f06 100644 > >> > --- a/drivers/usb/host/ehci-mx6.c > >> > +++ b/drivers/usb/host/ehci-mx6.c > >> > >> .. > >> > >> > @@ -639,10 +639,8 @@ static int mx6_parse_dt_addrs(struct udevice *dev) > >> > > >> > static int ehci_usb_probe(struct udevice *dev) > >> > { > >> > - struct usb_plat *plat = dev_get_plat(dev); > >> > struct usb_ehci *ehci = dev_read_addr_ptr(dev); > >> > struct ehci_mx6_priv_data *priv = dev_get_priv(dev); > >> > - enum usb_init_type type = plat->init_type; > >> > struct ehci_hccr *hccr; > >> > struct ehci_hcor *hcor; > >> > int ret; > >> > @@ -660,8 +658,6 @@ static int ehci_usb_probe(struct udevice *dev) > >> > return ret; > >> > > >> > priv->ehci = ehci; > >> > - priv->init_type = type; > >> > > > > Michael, > > > >> I'm not sure this is correct. There is also this: > >> https://elixir.bootlin.com/u-boot/v2022.01-rc4/source/drivers/usb/host/usb-uclass.c#L407 > >> > > > > Further down in the code, you should see: > > priv->phy_type = usb_get_phy_mode(dev_ofnode(dev)); > > But that is just fetching the mode from the device tree, the > usb_setup_ehci_gadget() referenced above, change the mode during > runtime by writing the plat->init_type and reprobing the device. > > >> Which won't work anymore. usb_setup_ehci_gadget() is called from > >> usb_gadget_register_driver() in ci_udc.c. The latter is the one used > >> on the imx, right? But I might be wrong. I'm still trying to figure > >> out how this all works together, because I also try to get OTG > >> running on the dwc3 driver. It looks like the ci_udc.c is special > >> here, and I wonder how a transition to UCLASS_USB_GADGET_GENERIC > >> might look like for this driver. > > > > This driver really isn't changing anything, it's just an order of > > operations. > > It doesn't use the plat->init_type at all anymore, no? >From what I could tell, the only thing that plat->init_type did was to set priv->init_type. The priv structure appears to do most of the work. > > > Previously there was a separate that was being called to > > determine the init_type as being either a peripheral or host. If it > > wasn't explicitly set in the device tree, the helper function would > > query a register, however, on the imx8mm and imx8mn platforms, the > > clocks were not running which resulted in a hang. What I've done is > > simply move the helper function into the probe and have it run after > > the clocks start. In theory the register values will be the same as > > they would be with the help function still in place. > > > > Both Tim Harvey and I have tested on an imx8mm and Fabio tested it on > > an imx7. For me, the peripheral mode worked when the ID pin of the > > USB-OTG was not grounded. When it was grounded, the system corrected > > identified it as a host and I was able to mount a USB drive. > > Again, I'm missing something here, but the only user of > usb_setup_ehci_gadget() is usb/gadget/ci_udc.c. I can't speak to what those functions do. What are you suggesting that I do differently? adam > > -michael