From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CADF8C77B7E for ; Mon, 29 May 2023 17:45:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E3B098474E; Mon, 29 May 2023 19:45:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ArH3ZN9E"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C686C84728; Mon, 29 May 2023 19:45:54 +0200 (CEST) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9149085727 for ; Mon, 29 May 2023 19:45:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1b041cceb16so10930125ad.2 for ; Mon, 29 May 2023 10:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685382350; x=1687974350; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lBz7JPmsZMXWPdpeRUKx1il6gwQS2YjaH5WLyao8q7U=; b=ArH3ZN9ElyeBLDYftlXI589c1aYI/xNTJdebV7zIgEAqVUb5WYcd8cM5rIT2jiP6Eb xTcYHLsn9ZPeK1sy0PFsz9KoljkPE0dr73att4kvguheAPR4OqOKEZAdtl/q6FRVnd2w RuQmYB6V38QC9As/MKCrgNTRjsQL7Kuj1M/oEN9hLEVnhPKAy+t/ubpuJkgqWD38n8Za oQSiMrIyICiBdX/oqTeBZ4S4RkEmbAup5C/MO7k+b2zQ6ywqO6suUT36MTUUIFJB5Wf+ GeuQD93x1ZzAFYPmKD82chn2c+oyF3AkiuzLDJMFXNIUReF864DMb+MxRwJMilmPpAko cddQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685382350; x=1687974350; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lBz7JPmsZMXWPdpeRUKx1il6gwQS2YjaH5WLyao8q7U=; b=ZNad3kG+UbaOlv6A157onShIsXEHfJ+lM3HWu0rlRceAtdUOGHfIB8LfNHhbLnJmdQ 7wPGL2qK0oV02q4nsRecXfIKke1gTZz+L+phuwC7f1QPSmXy5O/OmH8su8nqKeBx0P9C v7chTfB3QouTlb9voPQpEe1D/6CaJ5rZ/FD/c06KP9xGKgWnlQRb20rNROFS320vGxWn lsB6zE2kNRsFqU3+j9fUOFlPM64l983Wxi4i2/TP1bbc10/hKiwjaWS6Iun+0msgnk7e AYuqn4SMwHuq6eK6ZOnPXooAJyP80e/pu5UJXalPsLVWjXqa6GhN+QTnomSE8NaYcUP8 u7kw== X-Gm-Message-State: AC+VfDxrU9R1AOid0KLrVm99chUbPzYs8ZlUF/79bXKTqzlTexmh8+Rc uXRLRQT5a34u3drVIbtb7TNcIJ/B69q44Rk/eMM= X-Google-Smtp-Source: ACHHUZ6k8y8VHnxWS3k73PNkXpEeg/0KvZusbUW9+9e2wzDdPhs4ARdFhimtIRrXRfmxzkZJ+isrpmHPE1vdlfgbHUo= X-Received: by 2002:a17:902:b18f:b0:1af:babd:7b84 with SMTP id s15-20020a170902b18f00b001afbabd7b84mr9063292plr.41.1685382349614; Mon, 29 May 2023 10:45:49 -0700 (PDT) MIME-Version: 1.0 References: <20230427180845.127439-1-festevam@gmail.com> <20230427180845.127439-3-festevam@gmail.com> In-Reply-To: From: Adam Ford Date: Mon, 29 May 2023 12:45:38 -0500 Message-ID: Subject: Re: [PATCH 3/3] arm: dts: imx8mp: Sync with Linux 6.3 To: Fabio Estevam Cc: Tim Harvey , sbabic@denx.de, u-boot@lists.denx.de, Fabio Estevam Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, May 24, 2023 at 9:02=E2=80=AFPM Fabio Estevam = wrote: > > Hi Tim, > > On Fri, May 19, 2023 at 8:00=E2=80=AFPM Tim Harvey wrote: > > > Fabio, + Marek I am adding Marek since he did the HSIO power domain driver. > > > > There's more to be done here also. With this patch, and with the > > spba-bus added to u-boot.dtsi, if you try to enable usb (usb start) > > you get: > > starting USB... > > Bus usb@38200000: > > Enable clock-controller@30380000 failed > > probe failed, error -2 > > No working controllers found > > Does this help? A bit. I finally got some time to try to troubleshoot USB on my 8MP. > > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -337,8 +337,8 @@ static int imx8mp_clk_probe(struct udevice *dev) > clk_dm(IMX8MP_CLK_UART2_ROOT, imx_clk_gate4("uart2_root_clk", > "uart2", base + 0x44a0, 0)); > clk_dm(IMX8MP_CLK_UART3_ROOT, imx_clk_gate4("uart3_root_clk", > "uart3", base + 0x44b0, 0)); > clk_dm(IMX8MP_CLK_UART4_ROOT, imx_clk_gate4("uart4_root_clk", > "uart4", base + 0x44c0, 0)); > - clk_dm(IMX8MP_CLK_USB_ROOT, imx_clk_gate4("usb_root_clk", > "usb_core_ref", base + 0x44d0, 0)); > - clk_dm(IMX8MP_CLK_USB_PHY_ROOT, IMX8MP_CLK_USB_PHY_ROOT is also referenced in the device tree, so I don't think we can delete it. I had keep IMX8MP_CLK_USB_ROOT, and IMX8MP_CLK_USB_PHY_ROOT while also adding IMX8MP_CLK_USB_SUSP. > imx_clk_gate4("usb_phy_root_clk", "usb_phy_ref", base + 0x44f0, 0)); > + clk_dm(IMX8MP_CLK_USB_ROOT, imx_clk_gate4("usb_root_clk", > "hsio_axi", base + 0x44d0, 0)); > + clk_dm(IMX8MP_CLK_USB_SUSP, imx_clk_gate4("usb_suspend_clk", > "osc_32k", base + 0x44d0, 0)); > clk_dm(IMX8MP_CLK_USDHC1_ROOT, > imx_clk_gate4("usdhc1_root_clk", "usdhc1", base + 0x4510, 0)); > clk_dm(IMX8MP_CLK_USDHC2_ROOT, > imx_clk_gate4("usdhc2_root_clk", "usdhc2", base + 0x4520, 0)); > clk_dm(IMX8MP_CLK_WDOG1_ROOT, imx_clk_gate4("wdog1_root_clk", > "wdog", base + 0x4530, 0)); At this point, the missing clock errors go away, but it hangs. I updated my 8MP USB clocks based on the latest Linux kernel so my clocks looks like: clk_dm(IMX8MP_CLK_USB_ROOT, imx_clk_gate2("usb_root_clk", "hsio_axi", base + 0x44d0, 0)); clk_dm(IMX8MP_CLK_USB_SUSP, imx_clk_gate2("usb_suspend_clk", "clock-osc-24m", base + 0x44d0, 0)); clk_dm(IMX8MP_CLK_USB_PHY_ROOT, imx_clk_gate4("usb_phy_root_clk", "usb_phy_ref", base + 0x44f0, 0)); The linux kernel uses gate2 for USB_ROOT and USB_SUSP while gate4 is used for IMX8MP_CLK_USB_PHY_ROOT. I didn't verify this against the reference manual. With some debugging enabled, it looks to me like it might be power-domain related, but I am not 100% certain. When I start the USB, it appears to go through some clocks, and start one power domain, but I think we have a power-domain chain where one power domain starts another. I saw a patch on another thread for enabling parent power-domains, but it didn't seem to help me. u-boot=3D> usb start starting USB... Bus usb@38200000: ofnode_read_prop: maximum-speed: ofnode_read_prop: dr_mode: host dev_power_domain_on usb@32f10108 ofnode_read_prop: assigned-clock-rates: Looking for clock-controller@30380000 Looking for clock-controller@30380000 - result for clock-controller@30380000: clock-controller@30380000 (ret= =3D0) - result for clock-controller@30380000: clock-controller@30380000 (ret= =3D0) Looking for clock-controller@30380000 Looking for clock-controller@30380000 - result for clock-controller@30380000: clock-controller@30380000 (ret= =3D0) - result for clock-controller@30380000: clock-controller@30380000 (ret= =3D0) ofnode_read_prop: dr_mode: host I added some debug code to the imx8mp_hsiomix_on in HSIOmix power domain driver, and it doesn't appear to be getting called, yet dev_power_domain_on usb@32f10108 should be invoking it. I am not positive it's a power domain issue, that's my first guess. Tim - have you had any success? adam