From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C9E3C3DA7A for ; Fri, 6 Jan 2023 14:34:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC4F310E010; Fri, 6 Jan 2023 14:34:46 +0000 (UTC) Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3E1710E010 for ; Fri, 6 Jan 2023 14:34:42 +0000 (UTC) Received: by mail-pj1-x102e.google.com with SMTP id fz16-20020a17090b025000b002269d6c2d83so5963228pjb.0 for ; Fri, 06 Jan 2023 06:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7ZaYPy2tPVFksG/KUTGQyNyi3qYzIkXR+MVojde5xOo=; b=iuKyNvVsyi+JoRiZKQ5M642RXQ+jrigvnNAyN4XUob3BjJOPOvoY4N659ySXW/w/eU 5LXGUwga9nfjeOHeHwV4Xkmygovebw1LCaU4RIQ1wjG7VJ3vGCNOmMzbMQz8ui/esgOK pM2ZgxWxLbt9QEQTuJ9jU9z/U2cBT2Y/m7uvSTDRAZYPe/A3OXYA/l3V9rg+dpkOew2B vT/TR59O9nVDdUTKkIskOK75NCtriixC1I8E+Bli16Z17lLD9+aOASIBH1dzwLrXSyuU xrHFBs1O1DIvFkPy4tJoHn3ZXX7MrjnxRNhonNgueupaVTphNAu4G2nQdoJaQJQspsi0 zifQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7ZaYPy2tPVFksG/KUTGQyNyi3qYzIkXR+MVojde5xOo=; b=n0pCVf0sspCm2OFO8/2P6Gfv6lp5JnpLVk3IkJATR6Jkm928p5bMTOxVUA0mTtTf3Q PT/vds06nA4UO/vqLGs7i+RGsVjp8QstNQzDFaRZDepAIyJ60ALtyCCUO3/OYiMaW9I7 /qOTfToEku87HKAseQutvHruQeuTwqM4N3Zvuwxkeitd9b3jWUUqoAwqz6kE8QY3ARBz AbvxlYKHI2JgI57JID2nfGJm8tA79LPlmPGYKbedi6HcXqvFu6fzgtPdd8y5Xf0fXKBY LB6Wn5cE9+oRhv1noBTCHTlVJ30n4DhgsnCXPd4yu7Lo+9xE2e6yagvGaPqAsg+v1wEW NxIA== X-Gm-Message-State: AFqh2kqfGPb8V9zgZrYNldw2UyuEBATitvWqE/rRsadcnupK7oFk0gV6 iSNUfgTtLBOByBFO6CLwnhJFOg9lkIGvWX/nJsM= X-Google-Smtp-Source: AMrXdXtgXMVF9F+kBpfmC6kWHetjRYrPuuzz4gzUJuQ9KVBKzTvk0uO/wT2FJSA7o0+qxu8gdyTuTAZty2ADOJM+55A= X-Received: by 2002:a17:902:7e41:b0:192:5aae:c828 with SMTP id a1-20020a1709027e4100b001925aaec828mr2263552pln.125.1673015682162; Fri, 06 Jan 2023 06:34:42 -0800 (PST) MIME-Version: 1.0 References: <20221214125907.376148-1-jagan@amarulasolutions.com> In-Reply-To: From: Adam Ford Date: Fri, 6 Jan 2023 08:34:30 -0600 Message-ID: Subject: Re: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge To: Jagan Teki Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , linux-samsung-soc@vger.kernel.org, Laurent Pinchart , Joonyoung Shim , dri-devel@lists.freedesktop.org, Tommaso Merciai , Seung-Woo Kim , Neil Armstrong , Frieder Schrempf , Kyungmin Park , Matteo Lisi , Robert Foss , Andrzej Hajda , NXP Linux Team , Fancy Fang , Michael Nazzareno Trimarchi , linux-amarula , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 5, 2023 at 4:24 AM Jagan Teki wrote: > > On Wed, Dec 14, 2022 at 6:29 PM Jagan Teki wrote: > > > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. > > > > Patch 0001 - 0004: adding devm_drm_of_dsi_get_bridge > > > > Patch 0005 - 0006: optional PHY, PMS_P offset > > > > Patch 0007 : introduce hw_type > > > > Patch 0008 : fixing host init > > > > Patch 0009 : atomic_check > > > > Patch 0010 : input_bus_flags > > > > Patch 0011 : atomic_get_input_bus_fmts > > > > Patch 0012 - 0013: component vs bridge > > > > Patch 0014 : DSIM bridge > > > > Patch 0015 - 0016: i.MX8M Mini/Nano > > > > Patch 0017 - 0018: i.MX8M Plus > > > > Changes for v10: > > - rebase on drm-misc-next > > - add drm_of_dsi_find_panel_or_bridge > > - add devm_drm_of_dsi_get_bridge > > - fix host initialization (Thanks to Marek Szyprowski) > > - rearrange the tiny patches for easy to review > > - update simple names for enum hw_type > > - add is_hw_exynos macro > > - rework on commit messages > > > > Changes for v9: > > - rebase on drm-misc-next > > - drop drm bridge attach fix for Exynos > > - added prepare_prev_first flag > > - added pre_enable_prev_first flag > > - fix bridge chain order for exynos > > - added fix for Exynos host init for first DSI transfer > > - added MEDIA_BUS_FMT_FIXED > > - return MEDIA_BUS_FMT_RGB888_1X24 output_fmt if supported output_fmt > > list is unsupported. > > - added MEDIA_BUS_FMT_YUYV10_1X20 > > - added MEDIA_BUS_FMT_YUYV12_1X24 > > > > Changes for v8: > > * fixed comment lines > > * fixed commit messages > > * fixed video mode bits > > * collect Marek Ack > > * fixed video mode bit names > > * update input formats logic > > * added imx8mplus support > > > > Changes for v7: > > * fix the drm bridge attach chain for exynos drm dsi driver > > * fix the hw_type checking logic > > > > Changes for v6: > > * handle previous bridge for exynos dsi while attaching bridge > > > > Changes for v5: > > * bridge changes to support multi-arch > > * updated and clear commit messages > > * add hw_type via plat data > > * removed unneeded quirk > > * rebased on linux-next > > > > Changes for v4: > > * include Inki Dae in MAINTAINERS > > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > > * update init handling to ensure host init done on first cmd transfer > > > > Changes for v3: > > * fix the mult-arch build > > * fix dsi host init > > * updated commit messages > > > > Changes for v2: > > * fix bridge handling > > * fix dsi host init > > * correct the commit messages > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > Repo: > > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v10 > > > > v9: > > https://lore.kernel.org/all/20221209152343.180139-1-jagan@amarulasolutions.com/ > > > > Any inputs? > > Jagan. > > > > Jagan Teki (16): > > drm: of: Lookup if child node has DSI panel or bridge > > drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper > > drm: exynos: dsi: Drop explicit call to bridge detach > > drm: exynos: dsi: Switch to devm_drm_of_dsi_get_bridge > > drm: exynos: dsi: Mark PHY as optional > > drm: exynos: dsi: Add platform PLL_P (PMS_P) offset > > drm: exynos: dsi: Introduce hw_type platform data > > drm: exynos: dsi: Add atomic check > > drm: exynos: dsi: Add input_bus_flags > > drm: exynos: dsi: Add atomic_get_input_bus_fmts > > drm: exynos: dsi: Consolidate component and bridge > > drm: exynos: dsi: Add Exynos based host irq hooks > > drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support > > drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support > > > > Marek Szyprowski (1): > > drm: exynos: dsi: Handle proper host initialization > > > > Marek Vasut (1): > > drm: bridge: samsung-dsim: Add i.MX8M Plus support > > Does anyone have any other comments on this? I would like to send v11 > with a few nits on v10. Please let me know. I got it working on an LVDS display that I have, but I didn't get it working on the HDMI bridge. Since we have a few tested-by people, it'd be nice to see this integrated so we can work on ading more functionality adam > > Thanks, > Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F326EC5479D for ; Fri, 6 Jan 2023 14:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235500AbjAFOfZ (ORCPT ); Fri, 6 Jan 2023 09:35:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235156AbjAFOez (ORCPT ); Fri, 6 Jan 2023 09:34:55 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBFEF41663 for ; Fri, 6 Jan 2023 06:34:42 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id c8-20020a17090a4d0800b00225c3614161so5330324pjg.5 for ; Fri, 06 Jan 2023 06:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7ZaYPy2tPVFksG/KUTGQyNyi3qYzIkXR+MVojde5xOo=; b=iuKyNvVsyi+JoRiZKQ5M642RXQ+jrigvnNAyN4XUob3BjJOPOvoY4N659ySXW/w/eU 5LXGUwga9nfjeOHeHwV4Xkmygovebw1LCaU4RIQ1wjG7VJ3vGCNOmMzbMQz8ui/esgOK pM2ZgxWxLbt9QEQTuJ9jU9z/U2cBT2Y/m7uvSTDRAZYPe/A3OXYA/l3V9rg+dpkOew2B vT/TR59O9nVDdUTKkIskOK75NCtriixC1I8E+Bli16Z17lLD9+aOASIBH1dzwLrXSyuU xrHFBs1O1DIvFkPy4tJoHn3ZXX7MrjnxRNhonNgueupaVTphNAu4G2nQdoJaQJQspsi0 zifQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7ZaYPy2tPVFksG/KUTGQyNyi3qYzIkXR+MVojde5xOo=; b=XRI/gX2I12xYsvoNWMH5lHwt3qq2B1KQGFft3xPe+/xw+4kii5u0/Sx5CPl736tCsy hqII3XDA636D0qh2JEKzvmReTWODslDj0arc9l+Fz6XGAWFQ+qxNLefATY8qHuaNubig dHOZ0HCTUTN/1/S5s8N8jQAIW9xG9UQuZf6tnJPZj+XBaxjSaNlCQsvEycRKe6O8/5zz mQKyD2uSohlXh+jzOQLEUuIPw/jUnSOl160tIatcrgWsrI20BZN63wgpD7oSXB4Lv0ni mYgIeprXPYYu/zsDUUsve9kmpHWGh1JEBTZ/1Jiokhyc2jlqJ5bARrLvmtNEo2dX5ynm myvQ== X-Gm-Message-State: AFqh2krxJnzj6rrpKIiUV7ngCYdxeBbXv5Nzl8PhCvz/n+4lZjN+pXFf X1H8PYCgJbpSB025KCbpUIbR8rDTRLDkRiVidFo= X-Google-Smtp-Source: AMrXdXtgXMVF9F+kBpfmC6kWHetjRYrPuuzz4gzUJuQ9KVBKzTvk0uO/wT2FJSA7o0+qxu8gdyTuTAZty2ADOJM+55A= X-Received: by 2002:a17:902:7e41:b0:192:5aae:c828 with SMTP id a1-20020a1709027e4100b001925aaec828mr2263552pln.125.1673015682162; Fri, 06 Jan 2023 06:34:42 -0800 (PST) MIME-Version: 1.0 References: <20221214125907.376148-1-jagan@amarulasolutions.com> In-Reply-To: From: Adam Ford Date: Fri, 6 Jan 2023 08:34:30 -0600 Message-ID: Subject: Re: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge To: Jagan Teki Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, Jan 5, 2023 at 4:24 AM Jagan Teki wrote: > > On Wed, Dec 14, 2022 at 6:29 PM Jagan Teki wrote: > > > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. > > > > Patch 0001 - 0004: adding devm_drm_of_dsi_get_bridge > > > > Patch 0005 - 0006: optional PHY, PMS_P offset > > > > Patch 0007 : introduce hw_type > > > > Patch 0008 : fixing host init > > > > Patch 0009 : atomic_check > > > > Patch 0010 : input_bus_flags > > > > Patch 0011 : atomic_get_input_bus_fmts > > > > Patch 0012 - 0013: component vs bridge > > > > Patch 0014 : DSIM bridge > > > > Patch 0015 - 0016: i.MX8M Mini/Nano > > > > Patch 0017 - 0018: i.MX8M Plus > > > > Changes for v10: > > - rebase on drm-misc-next > > - add drm_of_dsi_find_panel_or_bridge > > - add devm_drm_of_dsi_get_bridge > > - fix host initialization (Thanks to Marek Szyprowski) > > - rearrange the tiny patches for easy to review > > - update simple names for enum hw_type > > - add is_hw_exynos macro > > - rework on commit messages > > > > Changes for v9: > > - rebase on drm-misc-next > > - drop drm bridge attach fix for Exynos > > - added prepare_prev_first flag > > - added pre_enable_prev_first flag > > - fix bridge chain order for exynos > > - added fix for Exynos host init for first DSI transfer > > - added MEDIA_BUS_FMT_FIXED > > - return MEDIA_BUS_FMT_RGB888_1X24 output_fmt if supported output_fmt > > list is unsupported. > > - added MEDIA_BUS_FMT_YUYV10_1X20 > > - added MEDIA_BUS_FMT_YUYV12_1X24 > > > > Changes for v8: > > * fixed comment lines > > * fixed commit messages > > * fixed video mode bits > > * collect Marek Ack > > * fixed video mode bit names > > * update input formats logic > > * added imx8mplus support > > > > Changes for v7: > > * fix the drm bridge attach chain for exynos drm dsi driver > > * fix the hw_type checking logic > > > > Changes for v6: > > * handle previous bridge for exynos dsi while attaching bridge > > > > Changes for v5: > > * bridge changes to support multi-arch > > * updated and clear commit messages > > * add hw_type via plat data > > * removed unneeded quirk > > * rebased on linux-next > > > > Changes for v4: > > * include Inki Dae in MAINTAINERS > > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > > * update init handling to ensure host init done on first cmd transfer > > > > Changes for v3: > > * fix the mult-arch build > > * fix dsi host init > > * updated commit messages > > > > Changes for v2: > > * fix bridge handling > > * fix dsi host init > > * correct the commit messages > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > Repo: > > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v10 > > > > v9: > > https://lore.kernel.org/all/20221209152343.180139-1-jagan@amarulasolutions.com/ > > > > Any inputs? > > Jagan. > > > > Jagan Teki (16): > > drm: of: Lookup if child node has DSI panel or bridge > > drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper > > drm: exynos: dsi: Drop explicit call to bridge detach > > drm: exynos: dsi: Switch to devm_drm_of_dsi_get_bridge > > drm: exynos: dsi: Mark PHY as optional > > drm: exynos: dsi: Add platform PLL_P (PMS_P) offset > > drm: exynos: dsi: Introduce hw_type platform data > > drm: exynos: dsi: Add atomic check > > drm: exynos: dsi: Add input_bus_flags > > drm: exynos: dsi: Add atomic_get_input_bus_fmts > > drm: exynos: dsi: Consolidate component and bridge > > drm: exynos: dsi: Add Exynos based host irq hooks > > drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support > > drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support > > > > Marek Szyprowski (1): > > drm: exynos: dsi: Handle proper host initialization > > > > Marek Vasut (1): > > drm: bridge: samsung-dsim: Add i.MX8M Plus support > > Does anyone have any other comments on this? I would like to send v11 > with a few nits on v10. Please let me know. I got it working on an LVDS display that I have, but I didn't get it working on the HDMI bridge. Since we have a few tested-by people, it'd be nice to see this integrated so we can work on ading more functionality adam > > Thanks, > Jagan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8622C4708D for ; Fri, 6 Jan 2023 14:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wvYVrNAybb3jmp4H6gLWk9ugdnNCNQjjn2c36vsOQLk=; b=KebTcDrPz/sjOf lD/7WFFrkHjwvOoAXWqhFCH38/+hPcRm5QigYuS4niK9+TCIPG3WkblPEoGxrACcrcxikhkPGS4rK 4oB6d1AFQPfhHUuCobZZyEqrtpIDS5dZsz13vQ4isxstaKwa18ENcJJZA/bzLvjWGgMDbTrLjXWeD QSf+qooj2OgWV6SKF+ceUMPvk3p0dzFzkZk/j4YfnDcj6FENYT0UN+MSQDxCuxPEd9xRorO8yOceS 70uh8m5VzlvqVn0H/y8cBKzurnGAWY2OlE1MQPgC6Yf8TVXdzN84IwxyTLsvg8iq0xtcgVG7Ec67e K0/jwtvAhQ9XR54T1H6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDno0-008pZX-1u; Fri, 06 Jan 2023 14:34:48 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDnnw-008pYZ-IJ for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 14:34:46 +0000 Received: by mail-pl1-x62b.google.com with SMTP id n4so1849668plp.1 for ; Fri, 06 Jan 2023 06:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7ZaYPy2tPVFksG/KUTGQyNyi3qYzIkXR+MVojde5xOo=; b=iuKyNvVsyi+JoRiZKQ5M642RXQ+jrigvnNAyN4XUob3BjJOPOvoY4N659ySXW/w/eU 5LXGUwga9nfjeOHeHwV4Xkmygovebw1LCaU4RIQ1wjG7VJ3vGCNOmMzbMQz8ui/esgOK pM2ZgxWxLbt9QEQTuJ9jU9z/U2cBT2Y/m7uvSTDRAZYPe/A3OXYA/l3V9rg+dpkOew2B vT/TR59O9nVDdUTKkIskOK75NCtriixC1I8E+Bli16Z17lLD9+aOASIBH1dzwLrXSyuU xrHFBs1O1DIvFkPy4tJoHn3ZXX7MrjnxRNhonNgueupaVTphNAu4G2nQdoJaQJQspsi0 zifQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7ZaYPy2tPVFksG/KUTGQyNyi3qYzIkXR+MVojde5xOo=; b=O9qWN4tlq9yrYuubTDAkUypcDVolL6jVNQUNkbmQytuF5RAxxeBjyNg6Fnat3gCzM0 6Fa0e6fVravKfeGtd2m6TU+0EcvO+Vi82YfI3KUfVEmkF+jUEJGZd7a9sekPmlyTn2N5 QJfuncupXxtsrgvGzOf23DGGzQe6Ft7d4Ju1xtEN1ZE95+4y+t6T2e/llVSBylXuwilf MJC1pQ7ngJXaQqsorU5IJ0Dhz9PpPUHVSWRrsfmyQBXnGGa2cnlU6nwoeDRvheu1uPOf 5cX/9BwsqtxluuL0g8eUoGSu5aeECtEloqsgqlxORmO4tRcUXYp6L2YZimONb5ybMS3Y Kt2A== X-Gm-Message-State: AFqh2kpW0+fRzbcDo4MZNP0GLx6Ai/iZE/TGFeDhua7I5C8uMO87Xhas 5LxnDcNgSEGzzhkRn9MAdBtA55QoL2RllEYxJhQSGOsL X-Google-Smtp-Source: AMrXdXtgXMVF9F+kBpfmC6kWHetjRYrPuuzz4gzUJuQ9KVBKzTvk0uO/wT2FJSA7o0+qxu8gdyTuTAZty2ADOJM+55A= X-Received: by 2002:a17:902:7e41:b0:192:5aae:c828 with SMTP id a1-20020a1709027e4100b001925aaec828mr2263552pln.125.1673015682162; Fri, 06 Jan 2023 06:34:42 -0800 (PST) MIME-Version: 1.0 References: <20221214125907.376148-1-jagan@amarulasolutions.com> In-Reply-To: From: Adam Ford Date: Fri, 6 Jan 2023 08:34:30 -0600 Message-ID: Subject: Re: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge To: Jagan Teki Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_063444_630051_E5879B69 X-CRM114-Status: GOOD ( 29.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 5, 2023 at 4:24 AM Jagan Teki wrote: > > On Wed, Dec 14, 2022 at 6:29 PM Jagan Teki wrote: > > > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. > > > > Patch 0001 - 0004: adding devm_drm_of_dsi_get_bridge > > > > Patch 0005 - 0006: optional PHY, PMS_P offset > > > > Patch 0007 : introduce hw_type > > > > Patch 0008 : fixing host init > > > > Patch 0009 : atomic_check > > > > Patch 0010 : input_bus_flags > > > > Patch 0011 : atomic_get_input_bus_fmts > > > > Patch 0012 - 0013: component vs bridge > > > > Patch 0014 : DSIM bridge > > > > Patch 0015 - 0016: i.MX8M Mini/Nano > > > > Patch 0017 - 0018: i.MX8M Plus > > > > Changes for v10: > > - rebase on drm-misc-next > > - add drm_of_dsi_find_panel_or_bridge > > - add devm_drm_of_dsi_get_bridge > > - fix host initialization (Thanks to Marek Szyprowski) > > - rearrange the tiny patches for easy to review > > - update simple names for enum hw_type > > - add is_hw_exynos macro > > - rework on commit messages > > > > Changes for v9: > > - rebase on drm-misc-next > > - drop drm bridge attach fix for Exynos > > - added prepare_prev_first flag > > - added pre_enable_prev_first flag > > - fix bridge chain order for exynos > > - added fix for Exynos host init for first DSI transfer > > - added MEDIA_BUS_FMT_FIXED > > - return MEDIA_BUS_FMT_RGB888_1X24 output_fmt if supported output_fmt > > list is unsupported. > > - added MEDIA_BUS_FMT_YUYV10_1X20 > > - added MEDIA_BUS_FMT_YUYV12_1X24 > > > > Changes for v8: > > * fixed comment lines > > * fixed commit messages > > * fixed video mode bits > > * collect Marek Ack > > * fixed video mode bit names > > * update input formats logic > > * added imx8mplus support > > > > Changes for v7: > > * fix the drm bridge attach chain for exynos drm dsi driver > > * fix the hw_type checking logic > > > > Changes for v6: > > * handle previous bridge for exynos dsi while attaching bridge > > > > Changes for v5: > > * bridge changes to support multi-arch > > * updated and clear commit messages > > * add hw_type via plat data > > * removed unneeded quirk > > * rebased on linux-next > > > > Changes for v4: > > * include Inki Dae in MAINTAINERS > > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > > * update init handling to ensure host init done on first cmd transfer > > > > Changes for v3: > > * fix the mult-arch build > > * fix dsi host init > > * updated commit messages > > > > Changes for v2: > > * fix bridge handling > > * fix dsi host init > > * correct the commit messages > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > Repo: > > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v10 > > > > v9: > > https://lore.kernel.org/all/20221209152343.180139-1-jagan@amarulasolutions.com/ > > > > Any inputs? > > Jagan. > > > > Jagan Teki (16): > > drm: of: Lookup if child node has DSI panel or bridge > > drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper > > drm: exynos: dsi: Drop explicit call to bridge detach > > drm: exynos: dsi: Switch to devm_drm_of_dsi_get_bridge > > drm: exynos: dsi: Mark PHY as optional > > drm: exynos: dsi: Add platform PLL_P (PMS_P) offset > > drm: exynos: dsi: Introduce hw_type platform data > > drm: exynos: dsi: Add atomic check > > drm: exynos: dsi: Add input_bus_flags > > drm: exynos: dsi: Add atomic_get_input_bus_fmts > > drm: exynos: dsi: Consolidate component and bridge > > drm: exynos: dsi: Add Exynos based host irq hooks > > drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support > > drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support > > > > Marek Szyprowski (1): > > drm: exynos: dsi: Handle proper host initialization > > > > Marek Vasut (1): > > drm: bridge: samsung-dsim: Add i.MX8M Plus support > > Does anyone have any other comments on this? I would like to send v11 > with a few nits on v10. Please let me know. I got it working on an LVDS display that I have, but I didn't get it working on the HDMI bridge. Since we have a few tested-by people, it'd be nice to see this integrated so we can work on ading more functionality adam > > Thanks, > Jagan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel