From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20141003102023.GA8095@t440s.lan> References: <1412325293-6651-1-git-send-email-fons@spotify.com> <7F79038B-2FA8-4DF5-B25A-D7E9AAE922A8@holtmann.org> <20141003102023.GA8095@t440s.lan> From: Alfonso Acosta Date: Fri, 3 Oct 2014 14:16:18 +0200 Message-ID: Subject: Re: [PATCH] Bluetooth: Include ADV_IND report in Device Connected event To: Marcel Holtmann , Alfonso Acosta , BlueZ development Content-Type: text/plain; charset=UTF-8 List-ID: Hi Johan, >> > void mgmt_device_connected(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type, >> > u8 addr_type, u32 flags, u8 *name, u8 name_len, >> > - u8 *dev_class); >> > + u8 *dev_class, u8 *adv, u8 adv_len); >> >> I keep wondering if we might just handover hci_conn instead. Something >> Johan needs to comment on here. > > That's something I was actually thinking of myself. I have no objections > to simplifying the parameter list by passing the whole hci_conn to this > function (this should however be done as a separate patch before this > one). The initial patch of the version 2 bundle I just sent takes care of this. -- Alfonso Acosta Embedded Systems Engineer at Spotify Birger Jarlsgatan 61, Stockholm, Sweden http://www.spotify.com