All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vigna Raja Priya N S <priya.ns@mistralsolutions.com>
To: Nishanth Menon <nm@ti.com>
Cc: meta-arago@arago-project.org, Priya N S <priya.ns@ti.com>,
	Sekhar Nori <nsekhar@ti.com>
Subject: Re: [tisdk-setup-scripts] [master] [PATCH-V3 3/3] create-sdcard.sh: Stop using cylinder as unit for partition size
Date: Thu, 29 Jul 2021 18:14:31 +0530	[thread overview]
Message-ID: <CAHFpNO-PRq4d_=THaTJ9Dz0ZoRB6naR6_y5dwNStj1-nJvvZ3g@mail.gmail.com> (raw)
In-Reply-To: <20210707150846.xbig63m3xffymcnq@overcast>

On Wed, Jul 7, 2021 at 8:38 PM Nishanth Menon <nm@ti.com> wrote:
>
> On 08:44-20210707, Priya N S wrote:
> > From: Priya N S <priya.ns@ti.com>
> >
> > * Cylinder size of sdcard is manufacturer dependent. To standardize
> >   sdcard partitioning remove the use of cylinder (cyl) unit.
> > * While at it shift to using fdisk for the partitioning the sdcard.
> >   fdisk is already used in the script and this reduces the dependencies
> >   of this script on available installed applications.
> > * This fixes cases where already partitioned cards were being detected
> >   as not partitioned because of size check elsewhere in the script
> >   failing.
> >
> > Signed-off-by: Priya N S <priya.ns@ti.com>
> > Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> > ---
> >  create-sdcard.sh | 50 +++++++++++++++++++++++++++++++++++++++---------
> >  1 file changed, 41 insertions(+), 9 deletions(-)
> >
> > diff --git a/create-sdcard.sh b/create-sdcard.sh
> > index d052312..546588b 100644
> > --- a/create-sdcard.sh
> > +++ b/create-sdcard.sh
> > @@ -501,11 +501,29 @@ SIZE=`fdisk -l $DRIVE | grep Disk | awk '{print $5}'`
> >
> >  echo DISK SIZE - $SIZE bytes
> >
> > -parted -s $DRIVE mklabel msdos
> > -parted -s $DRIVE unit cyl mkpart primary fat32 -- 0 9
> > -parted -s $DRIVE set 1 boot on
> > -parted -s $DRIVE unit cyl mkpart primary ext2 -- 9 310
> > -parted -s $DRIVE unit cyl mkpart primary ext2 -- 310 -2
> > +cat << END | fdisk $DRIVE
> > +n
> > +p
> > +1
> > +
> > ++75M
>
> https://lists.yoctoproject.org/g/meta-ti/topic/83851299#13855
> Should we make boot partition 128MB as default to make sure it is in
> sync with wic image sizes?
The partition size increase to 128MB is updated in the V4 patch.
>
> > +n
> > +p
> > +2
> > +
> > ++2.4G
> > +n
> > +p
> > +3
> > +
> > +
> > +t
> > +1
> > +c
> > +a
> > +1
> > +w
> > +END
> >
> >
> >  cat << EOM
> > @@ -559,10 +577,24 @@ SIZE=`fdisk -l $DRIVE | grep Disk | awk '{print $5}'`
> >
> >  echo DISK SIZE - $SIZE bytes
> >
> > -parted -s $DRIVE mklabel msdos
> > -parted -s $DRIVE unit cyl mkpart primary fat32 -- 0 9
> > -parted -s $DRIVE set 1 boot on
> > -parted -s $DRIVE unit cyl mkpart primary ext2 -- 9 -2
> > +cat << END | fdisk $DRIVE
> > +n
> > +p
> > +1
> > +
> > ++75M
> same ^^ ?
The partition size increase to 128MB is updated in the V4 patch.


      reply	other threads:[~2021-07-29 12:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07  3:14 [tisdk-setup-scripts] [master] [PATCH-V3 0/3] create-sdcard: Fix rootfs tarball search and selection Priya N S
2021-07-07  3:14 ` [tisdk-setup-scripts] [master] [PATCH-V3 1/3] create-sdcard.sh: fix regex used for rootfs tarball Priya N S
2021-07-07  3:14 ` [tisdk-setup-scripts] [master] [PATCH-V3 2/3] create-sdcard: Fix wrong rootfs tarball selection Priya N S
2021-07-07  3:14 ` [tisdk-setup-scripts] [master] [PATCH-V3 3/3] create-sdcard.sh: Stop using cylinder as unit for partition size Priya N S
2021-07-07 15:08   ` Nishanth Menon
2021-07-29 12:44     ` Vigna Raja Priya N S [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHFpNO-PRq4d_=THaTJ9Dz0ZoRB6naR6_y5dwNStj1-nJvvZ3g@mail.gmail.com' \
    --to=priya.ns@mistralsolutions.com \
    --cc=meta-arago@arago-project.org \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=priya.ns@ti.com \
    --subject='Re: [tisdk-setup-scripts] [master] [PATCH-V3 3/3] create-sdcard.sh: Stop using cylinder as unit for partition size' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.