From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 303B4C4338F for ; Tue, 17 Aug 2021 09:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F075601FA for ; Tue, 17 Aug 2021 09:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235558AbhHQJzj (ORCPT ); Tue, 17 Aug 2021 05:55:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235293AbhHQJzi (ORCPT ); Tue, 17 Aug 2021 05:55:38 -0400 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8F86C061764 for ; Tue, 17 Aug 2021 02:55:05 -0700 (PDT) Received: by mail-vs1-xe2d.google.com with SMTP id g1so12753492vsq.7 for ; Tue, 17 Aug 2021 02:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kpmir7k0PFevcQlfQoo4sSUWeLwsKjNzLHdaLZzDUa4=; b=etTUZosli59SdETLGLdI+wgYewNCKmh56XvS5Loi8/gLQaMpcn1GyVJ6Mz+M3iuScX 7/Ir/IEjoe5y3+lLG/PLRYa0crwXh2pPayP8HgzO+fHFOulIAYYpitiIG2VMoDjtvBoC leOevjLmISnA64CpQpeZo0CkKd62zAA+nHdyDTZad6femkqdrE5uODjwnsE4iY7mARoc C+EGpBbHl1dovqaQntW+ZyfeyBIAWRn4TBTHCnJ/Ny0721CmSKGlvA1H1Wd1Mfp77eIu MbDpNUApBA+VxUwGofVC7A9dD1ePBckagWUrc0T+jZod71BwCP1Up8l+5JxHZgxppu2f kzWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kpmir7k0PFevcQlfQoo4sSUWeLwsKjNzLHdaLZzDUa4=; b=Zsoj8QGwzWF+5RluMJXIUadGZG1Kevyhrj99ywxx2lWgrr8P/j8K1zWPg/cgZ6OlJO cHcnBHqlO9jGtzxm8MwM/Fys55ZFZZUx60lVWYCdlWyeXVvU9PDaPMIAxe+GZ6K6/65o Qy7NOtLdwM5X060Q0XpK2a9FF3eWwDwYhXV3ayNh/XZjEDMIbaOPRDcnAFh3tEvaC9L/ kSGYJVau9EbI8THusrTFkR5uAn1MJ3aDerbdDhrDcA6R2eHs0LNhVO3CbQQkd/Y3RtdG vcSqQP6Wiv9xiRMhJohrg28pvHUKEpOG+PKDs6bTlPPH2Hqs8fTGEF/D2lzeUMGs49R1 PY4g== X-Gm-Message-State: AOAM531sk1H79V2hIraUdrNrM214s2np2gZY/Ylh3VchzFuRRo+26TSL XZw9IZgkoTRp9xVx1cmv3cXudf1Xc7PNqBcgIneTcA== X-Google-Smtp-Source: ABdhPJyKaOH7ANZKsIq0aXmV96K2LRU5p2I88CsAXI06uLLdRgPGoi/ahN62uORkYCBLe0ZStMIFuTn2ainKKUsaAG8= X-Received: by 2002:a67:77d6:: with SMTP id s205mr1905726vsc.24.1629194104754; Tue, 17 Aug 2021 02:55:04 -0700 (PDT) MIME-Version: 1.0 References: <20210815201611.v9.1.I41aec59e65ffd3226d368dabeb084af13cc133c8@changeid> <61191554.1c69fb81.89ead.b7d9@mx.google.com> In-Reply-To: From: Joseph Hwang Date: Tue, 17 Aug 2021 17:54:53 +0800 Message-ID: Subject: Re: [v9,1/5] Bluetooth: btusb: disable Intel link statistics telemetry events To: Luiz Augusto von Dentz Cc: "linux-bluetooth@vger.kernel.org" , Miao-chen Chou Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org (Resent this email to contain only plaintext.) Hi Luiz: It seems that mgmt-tester currently uses a fixed feature count. Every time a new exp feature is added, the mgmt-tester would be broken. By checking the kernel, it seems that there are currently 2 or 3 exp features, i.e., debug uuid, simultaneous central peripheral uuid, and LL privacy uuid. Note that the debug exp feature is guarded by CONFIG_BT_FEATURE_DEBUG. So I am not sure how the kernel is configured and made on your test setup. If we fix the mgmt-tester in bluez to have 3 or 4 (which one?) features before merging the kernel changes here that adds a new quality exp feature, it would not match the existing kernel which has only 2 or 3 features. Do you have any preference about how to fix the mgmt-tester? My suggestion is to remove the checking of the feature count from the mgmt-tester. The feature count changes over time. It is possible to implement a customized exp_feat_check function which can be more flexible. If a uuid is found in the MGMT response, its associated flags are checked against. The data currently used in the mgmt-tester: static const uint8_t read_exp_feat_param_success[] = { 0x02, 0x00, /* Feature Count */ 0xd6, 0x49, 0xb0, 0xd1, 0x28, 0xeb, /* UUID - Simultaneous */ 0x27, 0x92, 0x96, 0x46, 0xc0, 0x42, /* Central Peripheral */ 0xb5, 0x10, 0x1b, 0x67, 0x00, 0x00, 0x00, 0x00, /* Flags */ 0x04, 0x00, 0x13, 0xac, 0x42, 0x02, /* UUID - LL Privacy */ 0xde, 0xb3, 0xea, 0x11, 0x73, 0xc2, 0x48, 0xa1, 0xc0, 0x15, 0x02, 0x00, 0x00, 0x00, /* Flags */ }; Please let me know what you think. Thanks and regards, Joseph On Tue, Aug 17, 2021 at 1:49 AM Luiz Augusto von Dentz wrote: > > Hi Joseph, > > On Sun, Aug 15, 2021 at 6:25 AM wrote: > > > > This is automated email and please do not reply to this email! > > > > Dear submitter, > > > > Thank you for submitting the patches to the linux bluetooth mailing list. > > This is a CI test results with your patch series: > > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=531683 > > > > ---Test result--- > > > > Test Summary: > > CheckPatch PASS 2.92 seconds > > GitLint PASS 0.61 seconds > > BuildKernel PASS 598.41 seconds > > TestRunner: Setup PASS 394.12 seconds > > TestRunner: l2cap-tester PASS 2.89 seconds > > TestRunner: bnep-tester PASS 2.07 seconds > > TestRunner: mgmt-tester FAIL 30.94 seconds > > TestRunner: rfcomm-tester PASS 2.31 seconds > > TestRunner: sco-tester PASS 2.20 seconds > > TestRunner: smp-tester FAIL 2.27 seconds > > TestRunner: userchan-tester PASS 2.09 seconds > > > > Details > > ############################## > > Test: CheckPatch - PASS - 2.92 seconds > > Run checkpatch.pl script with rule in .checkpatch.conf > > > > > > ############################## > > Test: GitLint - PASS - 0.61 seconds > > Run gitlint with rule in .gitlint > > > > > > ############################## > > Test: BuildKernel - PASS - 598.41 seconds > > Build Kernel with minimal configuration supports Bluetooth > > > > > > ############################## > > Test: TestRunner: Setup - PASS - 394.12 seconds > > Setup environment for running Test Runner > > > > > > ############################## > > Test: TestRunner: l2cap-tester - PASS - 2.89 seconds > > Run test-runner with l2cap-tester > > Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 > > > > ############################## > > Test: TestRunner: bnep-tester - PASS - 2.07 seconds > > Run test-runner with bnep-tester > > Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 > > > > ############################## > > Test: TestRunner: mgmt-tester - FAIL - 30.94 seconds > > Run test-runner with mgmt-tester > > Total: 448, Passed: 444 (99.1%), Failed: 1, Not Run: 3 > > > > Failed Test Cases > > Read Exp Feature - Success Failed 0.012 seconds > > Looks like there is a regression on mgmt-tester: > > Read Exp Feature - Success - run > Sending Read Experimental Features Information (0x0049) > Test condition added, total 1 > Read Experimental Features Information (0x0049): Success (0x00) > Invalid cmd response parameter size > Read Exp Feature - Success - test failed > > > > > ############################## > > Test: TestRunner: rfcomm-tester - PASS - 2.31 seconds > > Run test-runner with rfcomm-tester > > Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 > > > > ############################## > > Test: TestRunner: sco-tester - PASS - 2.20 seconds > > Run test-runner with sco-tester > > Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 > > > > ############################## > > Test: TestRunner: smp-tester - FAIL - 2.27 seconds > > Run test-runner with smp-tester > > Total: 8, Passed: 7 (87.5%), Failed: 1, Not Run: 0 > > > > Failed Test Cases > > SMP Client - SC Request 2 Failed 0.024 seconds > > > > ############################## > > Test: TestRunner: userchan-tester - PASS - 2.09 seconds > > Run test-runner with userchan-tester > > Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 > > > > > > > > --- > > Regards, > > Linux Bluetooth > > > > > -- > Luiz Augusto von Dentz -- Joseph Shyh-In Hwang Email: josephsih@google.com