All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Schuberth <sschuberth@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>,
	Jacob Keller <jacob.keller@gmail.com>, Jeff King <peff@peff.net>,
	Git Mailing List <git@vger.kernel.org>,
	Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: diff.ignoreSubmoudles config setting broken?
Date: Thu, 9 Mar 2017 17:15:47 +0100	[thread overview]
Message-ID: <CAHGBnuNv--R3FMpRWsvhFJU5_R2Rji=nCjqQsuXrK0UU30eByw@mail.gmail.com> (raw)
In-Reply-To: <xmqq8tof32x9.fsf@gitster.mtv.corp.google.com>

On Wed, Mar 8, 2017 at 9:54 PM, Junio C Hamano <gitster@pobox.com> wrote:

> Between these two:
>
>         git -c diff.ignoresubmodules=all diff
>         git diff --ignore-submodules=all
>
> one difference is that the latter disables reading extra config from
> .gitmodules (!) while the former makes the command honor it.
>
> This comes from aee9c7d6 ("Submodules: Add the new "ignore" config
> option for diff and status", 2010-08-06), which is ancient and
> predates even v2.0, so if you see problems with v2.12 or v2.11 but
> not with older ones, that would rule out this theory.

Thanks for reminding me of possible settings .gitmodules. Indeed I have

[submodule "scanners/scancode-toolkit"]
        path = scanners/scancode-toolkit
        url = https://github.com/sschuberth/scancode-toolkit.git
        ignore = untracked

in .gitmodules, which explains why globally setting
"diff.ignoreSubmodules" to "all" had no effect.

-- 
Sebastian Schuberth

  parent reply	other threads:[~2017-03-09 16:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 12:54 diff.ignoreSubmoudles config setting broken? Sebastian Schuberth
2017-03-08 13:33 ` Jeff King
2017-03-08 13:43   ` Sebastian Schuberth
2017-03-08 14:01     ` Jeff King
2017-03-08 15:07       ` Sebastian Schuberth
2017-03-08 19:04         ` Stefan Beller
2017-03-08 20:54           ` Junio C Hamano
2017-03-08 22:11             ` Stefan Beller
2017-03-08 23:08               ` Junio C Hamano
2017-03-09  1:30                 ` Stefan Beller
2017-03-09 16:15             ` Sebastian Schuberth [this message]
2017-03-08 22:27           ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHGBnuNv--R3FMpRWsvhFJU5_R2Rji=nCjqQsuXrK0UU30eByw@mail.gmail.com' \
    --to=sschuberth@gmail.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jacob.keller@gmail.com \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.