From: Amit Kucheria <amit.kucheria@linaro.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Konrad Dybcio <konradybcio@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 2/2] thermal: qcom: tsens-v0_1: Add support for MSM8939
Date: Mon, 27 Jul 2020 14:45:13 +0530 [thread overview]
Message-ID: <CAHLCerNXtEDONQqXeeCbo3jSL8HNpP-OxW0es0ZQuWNnaAaPFQ@mail.gmail.com> (raw)
In-Reply-To: <20200727083322.GA12266@dragon>
On Mon, Jul 27, 2020 at 2:03 PM Shawn Guo <shawn.guo@linaro.org> wrote:
>
> Hi Amit,
>
> On Mon, Jul 27, 2020 at 12:06:54PM +0530, Amit Kucheria wrote:
> > On Mon, Jul 27, 2020 at 11:56 AM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> > >
> > > On Tue, Jun 30, 2020 at 1:09 AM Shawn Guo <shawn.guo@linaro.org> wrote:
> > > >
> > > > The TSENS integrated on MSM8939 is a v0_1 device with 10 sensors.
> > > > Different from its predecessor MSM8916, where 'calib_sel' bits sit in
> > > > separate qfprom word, MSM8939 has 'cailb' and 'calib_sel' bits mixed and
> > > > spread on discrete offsets. That's why all qfprom bits are read as one
> > > > go and later mapped to calibration data for MSM8939.
> > > >
> > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > >
> > > Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
> >
> > Shawn,
> >
> > Have you not sent the change to the tsens.yaml and 8939 DT yet or did
> > I miss them?
>
> You were copied on '[PATCH 1/2] dt-bindings: tsens: qcom: Document
> MSM8939 compatible'.
Aah ok, it was threaded weirdly but I see it now.
> For DTS change, I haven't sent them out. In case
> you want to have a look, here it is.
This looks fine from a quick glance. Thanks.
> thermal-zones {
> cpu0-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
>
> thermal-sensors = <&tsens 5>;
>
> trips {
> cpu0_alert: trip0 {
> temperature = <75000>;
> hysteresis = <2000>;
> type = "passive";
> };
> cpu0_crit: trip1 {
> temperature = <110000>;
> hysteresis = <2000>;
> type = "critical";
> };
> };
>
> cooling-maps {
> map0 {
> trip = <&cpu0_alert>;
> cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> };
> };
>
> cpu1-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
>
> thermal-sensors = <&tsens 6>;
>
> trips {
> cpu1_alert: trip0 {
> temperature = <75000>;
> hysteresis = <2000>;
> type = "passive";
> };
> cpu1_crit: trip1 {
> temperature = <110000>;
> hysteresis = <2000>;
> type = "critical";
> };
> };
>
> cooling-maps {
> map0 {
> trip = <&cpu1_alert>;
> cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> };
> };
>
> cpu2-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
>
> thermal-sensors = <&tsens 7>;
>
> trips {
> cpu2_alert: trip0 {
> temperature = <75000>;
> hysteresis = <2000>;
> type = "passive";
> };
> cpu2_crit: trip1 {
> temperature = <110000>;
> hysteresis = <2000>;
> type = "critical";
> };
> };
>
> cooling-maps {
> map0 {
> trip = <&cpu2_alert>;
> cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> };
> };
>
> cpu3-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
>
> thermal-sensors = <&tsens 8>;
>
> trips {
> cpu3_alert: trip0 {
> temperature = <75000>;
> hysteresis = <2000>;
> type = "passive";
> };
> cpu3_crit: trip1 {
> temperature = <110000>;
> hysteresis = <2000>;
> type = "critical";
> };
> };
>
> cooling-maps {
> map0 {
> trip = <&cpu3_alert>;
> cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> };
> };
>
> cpu4567-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
>
> thermal-sensors = <&tsens 9>;
>
> trips {
> cpu4567_alert: trip0 {
> temperature = <75000>;
> hysteresis = <2000>;
> type = "passive";
> };
> cpu4567_crit: trip1 {
> temperature = <110000>;
> hysteresis = <2000>;
> type = "critical";
> };
> };
>
> cooling-maps {
> map0 {
> trip = <&cpu4567_alert>;
> cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> };
> };
>
> };
>
> qfprom: qfprom@5c000 {
> compatible = "qcom,qfprom";
> reg = <0x5c000 0x1000>;
> #address-cells = <1>;
> #size-cells = <1>;
> tsens_caldata: caldata@a0 {
> reg = <0xa0 0x5c>;
> };
> };
>
> tsens: thermal-sensor@4a9000 {
> compatible = "qcom,msm8939-tsens";
> reg = <0x4a9000 0x1000>, /* TM */
> <0x4a8000 0x1000>; /* SROT */
> nvmem-cells = <&tsens_caldata>;
> nvmem-cell-names = "calib";
> #qcom,sensors = <10>;
> interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "uplow";
> #thermal-sensor-cells = <1>;
> };
>
> Shawn
next prev parent reply other threads:[~2020-07-27 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 14:49 [PATCH 0/2] Add msm8939 tsens support Shawn Guo
2020-06-29 14:49 ` [PATCH 1/2] dt-bindings: tsens: qcom: Document MSM8939 compatible Shawn Guo
2020-06-29 14:49 ` [PATCH 2/2] thermal: qcom: tsens-v0_1: Add support for MSM8939 Shawn Guo
2020-07-27 6:26 ` Amit Kucheria
2020-07-27 6:36 ` Amit Kucheria
2020-07-27 8:33 ` Shawn Guo
2020-07-27 9:15 ` Amit Kucheria [this message]
2020-07-21 13:29 ` [PATCH 0/2] Add msm8939 tsens support Daniel Lezcano
2020-07-25 12:25 ` Konrad Dybcio
2020-07-27 8:34 ` Daniel Lezcano
2020-07-27 8:44 ` Daniel Lezcano
2020-07-27 8:48 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLCerNXtEDONQqXeeCbo3jSL8HNpP-OxW0es0ZQuWNnaAaPFQ@mail.gmail.com \
--to=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.