From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F913CCA481 for ; Fri, 17 Jun 2022 12:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382416AbiFQM6v (ORCPT ); Fri, 17 Jun 2022 08:58:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382462AbiFQM6h (ORCPT ); Fri, 17 Jun 2022 08:58:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C967E2B1B5 for ; Fri, 17 Jun 2022 05:58:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7F95BB82682 for ; Fri, 17 Jun 2022 12:58:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F9B3C341C4 for ; Fri, 17 Jun 2022 12:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655470714; bh=aJe/IuNfbjZ9EniMI2KMI/OYNV3Ky7QaQrPqbpHqWEU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YceFDQKz6Qp3semAVSe6go/03+fq5w2gdDcUhzRXBfGfw6Ck0mm2h1bKcOkDCqSE1 LXx0To+qfIBp/c1sr/dS4FDhi/Bc2BNaQZ8kgH/SmwPzsepWIwsuWH3z2AYqlVIi5W /wrAEbkctqOvhA3FUpQ8+2dC1DpLULN/r+3b+uSJXvJXAkyQI2j5SRwyqlg6iDW6VV wBzGl0XmWM4AWBd0zSb68+xsRmah96Oh0e79gl+48h6rG3GWm3OxeqoLmYNboook0C g4eFIahW5BQQoVgtZtpKZW2dk0p7iAlXYmmbDrGZ8gT0D64qumRJZlBahLyw/m7zjR n3v6InWaJwKug== Received: by mail-lj1-f178.google.com with SMTP id m25so4636346lji.11 for ; Fri, 17 Jun 2022 05:58:34 -0700 (PDT) X-Gm-Message-State: AJIora9cOHiFf7Ba/Vrfb52i3sWmDShzC1eaYMpd38N/sd0kbHLANNwE 1GP/AfilNyCo9FRtYLRypJ0CCvmwJCR08C2L7STfxg== X-Google-Smtp-Source: AGRyM1uqosFaBOhZZC5A81VpQaFlEvVkSB4BPtOu6MTbFLXMRKLMCZXs1CEtapjf6SQr5wJTaVMHzlCzz1PP2y5pmko= X-Received: by 2002:a2e:8609:0:b0:255:6eb1:46a0 with SMTP id a9-20020a2e8609000000b002556eb146a0mr4963421lji.336.1655470712245; Fri, 17 Jun 2022 05:58:32 -0700 (PDT) MIME-Version: 1.0 References: <20220616202537.303655-1-daniel.lezcano@linaro.org> In-Reply-To: <20220616202537.303655-1-daniel.lezcano@linaro.org> From: Amit Kucheria Date: Fri, 17 Jun 2022 18:28:21 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] thermal/drivers/qcom: Remove get_trend function To: Daniel Lezcano Cc: "Rafael J. Wysocki" , LKML , Linux PM list , Thara Gopinath , Andy Gross , Bjorn Andersson , Zhang Rui , "open list:QUALCOMM TSENS THERMAL DRIVER" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 17, 2022 at 1:56 AM Daniel Lezcano wrote: > > There is a get_trend function which is a wrapper to call a private > get_trend function. However, this private get_trend function is not > assigned anywhere. > > Remove this dead code. > > Signed-off-by: Daniel Lezcano Acked-by: Amit Kucheria > --- > drivers/thermal/qcom/tsens.c | 12 ------------ > drivers/thermal/qcom/tsens.h | 2 -- > 2 files changed, 14 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index 7963ee33bf75..e49f58e83513 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -933,17 +933,6 @@ static int tsens_get_temp(void *data, int *temp) > return priv->ops->get_temp(s, temp); > } > > -static int tsens_get_trend(void *data, int trip, enum thermal_trend *trend) > -{ > - struct tsens_sensor *s = data; > - struct tsens_priv *priv = s->priv; > - > - if (priv->ops->get_trend) > - return priv->ops->get_trend(s, trend); > - > - return -ENOTSUPP; > -} > - > static int __maybe_unused tsens_suspend(struct device *dev) > { > struct tsens_priv *priv = dev_get_drvdata(dev); > @@ -1004,7 +993,6 @@ MODULE_DEVICE_TABLE(of, tsens_table); > > static const struct thermal_zone_of_device_ops tsens_of_ops = { > .get_temp = tsens_get_temp, > - .get_trend = tsens_get_trend, > .set_trips = tsens_set_trips, > }; > > diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h > index 1471a2c00f15..ba05c8233356 100644 > --- a/drivers/thermal/qcom/tsens.h > +++ b/drivers/thermal/qcom/tsens.h > @@ -65,7 +65,6 @@ struct tsens_sensor { > * @disable: Function to disable the tsens device > * @suspend: Function to suspend the tsens device > * @resume: Function to resume the tsens device > - * @get_trend: Function to get the thermal/temp trend > */ > struct tsens_ops { > /* mandatory callbacks */ > @@ -77,7 +76,6 @@ struct tsens_ops { > void (*disable)(struct tsens_priv *priv); > int (*suspend)(struct tsens_priv *priv); > int (*resume)(struct tsens_priv *priv); > - int (*get_trend)(struct tsens_sensor *s, enum thermal_trend *trend); > }; > > #define REG_FIELD_FOR_EACH_SENSOR11(_name, _offset, _startbit, _stopbit) \ > -- > 2.25.1 >