From: Amit Kucheria <amitk@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thara Gopinath <thara.gopinath@gmail.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>
Subject: Re: [PATCH] thermal/drivers/qcom: Drop false build dependency of all QCOM drivers on QCOM_TSENS
Date: Mon, 5 Sep 2022 18:27:31 +0530 [thread overview]
Message-ID: <CAHLCerOYALNuRLMMdrH=t8-zXLiy7v8eLdtuuhC+1XCPFBhrHg@mail.gmail.com> (raw)
In-Reply-To: <20220821160032.2206349-1-jic23@kernel.org>
On Sun, Aug 21, 2022 at 10:05 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The SPMI QCOM drivers have no dependency in Kconfig, but the Makefile
> will not be included without QCOM_TSENS. This unnecessarily reduces
> build coverage.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Acked-by: Amit Kucheria <amitk@kernel.org>
> ---
>
> Run into whilst trying to build test a namespace move for the IIO
> interfaces used in these drivers.
>
> Maintainers entry for TSENS should probably also be made more
> specific.
> ---
> drivers/thermal/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
> index def8e1a0399c..2506c6c8ca83 100644
> --- a/drivers/thermal/Makefile
> +++ b/drivers/thermal/Makefile
> @@ -52,7 +52,7 @@ obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o
> obj-y += intel/
> obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/
> obj-y += st/
> -obj-$(CONFIG_QCOM_TSENS) += qcom/
> +obj-y += qcom/
> obj-y += tegra/
> obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o
> obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o
> --
> 2.37.2
>
prev parent reply other threads:[~2022-09-05 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 16:00 [PATCH] thermal/drivers/qcom: Drop false build dependency of all QCOM drivers on QCOM_TSENS Jonathan Cameron
2022-09-02 7:39 ` Bhupesh Sharma
2022-09-05 12:57 ` Amit Kucheria [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHLCerOYALNuRLMMdrH=t8-zXLiy7v8eLdtuuhC+1XCPFBhrHg@mail.gmail.com' \
--to=amitk@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhupesh.sharma@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jic23@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.