From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE89C433FE for ; Fri, 17 Dec 2021 04:57:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232036AbhLQE5G (ORCPT ); Thu, 16 Dec 2021 23:57:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbhLQE5B (ORCPT ); Thu, 16 Dec 2021 23:57:01 -0500 Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E018C061574 for ; Thu, 16 Dec 2021 20:57:01 -0800 (PST) Received: by mail-ua1-x934.google.com with SMTP id 30so2093833uag.13 for ; Thu, 16 Dec 2021 20:57:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L0UnZ/E6MSTY4JMW+zDDS2950QfrUnxcYxwKwDcRDHw=; b=r0eTEk3lQ51qMBgKBl6UU1apOFPCZOycMG7SRxCRqg358r9YS0vKbc2xLbabIm/qBR HjMGyFG+Gfn/hO4aTYywIOKW6yVzNxkoeWkfnfZ8XjnBXp9XW7XRBIvijTev1oewUU1j vYPBcaFdSjIEi7ECOghIpCY175tkgsgT+YUuB7L0v2OUdo+vzZmAmqv0ybu/DE+wiC+1 ujIqNqLL9rW/mRDUu6638KVeJuPGZV8aQk/kg5b9/FC8/iNd8skyyf3jT/zqeyMRlSdB Ul8E3SXnWi7AFNB1NN0V6sH5MIxJhgtSTybjnRbWPfk3KcHDaHyl+DkAQHOCQ4CZbZBP ANiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L0UnZ/E6MSTY4JMW+zDDS2950QfrUnxcYxwKwDcRDHw=; b=m26/eU5+UTVZKqBA2rDqJ9OmGjFxHTbGSQ31g755EDHYyo57Xv07Owleq8dP5vZzJ+ bCB9s95pSxaKet+UIPOAHf7n+38xSeLduLTKpoNFFm5DxatbvDi1LNEro5B1loHZQgp4 Nb5lSy8/NdXjPLdqFQBsdepvkYFOIioX3xeLgwtWxU+5RJWRyJBgQF7Q7COesQxVk3Po 3zRQ8JsBFSgMJRvLC92nrt/ugLazU8mKhacXZSzdENgK0OsSNvvIqrpa4+HzvG/WLh6P PsYUAnmcT5lBFmD9BXFmPt+eOU8Go0ews0CQxLyjft5/Cc7A/pg4vBApNKJNGVg43itm nHVw== X-Gm-Message-State: AOAM532RsMZM0Z8TcexwrTGJ5at/gBy41lNeoBVcPliI80e/GSsi+vXd abHdlLDc+Z6tM/dzft3oW4KOAeiyH4j428QcVoGmoQ== X-Google-Smtp-Source: ABdhPJwhZIjT8NNvoPom2Rp6at+2GMoK3wDN//Eb03fRpBR0y4i6QY352WbPDfVufZBXvrkLoOxOGkvqapwyTag0+4Y= X-Received: by 2002:a67:446:: with SMTP id 67mr431973vse.38.1639717020639; Thu, 16 Dec 2021 20:57:00 -0800 (PST) MIME-Version: 1.0 References: <20211216055958.634097-1-sharinder@google.com> <20211216055958.634097-4-sharinder@google.com> <87czlwcfav.fsf@meer.lwn.net> In-Reply-To: <87czlwcfav.fsf@meer.lwn.net> From: Harinder Singh Date: Fri, 17 Dec 2021 10:26:49 +0530 Message-ID: Subject: Re: [PATCH v4 3/7] Documentation: KUnit: Added KUnit Architecture To: Jonathan Corbet Cc: Marco Elver , David Gow , Brendan Higgins , shuah@kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Tim.Bird@sony.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jonathan and Marco, On Fri, Dec 17, 2021 at 4:45 AM Jonathan Corbet wrote: > > Marco Elver writes: > > > In response to the other email: Adding binary blobs just creates > > problems, for comparing different versions, and general bloating the > > whole repo, where better alternatives exist. > > > > I suppose an ASCII diagram is a bit primitive. :-) > > > > However, SVG files on the other hand are not binary blobs, they are > > text-markup based (XML), and e.g. diffing them often provides useful > > information about what changed. SVG also has the benefit of being > > vector graphics, and not being limited to one resolution. > > > > Looking at the diagram you added, I think this can easily be turned > > into vector graphics, and most likely will not use up 24KiB as a > > result. > > I agree with all of this; we shouldn't be adding binary images to the > docs, and we've decided at other times that SVG is generally the best > compromise there. > I did not realize that .SVG is in XML format and preferred over .PNG. Thanks for pointing this out. I replaced .SVG with .PNG. > Thanks, Marco, for pointing this out and producing an alternative. > A big thanks to Marco for creating this .SVG file for the documentation :-) > Once this is all settled, do you want it to go through the docs tree? > Yeah! that's the plan. > jon Thanks, Harinder Singh