Re: [OE-core] [PATCH 1/2] rust: Enable building rust from stable, beta and nightly channels

[Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>]

[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]

On Thu, 15 Dec 2022 at 09:08, Alex Kiernan <alex.kiernan@gmail.com> wrote:

> On Thu, Dec 15, 2022 at 3:38 PM Alejandro Hernandez Samaniego
> <alejandro@enedino.org> wrote:
> >
> >
> >
> > On Thu, Dec 15, 2022, 3:05 AM Alexander Kanavin <alex.kanavin@gmail.com>
> wrote:
> >>
> >> On Thu, 15 Dec 2022 at 08:32, Alejandro Hernandez Samaniego
> >> <alejandro@enedino.org> wrote:
> >> > +RUST_VERSION = "1.65.0"
> >> > +SRC_URI += "
> https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;name=rust
> "
> >>
> >> Adding a manually set variable adds friction to updates. Can
> >> RUST_VERSION be set instead with a helper @function from PV?
> >
> >
> > Hey Alex,
> >
> > I agree, and ideally yes, I tried to set it automatically to PV, but,
> sadly it conflicts if we try to include rust-source.inc from a non-rust
> recipe (This is necessary for some recipes that need to have rust source
> available to them) since it uses the PV set from that recipe instead.
> >
>
> Is this different cargo/rust versions, or something else you have?
>
> Basically I'm on the same page as Alex - updating this recipe is
> already quite painful, making it any worse doesn't seem like a great
> idea, but I guess you could argue that rust/cargo already conflate
> their versions in the current usage.
>

I'm referring to any recipe that could include rust-source.inc, if
RUST_VERSION ?= ${PV} for example,
 for rust recipes that works fine because RUST_VERSION would expand to
1.65.0 today, but lets say
recipe foo_1.0.1.bb needs rust-source.inc to recompile built-in crates, in
that case RUST_VERSION
would expand to 1.0.1 instead.

While I agree its not ideal, in my opinion this approach provides more
consistency with the drawback of
 modifying that variable on upgrades, however I also think that requiring
rust-source.inc is seldom the
case, hence the other option is to keep RUST_VERSION ?= ${PV} and hardcode
it on every recipe that
would require this flow.

Alejandro



>
> --
> Alex Kiernan
>

[-- Attachment #2: Type: text/html, Size: 4004 bytes --]