From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 18 Jun 2014 14:52:36 +0200 (CEST) Received: from mail-yh0-f48.google.com ([209.85.213.48]:45616 "EHLO mail-yh0-f48.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6816615AbaFRMwXx8MN4 (ORCPT ); Wed, 18 Jun 2014 14:52:23 +0200 Received: by mail-yh0-f48.google.com with SMTP id b6so538914yha.7 for ; Wed, 18 Jun 2014 05:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=ubVQjTL+lNY+Q8t9TKWHcImH9L5cZMhZh4cDj/MPxZ4=; b=eJyEpL+nCN6Udi+KOGxFxley4CFPzydqbax0vK6vwj7i+saI7ridjcyBViLv86PCqk j4Zzh+j7oxxWAG0tbvVHkomBR7JfHcGyX6uO4qeA+OGa0QwxW7HT+KOebm1WTsk6/lsE uMsjLKUrrcyMShYMlzmzPqGRYziqaVpaWAIdade0Emle/BzuGTQOug9APrj3D8Q1zCiK U+ukvq08+yHkhol0kNvXqNfliok+Rtkw+VLm720h1fByWTMAGVC6mwR0a0ULCT4yFZIL 1EfonTYSL5rAXACC0b4i2tLM7rQcr9b/dNzrOeQ6f+6cxrdnKq8h3sXgG3XjxtK4GySh rmkA== X-Received: by 10.236.231.36 with SMTP id k34mr3589490yhq.157.1403095937733; Wed, 18 Jun 2014 05:52:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.168.136 with HTTP; Wed, 18 Jun 2014 05:51:56 -0700 (PDT) In-Reply-To: <53A17CD5.2060504@phrozen.org> References: <53A17CD5.2060504@phrozen.org> From: Sergey Ryazanov Date: Wed, 18 Jun 2014 16:51:56 +0400 Message-ID: Subject: Re: Introducing Atheros AR231x/AR531x WiSoC support To: John Crispin Cc: linux-mips@linux-mips.org Content-Type: text/plain; charset=ISO-8859-1 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 40629 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ryazanov.s.a@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi John, 2014-06-18 15:49 GMT+04:00 John Crispin : > On 18/06/2014 13:46, Sergey Ryazanov wrote: >> Hello, >> >> I plan to send several patches for upstream merging, that >> introduce support for Atheros AR231x/AR531x WiSoCs. This code >> developed and extensively tested in OpenWRT project. And I need >> some help. >> >> I need to know what is the preferred way to split code on to >> separate patches suitable for review and merging? Some kind of >> howto or article would be great. Could you recomend something? >> Should I send a series as RFC first? >> > > Hi Sergey, > > is the code already in a cleaned up state ? are you just missing the > bit where you split it up into patches or is there still dev work that > needs to be done beyond the actual submission process ? > The code is complete and practically stable (no serious changes during a year). Few days ago I had cleaned all errors and almost all warnings generated by checkpatch.pl, using a script from 3.10 kernel. I need some time to clean up flash initialization (remove some odd code), but this is simple task. So yes, the code itself is almost ready for submission, but I would like to send it in such manner, in which review would be as easy as possible. > is your code already available somewhere or do you plan to pusht he > owrt support upstream as is ? I does not do any forks, all changes were made as patches that were accepted to owrt. Then I plan to rebase the code on to linux-mips.git and send upstream. -- BR, Sergey