From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E37C433DF for ; Thu, 15 Oct 2020 21:29:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C05D20759 for ; Thu, 15 Oct 2020 21:29:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WsvessV7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731133AbgJOV3t (ORCPT ); Thu, 15 Oct 2020 17:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgJOV3q (ORCPT ); Thu, 15 Oct 2020 17:29:46 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D5B5C0613CF for ; Thu, 15 Oct 2020 14:29:45 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id ce10so204423ejc.5 for ; Thu, 15 Oct 2020 14:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=shNugDWCSFxMFaQhudWs8qBWQPZ07aTny77+Ie1FHlk=; b=WsvessV78yuDktprTp/4iqa3Adv1XtNl2N/v19ZJnZoqVtqW3R89jenV6efR955q/r w/t7xoaoNh7s+6TICZL6hGqJEjkuoQuGozFyTv0FDKf47JoY98kaBG86Az0J9yrlcxxG WWCFFWYtDAiJztGSud9FB31svTcPtnbTB6Mhc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=shNugDWCSFxMFaQhudWs8qBWQPZ07aTny77+Ie1FHlk=; b=QBMWfn3/NbzPeQEK9PVYDF0dKqH7Pgxfoue9yh6miHCBnz1ybu4Vnpovj20UQanghy FjnbEt0TRWr3BltHRJfPY7cMi0Z1v6ZTQXIKLaLbMRLDgGpKIWESR1SURiJSFiJr8NRX 5Ksq8HPARuXJCCbKwu5Vj1SuzwKEd0105v0Wu9TPMCvq0b5VK6KyTD3lrMsA16vr/fN0 JqHAtXZ1iWGwsJG19k2Sha3cxTl+vW2pMrvmsRPClt9K/QAxDekQus3W+l1uPbexx3pB UoCaHxYyMhWY0wmSTIPEBLzhPYgpiO7dH7oHVVIpW4pXbh4hskcP9npuD2ZZAQnZ2LSE n6gw== X-Gm-Message-State: AOAM533lrYEz1fvUBv0WLcnUj4NE5b0rICqlEv8XBFYW2mG5oq7JsCSL G66iFxmE266DeufgVcjS7Yvt/g4NySXOrg== X-Google-Smtp-Source: ABdhPJxaD7CyZ2/0M2VNLxFP8slYdbB8fGVvzW9Ka54sM7nxUac5yP0v9iA9S4v0oOMjRO2DSdSx/w== X-Received: by 2002:a17:906:350d:: with SMTP id r13mr337279eja.117.1602797383543; Thu, 15 Oct 2020 14:29:43 -0700 (PDT) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com. [209.85.208.47]) by smtp.gmail.com with ESMTPSA id i4sm235518ejz.62.2020.10.15.14.29.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 14:29:42 -0700 (PDT) Received: by mail-ed1-f47.google.com with SMTP id t20so197519edr.11 for ; Thu, 15 Oct 2020 14:29:42 -0700 (PDT) X-Received: by 2002:a50:e40b:: with SMTP id d11mr491296edm.198.1602797381996; Thu, 15 Oct 2020 14:29:41 -0700 (PDT) MIME-Version: 1.0 References: <20201013080103.410133-1-amstan@chromium.org> <20201013010056.v2.2.I96b8d872ec51171f19274e43e96cadc092881271@changeid> <20201014141946.mkrvpkrttucffkhj@holly.lan> In-Reply-To: <20201014141946.mkrvpkrttucffkhj@holly.lan> From: Alexandru M Stan Date: Thu, 15 Oct 2020 14:29:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/3] ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels To: Daniel Thompson Cc: Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , Heiko Stuebner , Rob Herring , Andy Gross , Bjorn Andersson , Douglas Anderson , Enric Balletbo i Serra , Matthias Kaehlcke , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 7:19 AM Daniel Thompson wrote: > > On Tue, Oct 13, 2020 at 01:01:02AM -0700, Alexandru Stan wrote: > > After the "PWM backlight interpolation adjustments" patches, the > > backlight interpolation works a little differently. The way these > > dts files were working before was relying on a bug (IMHO). > > > > Remove the 0-3 range since otherwise we would have a 252 long > > interpolation that would slowly go between 0 and 3, looking really bad > > in userspace. > > > > We don't need the 0% point, userspace seems to handle this just fine > > because it uses the bl_power property to turn off the display. > > > > Signed-off-by: Alexandru Stan > > Acked-by: Daniel Thompson Thank you! > > Note also shouldn't this be patch 1 of the set. AFAICT it makes sense > whether or not the interpolation algorithm is changed. Yeah, I guess it could be. Sorry I didn't think of it that way before, I'm used to landing things in a group. In particular on veyron I assume it will almost be a noop without having my driver patch (especially with the findings of 0% not being that important). Feel free to land this independently. > > > Daniel. Alexandru Stan (amstan) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBF7C433DF for ; Thu, 15 Oct 2020 21:37:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 534AB20759 for ; Thu, 15 Oct 2020 21:37:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X9CbgZHP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WsvessV7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 534AB20759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TrMkc0F8iptfvxrlYpeksIHxFNpb4fbJoGnnFsKNlHQ=; b=X9CbgZHPW9q0jMnL3PcoA/V25 aglvimZW2E6giCmkAfG7xtkkwzp1rFWK+L3+mDHq3/7AOUAlIswLycQ4ujlv06d29LeaIq3Z2RtoP cBvNBAaG9Ujl1IJq5gCT5wefwwZDvYkqwOP1ih5IAcYvtkwynlHMeJnA3OULa3hM5pJUue4XdzvWb Hmd4rRk1pY2N/Lc8WfXi1vWGEXwl5x0hLh2tCgwqTX5oJZ9FQrac00YKiKNUgJaBDXohUu4OHxXhr 3ZliYd6mB7r6lYnBZFo87CVE8YNnodAaisW+ZDTn2IvKTFLiALd67opxkrkLmHfBaeOV1UqCOC9mh 6wzwYZIJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTAwO-0006yA-0d; Thu, 15 Oct 2020 21:37:40 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTAwL-0006xn-Jq for linux-rockchip@lists.infradead.org; Thu, 15 Oct 2020 21:37:38 +0000 Received: by mail-ej1-x644.google.com with SMTP id e22so235480ejr.4 for ; Thu, 15 Oct 2020 14:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=shNugDWCSFxMFaQhudWs8qBWQPZ07aTny77+Ie1FHlk=; b=WsvessV78yuDktprTp/4iqa3Adv1XtNl2N/v19ZJnZoqVtqW3R89jenV6efR955q/r w/t7xoaoNh7s+6TICZL6hGqJEjkuoQuGozFyTv0FDKf47JoY98kaBG86Az0J9yrlcxxG WWCFFWYtDAiJztGSud9FB31svTcPtnbTB6Mhc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=shNugDWCSFxMFaQhudWs8qBWQPZ07aTny77+Ie1FHlk=; b=lxiJZM/GxOWQGsosx731Wj+jtSnH2NNCcmChtkf9hW1YHvkriSvsa7XP7fFH7S2LJO OQfQyFCDlNX9UJF6FEiATo/1CdQWZCAdhqsrvw/qPmJPYgUc5k/NJiAc/rzDK8IxDGs/ X7CFMz4ati+STfT05wAIHhRrkGWw9gbalC0cJ1j3jeDcTFjtK8O296GaTxdvBdVbYjmG YSLLoCAz2Fm4FNupIbw2QVxGrseL7qtUvZSgb8z/jUEg8ZCyoI686SCFPHReENPsTBlF rjBZWmGLrMWfb+JheFy3i1295oVxWhoQf5k0JzsL3PEfiLCxWOvz+feP4FPJsaTD4Y1y nJAg== X-Gm-Message-State: AOAM530dPR0ha8ySduF6MsbZ9tNCqm3OwTJY6HYWFSuNcVicc33ZSzbI hMBnrulTmrXDTQBHido5/jjAj4niIcHatg== X-Google-Smtp-Source: ABdhPJwYe5sAb5SRJOXRshgPmyLbRneapsoWAIYzj7NnYtVNYYGa1Yp0OOfiBIaUZwRpGeCdmKe9fg== X-Received: by 2002:a17:906:5a82:: with SMTP id l2mr408282ejq.240.1602797855059; Thu, 15 Oct 2020 14:37:35 -0700 (PDT) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com. [209.85.218.49]) by smtp.gmail.com with ESMTPSA id si13sm246659ejb.49.2020.10.15.14.37.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 14:37:34 -0700 (PDT) Received: by mail-ej1-f49.google.com with SMTP id ce10so229452ejc.5 for ; Thu, 15 Oct 2020 14:37:34 -0700 (PDT) X-Received: by 2002:a50:e40b:: with SMTP id d11mr491296edm.198.1602797381996; Thu, 15 Oct 2020 14:29:41 -0700 (PDT) MIME-Version: 1.0 References: <20201013080103.410133-1-amstan@chromium.org> <20201013010056.v2.2.I96b8d872ec51171f19274e43e96cadc092881271@changeid> <20201014141946.mkrvpkrttucffkhj@holly.lan> In-Reply-To: <20201014141946.mkrvpkrttucffkhj@holly.lan> From: Alexandru M Stan Date: Thu, 15 Oct 2020 14:29:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/3] ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels To: Daniel Thompson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201015_173737_698516_B7B11FA9 X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Douglas Anderson , linux-kernel , Heiko Stuebner , Bartlomiej Zolnierkiewicz , Jingoo Han , Andy Gross , Rob Herring , Bjorn Andersson , "open list:ARM/Rockchip SoC..." , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Enric Balletbo i Serra , Lee Jones , Matthias Kaehlcke , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 7:19 AM Daniel Thompson wrote: > > On Tue, Oct 13, 2020 at 01:01:02AM -0700, Alexandru Stan wrote: > > After the "PWM backlight interpolation adjustments" patches, the > > backlight interpolation works a little differently. The way these > > dts files were working before was relying on a bug (IMHO). > > > > Remove the 0-3 range since otherwise we would have a 252 long > > interpolation that would slowly go between 0 and 3, looking really bad > > in userspace. > > > > We don't need the 0% point, userspace seems to handle this just fine > > because it uses the bl_power property to turn off the display. > > > > Signed-off-by: Alexandru Stan > > Acked-by: Daniel Thompson Thank you! > > Note also shouldn't this be patch 1 of the set. AFAICT it makes sense > whether or not the interpolation algorithm is changed. Yeah, I guess it could be. Sorry I didn't think of it that way before, I'm used to landing things in a group. In particular on veyron I assume it will almost be a noop without having my driver patch (especially with the findings of 0% not being that important). Feel free to land this independently. > > > Daniel. Alexandru Stan (amstan) _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A53C433E7 for ; Thu, 15 Oct 2020 21:31:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D51920759 for ; Thu, 15 Oct 2020 21:31:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MEliC8v6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WsvessV7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D51920759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WnBs5KhmXcHWcaFk0a/nspNE+IBHxaW35im3zCnSsqU=; b=MEliC8v6/PH0pTciEkx8nFy6+ 6nW5C4Pp8B61wyh3BRXDBmANZvqPDYGl4YjIAOHyYLx9OK27R33PGMA8yUt5knpiDkZaKUN29kfcM QpkcATOJ2/vGMfiPayJuWfICTBYuQP7yslNST2U+E5v2bIRG4UG/QSYW4tQgqts39/WMVNTmiGMx5 wTv92V+0XwHda0A/XLlVHm0WotMxd326bUp/cngGdJsdU+QQ/vrUSeauvOZvDgEr2TEmgv8ke6+OW 5NbEZh0oFtEnHlgfrwqtoXVsri3PKpBv8I856ZrzVaT8Hnkp4L1OdK1AfGVbIlZuiMGrKd7G6VVlR g7Kt3PHtw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTAoo-0005oG-Ix; Thu, 15 Oct 2020 21:29:50 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTAol-0005nO-4M for linux-arm-kernel@lists.infradead.org; Thu, 15 Oct 2020 21:29:48 +0000 Received: by mail-ej1-x641.google.com with SMTP id md26so168849ejb.10 for ; Thu, 15 Oct 2020 14:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=shNugDWCSFxMFaQhudWs8qBWQPZ07aTny77+Ie1FHlk=; b=WsvessV78yuDktprTp/4iqa3Adv1XtNl2N/v19ZJnZoqVtqW3R89jenV6efR955q/r w/t7xoaoNh7s+6TICZL6hGqJEjkuoQuGozFyTv0FDKf47JoY98kaBG86Az0J9yrlcxxG WWCFFWYtDAiJztGSud9FB31svTcPtnbTB6Mhc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=shNugDWCSFxMFaQhudWs8qBWQPZ07aTny77+Ie1FHlk=; b=NGP+MyhbHW6ym1e9QYc+ce+qQP6cBF4mxeu/HqDY5d83Z4+CPLyI6ARxJvUxr09c2P iNm8StXwErUJctXSMMYjNIlGByNVGwXHTk6s607nGV8U7nZkMjpIXagEhitI0wniykw8 p/a7vhuKmFlbXQWAt4H+wtPz1xJ6M13C2+D8ju16NlzfbBmDR7gOtiL6eBAJM9VYxKK5 FMEgYpMumpcnKTCaXkqETnoYYKwvo6gvlZX4HVhvpPNXleaF/rw9LQSH4UKG0CGG98A1 REboPYIN4PgjKJee3ZQfPs5qi23J1awpKu6m8zv4cOCPgzkYaatYWueyheRME/CVyTLX vghQ== X-Gm-Message-State: AOAM531bXZfHHjxTVMfiZ4kZgetGW/208Vs9RfjB6UdYoGRXsbkEfZrb xmHlMirwNfI9kgwEkvb1+Ocmk/HrDhvNKA== X-Google-Smtp-Source: ABdhPJw/Jp1TYjefXFR4Wre9jvah7AYUcsQThEWFcfFDO7JawBhFwNTGzQnDkaiB9Mo0CrdiMMY7NA== X-Received: by 2002:a17:906:fb0d:: with SMTP id lz13mr319135ejb.227.1602797383497; Thu, 15 Oct 2020 14:29:43 -0700 (PDT) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com. [209.85.208.52]) by smtp.gmail.com with ESMTPSA id 11sm244117ejy.19.2020.10.15.14.29.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 14:29:42 -0700 (PDT) Received: by mail-ed1-f52.google.com with SMTP id l24so212805edj.8 for ; Thu, 15 Oct 2020 14:29:42 -0700 (PDT) X-Received: by 2002:a50:e40b:: with SMTP id d11mr491296edm.198.1602797381996; Thu, 15 Oct 2020 14:29:41 -0700 (PDT) MIME-Version: 1.0 References: <20201013080103.410133-1-amstan@chromium.org> <20201013010056.v2.2.I96b8d872ec51171f19274e43e96cadc092881271@changeid> <20201014141946.mkrvpkrttucffkhj@holly.lan> In-Reply-To: <20201014141946.mkrvpkrttucffkhj@holly.lan> From: Alexandru M Stan Date: Thu, 15 Oct 2020 14:29:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/3] ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels To: Daniel Thompson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201015_172947_242998_35BC7E8E X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Douglas Anderson , linux-kernel , Heiko Stuebner , Bartlomiej Zolnierkiewicz , Jingoo Han , Andy Gross , Rob Herring , Bjorn Andersson , "open list:ARM/Rockchip SoC..." , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Enric Balletbo i Serra , Lee Jones , Matthias Kaehlcke , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 7:19 AM Daniel Thompson wrote: > > On Tue, Oct 13, 2020 at 01:01:02AM -0700, Alexandru Stan wrote: > > After the "PWM backlight interpolation adjustments" patches, the > > backlight interpolation works a little differently. The way these > > dts files were working before was relying on a bug (IMHO). > > > > Remove the 0-3 range since otherwise we would have a 252 long > > interpolation that would slowly go between 0 and 3, looking really bad > > in userspace. > > > > We don't need the 0% point, userspace seems to handle this just fine > > because it uses the bl_power property to turn off the display. > > > > Signed-off-by: Alexandru Stan > > Acked-by: Daniel Thompson Thank you! > > Note also shouldn't this be patch 1 of the set. AFAICT it makes sense > whether or not the interpolation algorithm is changed. Yeah, I guess it could be. Sorry I didn't think of it that way before, I'm used to landing things in a group. In particular on veyron I assume it will almost be a noop without having my driver patch (especially with the findings of 0% not being that important). Feel free to land this independently. > > > Daniel. Alexandru Stan (amstan) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel