All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 02/15] arm: cpu: armv8: add L3 memory flush support
Date: Fri, 26 Jun 2020 14:36:24 +0530	[thread overview]
Message-ID: <CAHO=5PEO8SkBfr0mzjDmVwBgSJC7AB0Nu7==pH0=HQucO_ShaA@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ2V3XK40c8Hi8vvNFPD1_F9dYffKb7SQTAmc3Zsz4fxnw@mail.gmail.com>

Hi Simon,

On Fri, Jun 26, 2020 at 7:13 AM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Rayagonda,
>
> On Fri, 19 Jun 2020 at 10:55, Rayagonda Kokatanur
> <rayagonda.kokatanur@broadcom.com> wrote:
> >
> > Hi Simon,
> >
> > On Wed, Jun 17, 2020 at 8:42 AM Simon Glass <sjg@chromium.org> wrote:
> > >
> > > On Wed, 10 Jun 2020 at 04:41, Rayagonda Kokatanur
> > > <rayagonda.kokatanur@broadcom.com> wrote:
> > > >
> > > > Add L3 memory flush support for NS3.
> > > >
> > > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> > > > ---
> > > >  arch/arm/cpu/armv8/Makefile          |  1 +
> > > >  arch/arm/cpu/armv8/bcmns3/Makefile   |  5 ++
> > > >  arch/arm/cpu/armv8/bcmns3/lowlevel.S | 90 ++++++++++++++++++++++++++++
> > > >  3 files changed, 96 insertions(+)
> > > >  create mode 100644 arch/arm/cpu/armv8/bcmns3/Makefile
> > > >  create mode 100644 arch/arm/cpu/armv8/bcmns3/lowlevel.S
> > > >
> > > > diff --git a/arch/arm/cpu/armv8/Makefile b/arch/arm/cpu/armv8/Makefile
> > > > index 2e48df0eb9..7e33a183d5 100644
> > > > --- a/arch/arm/cpu/armv8/Makefile
> > > > +++ b/arch/arm/cpu/armv8/Makefile
> > > > @@ -39,3 +39,4 @@ obj-$(CONFIG_S32V234) += s32v234/
> > > >  obj-$(CONFIG_TARGET_HIKEY) += hisilicon/
> > > >  obj-$(CONFIG_ARMV8_PSCI) += psci.o
> > > >  obj-$(CONFIG_ARCH_SUNXI) += lowlevel_init.o
> > > > +obj-$(CONFIG_TARGET_BCMNS3) += bcmns3/
> > > > diff --git a/arch/arm/cpu/armv8/bcmns3/Makefile b/arch/arm/cpu/armv8/bcmns3/Makefile
> > > > new file mode 100644
> > > > index 0000000000..a35e29d11a
> > > > --- /dev/null
> > > > +++ b/arch/arm/cpu/armv8/bcmns3/Makefile
> > > > @@ -0,0 +1,5 @@
> > > > +# SPDX-License-Identifier: GPL-2.0+
> > > > +#
> > > > +# Copyright 2020 Broadcom.
> > > > +
> > > > +obj-y  += lowlevel.o
> > > > diff --git a/arch/arm/cpu/armv8/bcmns3/lowlevel.S b/arch/arm/cpu/armv8/bcmns3/lowlevel.S
> > > > new file mode 100644
> > > > index 0000000000..202286248e
> > > > --- /dev/null
> > > > +++ b/arch/arm/cpu/armv8/bcmns3/lowlevel.S
> > > > @@ -0,0 +1,90 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0+ */
> > > > +/*
> > > > + * Copyright 2020 Broadcom
> > > > + *
> > > > + * Extracted from fsl-layerscape/lowlevel.S
> > >
> > > Should this file be common, then? Is the (c) correct?
> >
> > Do you mean, file "arch/arm/cpu/armv8/bcmns3/lowlevel.S" should be
> > common and for common file copyright tag should be "(C) Copyright
> > 2020"  instead of "Copyright 2020 Broadcom".
> >
>
> The comment suggests it was copied from another file, in which case
> you should keep the (c) from that file, perhaps adding your own.
>
> But if the two files are the same, can you just have one file and move
> it to a common location?

The comment is misleading.
Though it is copied from another file but both files are not same.
Let me remove that comment.

Thank you,
Rayagonda

>
> > Please let me know.
>
> Consider yourself let.
>
> Regards,
> Simon

  reply	other threads:[~2020-06-26  9:06 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 10:41 [PATCH v3 00/15] add initial support for broadcom NS3 soc Rayagonda Kokatanur
2020-06-10 10:41 ` [PATCH v3 01/15] board: ns3: add support for Broadcom Northstar 3 Rayagonda Kokatanur
2020-06-17  3:11   ` Simon Glass
2020-06-10 10:41 ` [PATCH v3 02/15] arm: cpu: armv8: add L3 memory flush support Rayagonda Kokatanur
2020-06-17  3:11   ` Simon Glass
2020-06-19 16:55     ` Rayagonda Kokatanur
2020-06-26  1:43       ` Simon Glass
2020-06-26  9:06         ` Rayagonda Kokatanur [this message]
2020-06-10 10:41 ` [PATCH v3 03/15] configs: ns3: enable clock subsystem Rayagonda Kokatanur
2020-06-17  3:11   ` Simon Glass
2020-06-17  6:44     ` Rayagonda Kokatanur
2020-06-10 10:41 ` [PATCH v3 04/15] dt-bindings: memory: ns3: add memory definitions Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-10 10:41 ` [PATCH v3 05/15] board: ns3: add api to save boot parameters passed from BL31 Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-26 17:15     ` Rayagonda Kokatanur
2020-06-10 10:41 ` [PATCH v3 06/15] board: ns3: default reset type to L3 Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-30  4:43     ` Rayagonda Kokatanur
2020-07-03  0:46       ` Simon Glass
2020-07-08  7:01         ` Rayagonda Kokatanur
2020-07-08 15:01           ` Simon Glass
2020-07-08 15:14             ` Rayagonda Kokatanur
2020-06-10 10:41 ` [PATCH v3 07/15] dt-bindings: memory: ns3: update GIC LPI address Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-07-04  7:50     ` Rayagonda Kokatanur
2020-07-04 18:50       ` Rayagonda Kokatanur
2020-07-05 18:21         ` Rayagonda Kokatanur
2020-07-06  5:26           ` Simon Glass
2020-07-06  6:23             ` Rayagonda Kokatanur
2020-07-08 15:21               ` Rayagonda Kokatanur
2020-06-10 10:41 ` [PATCH v3 08/15] board: ns3: program GIC LPI tables Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-07-05 18:14     ` Rayagonda Kokatanur
2020-06-10 10:41 ` [PATCH v3 09/15] configs: ns3: enable GIC ITS LPI table programing Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-10 10:41 ` [PATCH v3 10/15] dt-bindings: memory: ns3: add ddr memory definition Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-10 10:41 ` [PATCH v3 11/15] board: ns3: define ddr memory layout Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-10 10:41 ` [PATCH v3 12/15] board: ns3: limit U-boot relocation within 16MB memory Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-26 10:21     ` Rayagonda Kokatanur
2020-06-29 17:26       ` Simon Glass
2020-07-08  8:17         ` Rayagonda Kokatanur
2020-06-10 10:41 ` [PATCH v3 13/15] include/configs: ns3: add env variables for Linux boot Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-26 18:08     ` Rayagonda Kokatanur
2020-06-10 10:41 ` [PATCH v3 14/15] include/configs: ns3: add support for flashing images Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-10 10:41 ` [PATCH v3 15/15] MAINTAINERS: update maintainers for broadcom ns3 platform Rayagonda Kokatanur
2020-06-26  1:11   ` Simon Glass
2020-06-26 14:27   ` Peter Tyser
2020-06-26 14:30     ` Rayagonda Kokatanur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHO=5PEO8SkBfr0mzjDmVwBgSJC7AB0Nu7==pH0=HQucO_ShaA@mail.gmail.com' \
    --to=rayagonda.kokatanur@broadcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.