From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rayagonda Kokatanur Date: Thu, 30 Apr 2020 16:33:24 +0530 Subject: [PATCH v1 3/3] drivers: pinctrl-single: add request api In-Reply-To: References: <20200429163446.15390-1-rayagonda.kokatanur@broadcom.com> <20200429163446.15390-4-rayagonda.kokatanur@broadcom.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On Wed, Apr 29, 2020 at 11:34 PM Simon Glass wrote: > > Hi Rayagonda, > > +Stephen Warren > > On Wed, 29 Apr 2020 at 10:36, Rayagonda Kokatanur > wrote: > > > > Add pinctrl_ops->request api to configure pctrl > > pad register in gpio mode. > > > > Signed-off-by: Rayagonda Kokatanur > > --- > > drivers/pinctrl/pinctrl-single.c | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > This should use the Kconfig also (and needs a test) Please elaborate "need a test". Do you mean a testing procedure as part of the commit message ? I feel we don't need the Kconfig option, looking at Linux pinctrl-single driver. Please let me know. > > Regards, > Simon