From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org, Rob Herring <robh@kernel.org>,
Chris Healy <cphealy@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Lucas Stach <l.stach@pengutronix.de>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Lee Jones <lee.jones@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Machek <pavel@ucw.cz>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Subject: Re: [PATCH v10 2/5] serdev: Introduce devm_serdev_device_open()
Date: Sun, 5 Nov 2017 14:19:48 -0800 [thread overview]
Message-ID: <CAHQ1cqFQJUGuZ7DPkkDkcztMnapoyzBEdbKD17-GNzcTrKx9FA@mail.gmail.com> (raw)
In-Reply-To: <20171105153857.GC13118@localhost>
On Sun, Nov 5, 2017 at 7:38 AM, Johan Hovold <johan@kernel.org> wrote:
> On Tue, Oct 31, 2017 at 09:36:53AM -0700, Andrey Smirnov wrote:
>> Add code implementing managed version of serdev_device_open() for
>> serdev device drivers that "open" the device during driver's lifecycle
>> only once (e.g. opened in .probe() and closed in .remove()).
>>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-serial@vger.kernel.org
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: cphealy@gmail.com
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Cc: Johan Hovold <johan@kernel.org>
>> Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> ---
>> Documentation/driver-model/devres.txt | 3 +++
>> drivers/tty/serdev/core.c | 27 +++++++++++++++++++++++++++
>> include/linux/serdev.h | 1 +
>> 3 files changed, 31 insertions(+)
>
>> +int devm_serdev_device_open(struct device *dev, struct serdev_device *serdev)
>> +{
>> + struct serdev_device **dr;
>> + int ret;
>> +
>> + dr = devres_alloc(devm_serdev_device_release, sizeof(*dr), GFP_KERNEL);
>> + if (!dr)
>> + return -ENOMEM;
>> +
>> + ret = serdev_device_open(serdev);
>> + if (ret) {
>> + devres_free(dr);
>> + return ret;
>> + }
>> +
>> + *dr = serdev;
>> + devres_add(dev, dr);
>> +
>> + return ret;
>
> This would be more readable as return 0.
Sure, I'll change that in v11.
Thanks,
Andrey Smrinov
next prev parent reply other threads:[~2017-11-05 22:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 16:36 [PATCH v10 0/5] ZII RAVE platform driver Andrey Smirnov
2017-10-31 16:36 ` Andrey Smirnov
2017-10-31 16:36 ` [PATCH v10 1/5] serdev: Make .remove in struct serdev_device_driver optional Andrey Smirnov
2017-11-01 23:48 ` Rob Herring
2017-11-04 11:24 ` Greg Kroah-Hartman
2017-11-04 17:05 ` Sebastian Reichel
2017-10-31 16:36 ` [PATCH v10 2/5] serdev: Introduce devm_serdev_device_open() Andrey Smirnov
2017-11-01 23:48 ` Rob Herring
2017-11-05 15:38 ` Johan Hovold
2017-11-05 22:19 ` Andrey Smirnov [this message]
2017-10-31 16:36 ` [PATCH v10 3/5] mfd: Add driver for RAVE Supervisory Processor Andrey Smirnov
2017-11-05 15:38 ` Johan Hovold
2017-11-05 22:02 ` Andrey Smirnov
2017-10-31 16:36 ` [PATCH v10 4/5] watchdog: Add RAVE SP watchdog driver Andrey Smirnov
2017-10-31 17:21 ` Guenter Roeck
2017-11-04 11:24 ` Greg Kroah-Hartman
2017-11-05 15:55 ` Guenter Roeck
2017-11-05 15:47 ` Johan Hovold
2017-11-05 18:34 ` Guenter Roeck
2017-11-05 21:59 ` Andrey Smirnov
2017-10-31 16:36 ` [PATCH v10 5/5] dt-bindings: watchdog: Add bindings for " Andrey Smirnov
2017-10-31 17:22 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHQ1cqFQJUGuZ7DPkkDkcztMnapoyzBEdbKD17-GNzcTrKx9FA@mail.gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=cphealy@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nikita.yoush@cogentembedded.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.