From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08923C43381 for ; Wed, 27 Mar 2019 02:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFF592075E for ; Wed, 27 Mar 2019 02:52:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ufweQqEo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732572AbfC0CwP (ORCPT ); Tue, 26 Mar 2019 22:52:15 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:35179 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731613AbfC0CwO (ORCPT ); Tue, 26 Mar 2019 22:52:14 -0400 Received: by mail-io1-f65.google.com with SMTP id p16so12766083iod.2 for ; Tue, 26 Mar 2019 19:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h0IJ+MH5OSuGxxK0D8lkmMDIBMpmeV0ZDi4PvtT4p5s=; b=ufweQqEosTQOEMsEL5slwmwgLqEfVYE9wFS5gd41yZFWNZuCwik6gjUJpl+ll+nB5l JHVAK2n+Msv9ATGhkbicwHG9yYCe5yTet3y2/+L460t0cI5IsknIL0bJh5O20doEcK6C YOckD8cXkC3ntBFqINX1fQq7y6WUqZz9ciYoD/mtw6D6V0TuqRGkaAUJinI1QpNDIoBd XRykmqi1VfjphRm12/I94tbFmNYqPwq99miA9aTnTzZytCQUqNy9V/OwwXnLLbUIwule sldvbcdtFPXrMjjwJiTImNGqRAlZIHyfTqqil7NCBri+9OIsbcNtg7vvMdBDsKYV/qXt OnWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h0IJ+MH5OSuGxxK0D8lkmMDIBMpmeV0ZDi4PvtT4p5s=; b=jPwpXaAUEfCsBOP/QQeDDc7mnE+GgTjj5zJdDT/3t07j8jEG3DUw5hhfsYdTfPr8HX U1bv8YntFmu1KiR11CT11npManx0V4IUs1jeE0bOMh3xxXic+rqFp4jrjxIcZljZLkrw 0rcbxnFCb3k4ht/Tz9W5Wyxr7BKmOfHZZqgDBTlE2Yydbul1wxG9d9E4KO4YyhlpNSvV g1kPovDXYqBld3uIVUtWfdDtFD7fbrq65tzinP0etYN3h2Ul6L6K9KClHlFRJZ1OLiIs dx9xki/OuNhHcoElK5H4R5/VBHkrFzBaBygth488v2OsKeOYO0AdqSr3tHnBuLurIEvR n4rA== X-Gm-Message-State: APjAAAVkgllSeFX6BIDlA6VJqfRNcw7fXZeKqaoPrQ3FAQO9WlUZa3h0 ztFs+dgV1C5myR0eBZ6LwOt2yd1olV3cDqVdV4c= X-Google-Smtp-Source: APXvYqwZbrvHRN0nJGtcVYt+726zrDWuLQRt00iSnk3RndSYOfl66VHmjVgwzgC5zYRpG/f9cpCzwQWvjLgE3TnMdfE= X-Received: by 2002:a5d:8b97:: with SMTP id p23mr1374480iol.83.1553655133818; Tue, 26 Mar 2019 19:52:13 -0700 (PDT) MIME-Version: 1.0 References: <20190325050100.29517-1-andrew.smirnov@gmail.com> In-Reply-To: From: Andrey Smirnov Date: Tue, 26 Mar 2019 19:52:02 -0700 Message-ID: Subject: Re: [PATCH] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA To: Fabio Estevam Cc: Shawn Guo , Angus Ainslie , linux-kernel , Chris Healy , Fabio Estevam , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Lucas Stach Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 25, 2019 at 3:49 AM Fabio Estevam wrote: > > Hi Andrey, > > On Mon, Mar 25, 2019 at 2:01 AM Andrey Smirnov wrote: > > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > > index 9f9aa6e7ed0e..354feba077b2 100644 > > --- a/arch/arm/boot/dts/imx6qdl.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > > @@ -949,7 +949,7 @@ > > compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; > > reg = <0x020ec000 0x4000>; > > interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; > > - clocks = <&clks IMX6QDL_CLK_SDMA>, > > + clocks = <&clks IMX6QDL_CLK_IPG>, > > This problem affects other i.MX SoCs, such as i,MX6SX as originally > reported here: > https://patchwork.kernel.org/patch/10864867/ > > So I think we need either a dtsi fix for the other i.MX SoCs or maybe > a fix in the SDMA driver? I think it is worth fixing in DT, regardless if we do anything about SDMA driver or not. I'll add fixes for 6SX and 7D in v2. Thanks, Andrey Smirnov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF4CC43381 for ; Wed, 27 Mar 2019 02:52:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E6D12075E for ; Wed, 27 Mar 2019 02:52:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QUxsuD0F"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ufweQqEo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E6D12075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bo8QTLYzWFHIx+55DYyifaloxS44BXY1Z7/87xlCYUg=; b=QUxsuD0FlX58mK nLFZCkkyvhEDtDd2fN+jFGs630OQkdPvn6kzRwYDHtIgf6JkJpoGbIVa8U6InQcz2bqYarNiCRe2b AoJ+1lZBsKnYWRaFydq26jbfLcOnjb4vO988FUxyhiVkb3kz2MAR1uJEoJUePVntyPpCthMT8IeVN Xy/yuO76LV7UJpr7nCsMgEh2EJ8KZjUAUfQwFI/lh/aRUOxkPVRikZY8ur/4dZX2bK1MDVhLBuTpN 3RwSqxrg/6yd3yrp5n7ZYodqHtVVBkFTkHV28V1onTQ44bnT6XfMepTEADxHEhjL/qTLtwVb+qmtA qpGL0c3lyh7wrBAuX6mA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8yft-0000Pd-Kt; Wed, 27 Mar 2019 02:52:21 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8yfo-0000On-LL for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 02:52:19 +0000 Received: by mail-io1-xd44.google.com with SMTP id b9so12718161iot.13 for ; Tue, 26 Mar 2019 19:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h0IJ+MH5OSuGxxK0D8lkmMDIBMpmeV0ZDi4PvtT4p5s=; b=ufweQqEosTQOEMsEL5slwmwgLqEfVYE9wFS5gd41yZFWNZuCwik6gjUJpl+ll+nB5l JHVAK2n+Msv9ATGhkbicwHG9yYCe5yTet3y2/+L460t0cI5IsknIL0bJh5O20doEcK6C YOckD8cXkC3ntBFqINX1fQq7y6WUqZz9ciYoD/mtw6D6V0TuqRGkaAUJinI1QpNDIoBd XRykmqi1VfjphRm12/I94tbFmNYqPwq99miA9aTnTzZytCQUqNy9V/OwwXnLLbUIwule sldvbcdtFPXrMjjwJiTImNGqRAlZIHyfTqqil7NCBri+9OIsbcNtg7vvMdBDsKYV/qXt OnWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h0IJ+MH5OSuGxxK0D8lkmMDIBMpmeV0ZDi4PvtT4p5s=; b=Ly1fYfKoKWNVtgQSTXT4d639E+JRtVlewtDGxjwqC+b0UTFvFUFIGhZgoRgYeqmU68 j7v7bA1mfosKFfCK+2vb2qt2ACV/v8QjBCfdZkUeW8ra0H8W9fblsxSm8e9Ob7wUE+5O 5gsXy8GOq47xZNPopjmPXVao3kjiAawcy+1/3fLbTS45EEi6s4V8S+W0PLKjb1p3hGND z1urHwTYiW/6JYoSApHH43dUFTUnJsBqVnvCWjjYWySize7CCUNaQOXFkediexHivgR0 FQE1VE1g8gjz7iYBpX/d0s8m9MI4XMkpBtcxfHrRu1SASdGnzwpg1BLr7IQvp121rz5E 7mzg== X-Gm-Message-State: APjAAAXF7tYtV52ktvL06Gq+0gCR7+mb32rf5MdSNwBVRi1Kw1fi+BID vDs5LnkV0epNaHVxBSMaVo0Jc4IiQPCiSLdPpsk= X-Google-Smtp-Source: APXvYqwZbrvHRN0nJGtcVYt+726zrDWuLQRt00iSnk3RndSYOfl66VHmjVgwzgC5zYRpG/f9cpCzwQWvjLgE3TnMdfE= X-Received: by 2002:a5d:8b97:: with SMTP id p23mr1374480iol.83.1553655133818; Tue, 26 Mar 2019 19:52:13 -0700 (PDT) MIME-Version: 1.0 References: <20190325050100.29517-1-andrew.smirnov@gmail.com> In-Reply-To: From: Andrey Smirnov Date: Tue, 26 Mar 2019 19:52:02 -0700 Message-ID: Subject: Re: [PATCH] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA To: Fabio Estevam X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_195217_524930_5114C408 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angus Ainslie , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Fabio Estevam , Shawn Guo , Chris Healy , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2019 at 3:49 AM Fabio Estevam wrote: > > Hi Andrey, > > On Mon, Mar 25, 2019 at 2:01 AM Andrey Smirnov wrote: > > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > > index 9f9aa6e7ed0e..354feba077b2 100644 > > --- a/arch/arm/boot/dts/imx6qdl.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > > @@ -949,7 +949,7 @@ > > compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; > > reg = <0x020ec000 0x4000>; > > interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; > > - clocks = <&clks IMX6QDL_CLK_SDMA>, > > + clocks = <&clks IMX6QDL_CLK_IPG>, > > This problem affects other i.MX SoCs, such as i,MX6SX as originally > reported here: > https://patchwork.kernel.org/patch/10864867/ > > So I think we need either a dtsi fix for the other i.MX SoCs or maybe > a fix in the SDMA driver? I think it is worth fixing in DT, regardless if we do anything about SDMA driver or not. I'll add fixes for 6SX and 7D in v2. Thanks, Andrey Smirnov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel