Re: [PATCH Version 2 0/2] Adding to tracepoints

[Trond Myklebust <trond.myklebust@primarydata.com>]

On Fri, Dec 18, 2015 at 1:52 PM, Olga Kornievskaia <aglo@umich.edu> wrote:
> Trond,
>
> I have had wireshark accept the patch to display the crc32 hash of the
> stateid's other field to match the output in the tracepoints. Can you
> please provide feedback about the proposed additions to tracepoints?
>

The patches looked OK to me. They do change message formats, but since
you are just appending to existing tracepoints, then that is ok.

I'm queuing these for the Linux 4.5 merge window.

> Thank you.
>
> On Wed, Dec 9, 2015 at 3:59 PM, Olga Kornievskaia <aglo@umich.edu> wrote:
>> Trond,
>>
>> Any thoughts on the patches?
>>
>> Thank you.
>>
>> On Tue, Nov 24, 2015 at 1:29 PM, Olga Kornievskaia <kolga@netapp.com> wrote:
>>> First patch adds stateid information to tracepoints (openstateid, delegation
>>> stateid, and locking stateid). Version 2 of this patch fixes two things from
>>> the previous version: (1) typo in printout missing ":" in one stateid, (2)
>>> close tracepoint should take stateid from the args instead of the state passed
>>> in as state's stateid could be delegation stateid.
>>>
>>> Second patch adds a new tracepoint nfs_cached_open()
>>>
>>> Olga Kornievskaia (2):
>>>   Adding stateid information to tracepoints
>>>   Adding tracepoint to cached open
>>>
>>>  fs/nfs/internal.h  |   9 ++
>>>  fs/nfs/nfs4proc.c  |  15 +--
>>>  fs/nfs/nfs4trace.h | 294 ++++++++++++++++++++++++++++++++++++++++++++++++-----
>>>  3 files changed, 286 insertions(+), 32 deletions(-)
>>>
>>> --
>>> 1.8.3.1
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html