From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] pnfs/blocklayout: serialize GETDEVICEINFO calls
Date: Fri, 26 Sep 2014 10:29:34 -0400 [thread overview]
Message-ID: <CAHQdGtTg8Tc8bRqbezW-ZWrcTJdG233uRTrqQMP5CvxAcjW9Fg@mail.gmail.com> (raw)
In-Reply-To: <1411740170-18611-2-git-send-email-hch@lst.de>
On Fri, Sep 26, 2014 at 10:02 AM, Christoph Hellwig <hch@lst.de> wrote:
> The rpc_pipefs code isn't thread safe, leading to occasional use after
> frees when running xfstests generic/241 (dbench).
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/nfs/blocklayout/rpc_pipefs.c | 14 +++++++++-----
> fs/nfs/netns.h | 1 +
> 2 files changed, 10 insertions(+), 5 deletions(-)
>
>
It worries me that we're putting a mutex directly in the writeback
path. For small arrays, it might be acceptable, but what if you have a
block device with 1000s of disks on the back end?
Is there no better way to fix this issue?
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2014-09-26 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:02 blocklayout GETDEVICEINFO fix Christoph Hellwig
2014-09-26 14:02 ` [PATCH] pnfs/blocklayout: serialize GETDEVICEINFO calls Christoph Hellwig
2014-09-26 14:29 ` Trond Myklebust [this message]
2014-09-26 15:48 ` Christoph Hellwig
2014-09-26 16:21 ` Trond Myklebust
2014-09-26 16:41 ` Christoph Hellwig
2014-10-24 14:29 ` Christoph Hellwig
2014-11-05 8:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHQdGtTg8Tc8bRqbezW-ZWrcTJdG233uRTrqQMP5CvxAcjW9Fg@mail.gmail.com \
--to=trond.myklebust@primarydata.com \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.